get id from mysql for edit and delete page

[leefrand377]

I've been struggling with this php script for 2 days and cannot figure out why it does not return an id* from mysql in the url. Maybe someone could help with this one. I've done scripts almost identical to this in the past with success, but this has me stumped. I'm sure it must be something simple that I am missing.
Here's the code:

<?php*
/**This*script*deletes*a*record.**/
print*'<h2>Delete*a*Record</h2>';
//*Need*the*database*connection:
$link*=*mysql_connect('myDomain,*myID,*myPassword');*
if*(!$link)*{*
****die('Could*not*connect:*'*.*mysql_error());*
*}*
mysql_select_db(myDatabase);*
if*(isset($_GET['id'])*&&*is_numeric($_GET['id'])*&&*($_GET['id']*>*0)*)*{*//*Display*the*quote*in*a*form:

//*Define*the*query:
$query*=*"SELECT***FROM*myTablename*WHERE*id={$_GET['id']}";
if*($result*=*mysql_query($query,*$link))*{*//*Run*the*query.

	$row*=*mysql_fetch_array($result);*//*Retrieve*the*information.

	//*Make*the*form:
	print*'<form*action="myTablename_delete.php"*method="post">
	Are*you*sure*you*want*to*delete*this*Record?
	<div><p*class="centerp">'*.*stripslashes($row['title'])*.*'</div>
	<input*type="hidden"*FullName="id"*value="'*.*$_GET['id']*.*'"*/>
	<input*type="submit"*FullName="submit"*value="Delete*this*Record!"*/>
	</form>';

}*else*{*//*Couldn't*get*the*information.
	print*'<p*class="error">Could*not*retrieve*the*Record*because:<br*/>'*.*mysql_error($link)*.*'.</p><p>The*query*being*run*was:*'*.*$query*.*'</p>';
}

}*elseif*(isset($_POST['id'])*&&*is_numeric($_POST['id'])*&&*($_POST['id']*>*0)*)*{*//*Handle*the*form.

//*Define*the*query:
$query*=*"DELETE*FROM*myTablename*WHERE*id={$_POST['id']}*LIMIT*1";
$result*=*mysql_query($query,*$link);*//*Execute*the*query.

//*Report*on*the*result:
if*(mysql_affected_rows($link)*==*1)*{
	print*'<p*class="centerp">The*record*has*been*deleted.</p>';
}*else*{
	print*'<p*class="error">Could*not*delete*the*Record*because:<br*/>'*.*mysql_error($link)*.*'.</p><p>The*query*being*run*was:*'*.*$query*.*'</p>';
}

}*else*{*//*No*ID*received.
	print*'<p*class="error">This*page*has*been*accessed*in*error.</p>';
}*//*End*of*main*IF.

mysql_close($link);*//*Close*the*connection.
echo*'<h3>Site*Admin</h3><p*class="centerp"><a*href="myTablename_view.php">View*all*Records</a></p>';*
?>

[bradgrafelman]

Welcome to PHPBuilder! When posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

Here are a few issues I noticed in the code snippet you posted above:

1. There are a lot of asterisks strewn throughout the code, and I'm guessing you didn't put them there originally. This is likely a result of the forum's software replacing non-standard spaces (e.g. non-breaking spaces, U+00A0) with asterisks. You might want to make sure whatever code editor you're using isn't inserting such characters.

2. Stop Using the MySQL Extension!

3. Do you have display_errors (and/or log_errors) set to On and error_reporting set to E_ALL (or better)? If so, are you getting any PHP error messages? (If not.. why not??)

   You've mentioned what you expect to get from this script, but you haven't told us much at all about what you are actually getting instead.

4. You're only passing a single argument to [man]mysql_connect/man, but that argument looks more like it should have been three separate arguments (namely server, username, and password).

5. You never check to see if [man]mysql_fetch_array/man returned boolean FALSE before you attempt to use its return value as an associative array.

6. Why are you using [man]stripslashes/man on data coming directly from your DB? You shouldn't need to do this.

7. Your HTML output contains <input> elements with a 'FullName' attribute, but that attribute doesn't exist in any HTML spec that I'm aware of. What's the purpose of this attribute?

[leefrand377]

Thanks for your reply.
1. The asterisks are not in my original code.
2. I am in the process of changing the ext.
3. Sorry about not showing the error message. It is: // No ID received.
print '<p class="error">This page has been accessed in error.</p>';
4. I don't understand your question, but I am connecting using server, username, and password.
5. How do I check for that?
6. I took the stripslashes out. Thanks.
7. The FullName attribute is one of the fields that was queried with SELECT *.
I have updated the form, as follows-
print '<form action="vols_delete.php" method="post">
Are you sure you want to delete this Record?
<div><p class="centerp">' . ($row['FullName']) . '</div>
<input type="hidden" name="FullName" value="' . $_GET['id'] . '" />
<p><input type="submit" FullName="submit" value="Delete this Record!" /></p>
</form>';
leefrand377