Check through output in array

[genista]

Hi,

I have code so that users can make comments on a page, they have a choice to have their name displayed or be anonymous. I want to order the comments by the date they were made, and display the name or 'anonymous poster' if they selected anonymous.

So I have this code which grabs everything into an array, but the if statement within the array is not working, in testing, when I select anonymous the page still displays the name of the user. What is the best way around this?

The following code is where I am stuck:

echo "<h3>Comments for this article:</h3>";
while($fetch=mysql_fetch_array($query)) {
$anonymous=$fetch['anonymous'];
if ($anonymous===true){
echo "<p>".$fetch['comment']."<br/><sub><b>Comment by: </b>'Anonymous Poster'</sub><hr /><p>";
  }
  else{ 
 echo "<p>".$fetch['comment']."<br/><sub><b>Comment by: </b>".$fetch['userid']."</sub><hr /><p>";     

 }
}

Thanks,


G

[Weedpacket]

Well, there's the issue that you're still using the MySQL extension.

But have you checked to see what [font=monospace]$fetch['anonymous'][/font] contains? Is it a boolean? Is it [font=monospace]true[/font]? The type matters because of the comparison operator you're using.

[genista]

Thanks, where it is true, the value is true.

G

[Weedpacket]

genista wrote:

Thanks, where it is true, the value is true.

But have you checked?

[genista]

I have checked, some are true where anonymous has been set.

[Weedpacket]

What do you get for [font=monospace]var_dump($fetch['anonymous'])[/font]?

[traq]

genista;11023813 wrote:

Thanks, where it is true, the value is true.

...what I'm wondering (and I wouldn't be surprised if this is also what Weedpacket is wondering) is if it is the boolean true, or the string "true".

[genista]

Ok, I see where your going and yes you are correct. I have now changed ===true to ="true" and we have success! Feel a bit stupid though....

Thanks Weedpacket!

[traq]

genista;11023835 wrote:

Ok, I see where your going and yes you are correct. I have now changed ===true to ="true" and we have success! Feel a bit stupid though....

Thanks Weedpacket!

mm...

if( $var = true ) # will _always_evaluate_as_TRUE_ ( assignment )

if( $var == true ) # this is *probably* the one you want ( type-insensitive comparison )

if( $var === true ) # only true if $var is true _and_ a boolean ( type-sensitive comparison )

However, realize that, depending on how you're storing this info in the DB, you might still have problems. For example:

• NULL (a missing value) will compare false

• "False" (a string) will compare true

• "" (an empty string) will compare false

• "0" (the character zero) will compare false

• . . .

[genista]

Thanks!

[traq]

sorry; see my edits above

[dalecosp]

genista;11023835 wrote:

Feel a bit stupid though....

Unfortunately, PHP can do that to ya ... generally at least a couple times a week, here. 😉