session_register causing problems

qim

I dapted a script I found on the web to meke a login in my page. Unfortunately the end of it does not work and it appears to be due to deprecated functions, which I don't even understand what thet are supposed to do.

The login seems to work as I get a white page if the data is corrcet and the error message if it is not. What does not work is the connection between the end of the login script and another one that declares success and returns the vivitor to the front page. I am pasting below the end of one and the total of the other. Any help would be much appreciated, before I lose all my hairs!

$sql="SELECT * FROM $tbl_name WHERE user='$user' and password='$password'"; 
 $result=mysql_query($sql);


// Mysql_num_row is counting table row
 $count=mysql_num_rows($result);



// If result matched $user and $password, table row must be 1 row

if($count==1)


{

// Register $username, $password and redirect to file "login_success.php"
session_register('user');
session_register('password'); 
 header("login_success.php");
 }


 else {
 echo "Wrong Username or Password, or you have not registered yet.<br>
 Please, go back and either reenter your login details, or press the register button";
 }

 ?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
 <head>
  <title> New Document </title>
  <meta name="Generator" content="EditPlus">
  <meta name="Author" content="">
  <meta name="Keywords" content="">
  <meta name="Description" content="">
 </head>

 <body>
  // Check if session is not registered, redirect back to main page. 
// Put this code in first line of web page. 
<?php
 session_start();
 if(!session_is_registered(user)){
 header("register.php");
 }
 ?>

 <html>
 <body>
 Login Successful
 </body>
 </html>
 </body>
</html>

jeepin81

Look at your [EMAIL="http://php.net/manual/en/function.header.php"]header[/EMAIL] code.

qim

Sorry. I don't understand. The first script is truncated because only the end is relevant (I think). I'm very new to this and I am at a loss as to how to rewrite those two lines.

Thank you

jeepin81

header("Location: yourpage.php");

you're missing the "Location:". I tried to link to the manual but it didn't work :/..

qim

Do you mean?

<html>
 <body>
 Login Successful
 </body>
 </html>
 </body>
</html>

That's how it was when I got it. Strange but felt it did not affect the code. Should I leave it as

 Login Successful
 </body>
 </html>

qim

ok. Got it! But I enter the location as being

header("register.php");

register.php is on the same folder and at this stage where I have nowhere to send the visitor..
(only have two pges) register.php is a sgood as anything else.

Is this not correct?

Weedpacket

qim wrote:
Is this not correct?

No, it's not correct. see jeepin81's post. Further, it should be noted that the URL in a Location: header should be a full absolute URL to comply with the HTTP protocol.

qim

Hi thanks

My problem is that I don't understand what this code does or is trying to do. I have changed a couple of lines following advice from older threads. Could you explain what is going on here, please?
First, the end of the main php script.

session_start();
$_SESSION['username'] = 'pintotou_camilo';
$_SESSION['password'] = 'Benfica1';


 header("login_success.php");
 }


 else {
 echo "Wrong Username or Password, or you have not registered yet.<br>
 Please, go back and either reenter your login details, or press the register button";
 }

 ?>

Then the confirmation login script

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
 <head>
  <title> New Document </title>
  <meta name="Generator" content="EditPlus">
  <meta name="Author" content="">
  <meta name="Keywords" content="">
  <meta name="Description" content="">
 </head>

 <body>
  // Check if session is not registered, redirect back to main page. 
// Put this code in first line of web page. 
<?php
 //session_start();
 //if(!session_is_registered(user)){
 session_start();
if(!isset($_SESSION['$username'])){
    // not logged in


 header("register.php");
 }
 ?>


 Login Successful

 </body>
</html>

jeepin81

You're trying to redirect the user via this code:

 header("login_success.php");

The problem is that bit of code is NOT correct. To learn more click this link -> PHP HEADER. That is a page from the PHP Manual.

Here is an example of what your code should look like:

header("Location: http://your-site.com/your-page.php");

As Weekpacket explained you'll want to use the absolute URL - I missed that part in my post.

HTH

qim

Thank you very much. I will change that. Could you explin ine thing that's got me confused? Who is username in if(!isset($_SESSION['$username'])){
I ask this because $username in the script refers first to the datbase authorized user (me) and then to the member who is logging in. I am not sure what to put there.

qim

Weedpacket

In [font=monospace]$_SESSION['$username'][/font] the second [font=monospace]$[/font] should not be there (see Single-quoted strings. If you want the [font=monospace]'username'[/font] element, say [font=monospace]'username'[/font].

qim wrote:
I ask this because $username in the script refers first to the datbase authorized user (me) and then to the member who is logging in.

At the moment it doesn't refer to anything because you never set it anywhere. But if you're using the same variable for two different things in the one script, you're going to confuse yourself.

qim

Hi Thanks

Irrespective of the confusion over two variables withe same name, which I am aware of, what I wante dto know was to what varibale does the if(!isset($_SESSION['$username'])){
refer to. is it the database owner (me) or the person that is registering.

Thank you

qim

Weedpacket

qim wrote:
what I wante dto know was to what varibale does the...refer to

You're supposed to know; you're the one writing this. But none of the code you've posted either connects to a database nor does it handle any sort of login. If you look at the bits of the code where either of those happen you should be able to see if the session variables are there or not.

qim

Dear Weedpacket

First, if I knew I would not be asking. Then, the code that i sent, and as I explained at the beginning, is not the full code but only the one that is relevant. Lastly, you talk about connection, but that is not my question (the connection is fine).

Anyway, thank you very much for the time you wasted reading this thread.

qim

RESOLVED!

Thank you.

dalecosp

Great ! Please consider using the "Thread Tools" dropdown to mark this as resolved ... then it will appear in the thread title 😉