Combining two php calculations into one

IsItFast

So I have no idea how to write this type of calculation so I hired someone to do it. While the first calculation worked as needed, I need some other calculation to be added to it which is very similar. I've tried hiring a few people but they can't figure it out. This is for Opencart using a CFO extension which allows custom php calculations to be used to calculate the price. I was told the elseif command needs to be used but not sure how to incorporate it. Below is an example. The numbers in {} are option ID numbers for the product in which each has a value inputted by the customer.

0;
if({27}>54) 
{
   if({16}>74)
   {
   _Price = $Price + (({27}-54)*3) + (({16}-74)*3) + {38P};
   }
   else
   {
   _Price = $Price + (({27}-54)*3) + {38P};
   }
}
else
{
   if ({16}>74)
   {
   _Price = $Price + (({16}-74)*3) + {38P};
   }
   else
   {
   _Price = $Price + {38P};
   }
}
---------------------------------
Conditions below need to add to the calculation above.
---------------------------------

if({45}>24) 
{
   if({44}>54)
   {
   _Price = $Price + (({45}-24)*3) + (({44}-54)*3);
   }
   else
   {
   _Price = $Price + (({45}-24)*3);
   }
}
else
{
   if ({44}>54)
   {
   _Price = $Price + (({44}-54)*3);
   }
   else
   {
   _Price = $Price;
   }
}

Hopefully that makes sense to someone on here or can help point me in the right direction. Thanks in advance.

Weedpacket

There must be a cleaner way to do it, but I'm not that familiar with OpenCart (certainly not enough to know why it needs a whole 'nother language when it's already using PHP). What is the significance of [font=monospace]_Price[/font] versus [font=monospace]$Price[/font]?

As someone who hasn't the first idea how the system works (or is supposed to work, or even how it's supposed to be used for that matter), I would expect:

if({27}>54) 
{
	if({16}>74)
	{
		if({45}>24) 
		{
			if({44}>54)
			{
				_Price = $Price + (({27}-54)*3) + (({16}-74)*3) + {38P} + (({45}-24)*3) + (({44}-54)*3);
			}
			else
			{
				_Price = $Price + (({27}-54)*3) + (({16}-74)*3) + {38P} + (({45}-24)*3);
			}
		}
		else
		{
			if ({44}>54)
			{
				_Price = $Price + (({27}-54)*3) + (({16}-74)*3) + {38P} + (({44}-54)*3);
			}
			else
			{
				_Price = $Price + (({27}-54)*3) + (({16}-74)*3) + {38P};
			}
		}
	}
	else
	{
		if({45}>24) 
		{
			if({44}>54)
			{
				_Price = $Price + (({27}-54)*3) + {38P} + (({45}-24)*3) + (({44}-54)*3);
			}
			else
			{
				_Price = $Price + (({27}-54)*3) + {38P} + (({45}-24)*3);
			}
		}
		else
		{
			if ({44}>54)
			{
				_Price = $Price + (({27}-54)*3) + {38P} + (({44}-54)*3);
			}
			else
			{
				_Price = $Price + (({27}-54)*3) + {38P};
			}
		}
	}
}
else
{
	if ({16}>74)
	{
		if({45}>24) 
		{
			if({44}>54)
			{
				_Price = $Price + (({16}-74)*3) + {38P} + (({45}-24)*3) + (({44}-54)*3);
			}
			else
			{
				_Price = $Price + (({16}-74)*3) + {38P} + (({45}-24)*3);
			}
		}
		else
		{
			if ({44}>54)
			{
				_Price = $Price + (({16}-74)*3) + {38P} + (({44}-54)*3);
			}
			else
			{
				_Price = $Price + (({16}-74)*3) + {38P};
			}
		}
	}
	else
	{
		if({45}>24) 
		{
			if({44}>54)
			{
				_Price = $Price + {38P} + (({45}-24)*3) + (({44}-54)*3);
			}
			else
			{
				_Price = $Price + {38P} + (({45}-24)*3);
			}
		}
		else
		{
			if ({44}>54)
			{
				_Price = $Price + {38P} + (({44}-54)*3);
			}
			else
			{
				_Price = $Price + {38P};
			}
		}
	}
}

to have the desired effect. But there would have to be a better way or it would be a very stupid system guaranteed to make any sane programmer skewer their eyeballs (in fact, even the original code looks worrying).

dalecosp

Weedpacket;11026691 wrote:
(certainly not enough to know why it needs a whole 'nother language when it's already using PHP).

opencart.com wrote:
CFO is a professional OpentCart extension that lets you absolutely control the way prices are calculated.
You will be able to use all fields in product-form as values, texts or prices... for easily multiply, add, subtract, or whatever maths and PHP permit you.

It is not required programming skills for simple formulas and professional programmers will get super-customized results.

Typical PHP "commercial" software marketing. "For $99, you won't need a programmer/anyone who understands PHP" ...

While it's true that $99 is a tad (just a tad, alas) cheaper than what I make in a day, the sheer fact that many folks will believe the hype above ensures that this fellow will make some amount of money from his extension.

But there would have to be a better way or it would be a very stupid system guaranteed to make any sane programmer skewer their eyeballs (in fact, even the original code looks worrying).

Amen. IIRC, Opencart's codebase itself wasn't so bad, but the finished product didn't address enough of the needs of the project we were looking at last year.

IsItFast

Yeah, I don't know if the original calculation was the proper way to do it. I hired a programmer to do that one for me. It worked so I assumed it would be easy to add another set of calculations ran together. But I actually have 3 more sets that need to be added to the calculation. Obviously that string of commands will get crazy long if I go that route.

As dalecosp pointed out the CFO extension just allows the calculation to work with Opencart. Not real sure what a more efficient way of doing this is.

Weedpacket

IsItFast wrote:
It worked so I assumed it would be easy to add another set of calculations ran together.

So would I. Like I said, I'm not clear what the significance (if any) of [font=monospace]_Price[/font] vs. [font=monospace]$Price[/font] is. Frankly, it might be enough to just replace the former with the latter in all but the last block.

IsItFast

Weedpacket;11026757 wrote:
So would I. Like I said, I'm not clear what the significance (if any) of [font=monospace]_Price[/font] vs. [font=monospace]$Price[/font] is. Frankly, it might be enough to just replace the former with the latter in all but the last block.

What I have found from the CFO extension manual:

$Price and Price, what is the difference?
They are different in CFO, so don’t make a mistake:
Use $Price to obtain the value of price you have entered in the product.
Use Price to assign the final price to the product after your calculations.