My head hurts because I am getting frustrated with this

JustCoding

I am not getting any errors with this bit of code, but that's the problem. When you get errors you can find a fix for that error,but I am not getting anything returned to the screen. I have tried breaking it down bit by bit, but I keep getting no return.

Could anyone give me an explanation why this isn't working?

<?php
include 'dbconnect.php';
$youtubeid = ($_GET['id']); 

$query = mysql_query("SELECT * FROM video WHERE youtubeid='$youtubeid' ");

$numrows = mysql_num_rows($query);

if ($numrows != 0)
//code to login
{
while ($row = mysql_fetch_assoc($query))
	{
		echo $row['youtubeid'];
	}
	//check to see if they match!
	if ($youtubeid==$dbyoutubeid){
		//Youtube Embed 
		echo '<iframe width="560" height="315" src="http://www.youtube.com/embed/'.$youtubeid.'" frameborder="0" allowfullscreen></iframe>';
			}else{
					echo 'Sorry that video does not exist in our library!';
			}
	}

?>

bradgrafelman

Where do you define $dbyoutubeid? You also might want to add an 'else' branch to your outer if() statement so that you can determine whether or not any rows match your SELECT query.

Also, user-supplied data should never be placed directly into a SQL query string, else your code will be vulnerable to SQL injection attacks and/or just plain SQL errors. See [man]security.database.sql-injection[/man] for more info.

Finally, note that the entire [man]mysql[/man] extension is outdated and deprecated; you should be using something like [man]MySQLi[/man] or [man]PDO[/man] by now instead.

JustCoding

Okay let me rewrite this code based on what you have given me and I will reply back shortly. Thanks.

JustCoding

Hey thanks for the tips. I will work on all of those things when later before I go online. Right now I am just using localhost and am just wanting to get the basic framework for this to work.

This code still returns no value. I set the variable to equal the row data. I think the problem is here:

{
while ($row = mysql_fetch_assoc($query))
	{
		$dbyoutubeid = $row['youtubeid'];
	}

<?php
include 'dbconnect.php';
$youtubeid = ($_GET['id']); 

$query = mysql_query("SELECT * FROM video WHERE youtubeid='$youtubeid' ");

$numrows = mysql_num_rows($query);

if ($numrows != 0)
//code to login
{
while ($row = mysql_fetch_assoc($query))
	{
		$dbyoutubeid = $row['youtubeid'];
	}
	//check to see if they match!
	if ($youtubeid == $dbyoutubeid){
		//Youtube Embed 
		echo '<iframe width="560" height="315" src="http://www.youtube.com/embed/'.$youtubeid.'" frameborder="0" allowfullscreen></iframe>';
			}else{
					echo 'Sorry that video does not exist in our library!';
			}
	}else{
	die(); //We will get back to this later.
	}
?>

bradgrafelman

JustCoding;11027749 wrote:
I will work on all of those things when later before I go online.

So you're going to leave the important security aspects off until later so that not only will you need to re-test things but also run the risk of forgetting an instance or two? 😉

JustCoding;11027749 wrote:
I think the problem is here:
{
while ($row = mysql_fetch_assoc($query))
	{
		$dbyoutubeid = $row['youtubeid'];
	}

It's not what I would call a "problem," but there are a few issues I'll point out with the way your current code is structured:

You never check to see if [man]mysql_query/man's return value indicates an error has occurred before you attempt to use that value as if it were a MySQL resource (i.e. the query was successfully executed). You should always verify this and handle any errors appropriately (e.g. by outputting or logging the MySQL-provided error message and gracefully aborting the rest of the SQL-related code).
You have a [man]while/man statement that does nothing but overwrite the value stored in dbyoutubeid until the last row in the result set. You then only have access to this last value. If you're only expecting at most one row to be returned from the DB, consider adding a 'LIMIT 1' clause to the query and, at the least, removing the while() loop altogether (what's the point in "looping" code if you only want it to execute once?).

If you were expecting to process more than one row then you've got bigger problems than silly-looking code.
What is the purpose of this if() statement:
```
if ($youtubeid == $dbyoutubeid){ 
```
? You already know that condition will always be true since you included it in the query's WHERE condition. MySQL isn't going to try to laugh sinisterly and sneak in a row here and there that doesn't match a given WHERE condition, y'know.
You never do anything with the data stored in the DB. Instead, you appear to merely be checking the existence of a row in the DB. Not only does this mean you shouldn't be doing a 'SELECT *' (something you shouldn't, in fact, rarely ever be doing), but you really don't even need to "fetch" any rows at all. Simply execute a 'SELECT 1' (or some other meaningless constant data) query and check the number of rows in the result set.
Finally (and possibly the crux of your current problem), your outer-most if() statement now contains an else branch that doesn't generate any output. Given the fact that the symptoms of the problem you're currently experiencing is a lack of output (which, as you point out, is compounding one problem on top of another), you might want to re-consider this.

(Sorry this post grew a bit longer than I expected; I'm in "code review" mode this morning, and I tend to be a bit verbose/long-winded/can't-shut-up-soon-enough. :p)

JustCoding

Alright thanks for all the feedback, I really do appreciate you taking time out of your morning for this. I'll try to rewrite the code using the information you provided. I'm still very new at this.

JustCoding

I rewrote the code. Not sure if this is exactly how you told me to do it, but this worked for me.

<?php
include 'dbconnect.php';
$youtubeid = ($_GET['id']); 

//Setting Youtube Video From Database
$result = mysql_query("SELECT id,videorep,youtubeid FROM video WHERE youtubeid='$youtubeid' ");
if (!$result) {
    echo 'Sorry this video does not exist in our library!';
    exit;
}else{

while ($row = mysql_fetch_row($result)){
$dbvideoid = $row['0']; //Get Video ID
$dbvideorep = $row['1']; //Get Video REP
$dbyoutubeid = $row['2']; //Get Video Youtube ID

}
echo '<iframe width="560" height="315" src="http://www.youtube.com/embed/'.dbyoutubeid.'" frameborder="0" allowfullscreen></iframe>';
}

?>

maxxd

First and foremost, to reiterate bradgrafelman's earlier advice, update to PDO or MySQLi. It's going to be easier in the long-run. Now, as for the code you've written - you're not checking to make sure there actually are any results from the database. I believe mysql_query will return an empty array (not boolean false) if the submitted query string parses correctly but returns no results from the dataset. Try checking the num_rows and see what that gives you. Moreover, and again as bradgrafelman pointed out above, the while loop is going to overwrite the value of each of the three variables so if there is a returned data set, you're never going to get anything but the last record in it.