Function not giving true result.

[JustCoding]

Please help me someone. I have a function that does this:

function checkYoutubeId($youtubeid) {  

if (!$data = @file_get_contents("http://gdata.youtube.com/feeds/api/videos/".$youtubeid)) return false;
if ($data == "Video not found") return false;
return true;
}

When I try to use function here, I get this error:

Notice: Undefined offset: 1 in C:\xampp\htdocs\functions\common.php on line 28

However if i change $link = "http://www.youtube.com/watch?v=yZcfRrqUZI8"; in the code below it works. It only shows this error when I try adding the $_POST['link']; and the ISSET.

include 'functions/common.php';
include 'dbconnect.php';

 if(isset($_POST['submit']) )
 {
$link = $_POST['link'];

//Start Youtube Video Submit Process

$youtubeid = (youtube_id_from_url($link)); //Get Youtube ID from URL

if (checkYoutubeId($youtubeid) == true){

if (checkYoutubeOnline($youtubeid) == true) {
	echo 'it worked'; //Just testing to see if it worked.
}else{
	echo 'Sorry that Youtube video does not exist! Please check that your link is correct and that the video is still online.';
}
}
}else{

}

[JustCoding]

I think the problem is that the

}else{
echo 'Sorry that Youtube video does not exist! Please check that your link is correct and that the video is still online.';
}

is not working correctly. Instead of displaying the echo, it gives me an error Notice: Undefined offset: 1 in C:\xampp\htdocs\functions\common.php on line 28

[traq]

JustCoding;11027759 wrote:

Notice: Undefined offset: 1 in C:\xampp\htdocs\functions\common.php on line 28

The problem is not in this code at all. Read the notice: the problem is on line 28 in your [font=monospace]C:\xampp\htdocs\functions\common.php[/font] file.

[JustCoding]

After doing some looking into this I understand what is causing the problem, but I have tried many things and can not get a fix.

I understand the problem, but I do not know how to fix this. Everything works with my code here as long as preg match finds a match. If it does not find a match it gives me this notice. How would I fix this?

I am using preg_match function here:

function youtube_id_from_url($link) {
    $pattern = 
        '%^# Match any youtube URL
        (?:https?://)?  # Optional scheme. Either http or https
        (?:www\.)?      # Optional www subdomain
        (?:             # Group host alternatives
          youtu\.be/    # Either youtu.be,
        | youtube\.com  # or youtube.com
          (?:           # Group path alternatives
            /embed/     # Either /embed/
          | /v/         # or /v/
          | /watch\?v=  # or /watch\?v=
          )             # End path alternatives.
        )               # End host alternatives.
        ([\w-]{10,12})  # Allow 10-12 for 11 char youtube id.
        $%x'
        ;
    $result = preg_match($pattern, $link, $matches);
    if (false !== $result) {
        return $matches[1];
    }else{
    return false;
}
}

and the main php code is

<?php
include 'functions/common.php';
include 'dbconnect.php';


$link = $_POST['submit'];

//Start Youtube Video Submit Process
$youtubeid = (youtube_id_from_url($link)); //Get Youtube ID from URL

if (checkYoutubeOnline($youtubeid) == 1){

   echo "The Youtube video seems to work fine The ID is ".$youtubeid

}else{
	echo 'Sorry that Youtube video does not exist! Please check that your link is correct and that the video is still online.';
}



?>

<form action="submit_video.php" method="post">
   <p>Link to video: <input type="text" name="link" /></p>
   <input type="submit" name="submit" value="Submit" />
</form>

[Weedpacket]

    $result = preg_match($pattern, $link, $matches);
    if (false !== $result) {
        return $matches[1];
    }else{
    return false;

Go back to the manual and see what it says about what [man]preg_match[/man] returns. What does it return if it does not find a match?

[JustCoding]

I see what I did wrong and I rewrote the code. Everything is working except for when no matches are found. It returns a value of 0, but it also shows a notice on the screen now if no matches are found : Notice: Undefined index: host in C:\xampp\htdocs\functions\common.php on line 14

Everything is working, but if a user types something that doesn't get matched I do not want this notice to be displayed.

With the new code, how can I remove the notice?

New function :

function getYoutubeId($ytURL) 
    {
        $urlData = parse_url($ytURL);
        //echo '<br>'.$urlData["host"].'<br>';
        if($urlData["host"] == 'www.youtube.com') // Check for valid youtube url
        {
            $ytvIDlen = 11; // This is the length of YouTube's video IDs

        // The ID string starts after "v=", which is usually right after 
        // "youtube.com/watch?" in the URL
        $idStarts = strpos($ytURL, "?v=");

        // In case the "v=" is NOT right after the "?" (not likely, but I like to keep my 
        // bases covered), it will be after an "&":
        if($idStarts === FALSE)
            $idStarts = strpos($ytURL, "&v=");
        // If still FALSE, URL doesn't have a vid ID
        if($idStarts === FALSE)
            die("YouTube video ID not found. Please double-check your URL.");

        // Offset the start location to match the beginning of the ID string
        $idStarts +=3;

        // Get the ID string and return it
        $ytvID = substr($ytURL, $idStarts, $ytvIDlen);

        return $ytvID;
    }
    else
    {
        return 0;
    }

} 

New php code :

<?php
include 'functions/common.php';
include 'dbconnect.php';

 //if(isset($_POST['submit']) )
 //{
$ytURL = "33";
$youtubeid = getYoutubeId($ytURL);

echo $youtubeid;
?>

[JustCoding]

Yes I know I commented out some lines in the code provided above. I did this for testing purposes.

[bradgrafelman]

Inside your function, use something like [man]empty/man or [man]isset/man to see if $urlData['host'] is empty or even exists (respectively) before you attempt to use it.

EDIT: Speaking of your function, note that using [man]parse_str/man would probably be much simpler:

$url = 'http://www.myexample.com/foo/bar/?baz=hello&v=1234abc&foobar=false';
$urlData = parse_url( $url );
parse_str( $urlData[ 'query' ], $queryParams );
echo "v is: " . ( isset( $queryParams[ 'v' ] ) ? $queryParams[ 'v' ] : 'undefined' ) . "\n";