Help with where to place a single line of code

[chrisj]

I'm using a php script and added/modded (with help) this single line to the Session file:

$member_credits = get_member_credits($user_id);

As seen here:

<?php
validate_user($_COOKIE['user']);

// set user vars for passing around each php page
$user_id	= $_SESSION['user_id'];
$user_name	= $_SESSION['user_name'];
$user_group = $_SESSION['user_group'];

//get some basic user things like email for logged in members
if ( $user_id != '' ) {

$loggedin 			= 1;
$login_out 			= $config['logout_text'];
$login_out_link 		= 'logout.php';
$register_menu 		= $config['fav_menu'];
$register_menu_link	= 'myfavorites.php';
require_once('functions.inc.php');
$member_credits = get_member_credits($user_id);
//email inbox
$sql			= "SELECT indexer FROM messages WHERE to_id = '$user_id' AND email_read = 'no'";
$number_of_emails = @mysql_num_rows(mysql_query($sql));
$show_email_count = 1;

if ( $number_of_emails == '' ) $number_of_emails = 0;

//Friend Invites
$sql = "SELECT * FROM friends WHERE friends_id = '$user_id' AND invitation_status ='pending'";
$number_of_invites = @mysql_num_rows(mysql_query($sql));
$show_invites_count = 1;

//show My favs link
$show_my_favs 	= 1;

//show My account link
$show_my_account 	= 1;

//do not show signup link
$show_register 	= '';

} else {

$show_register 	= 1;
}
?>

I've upgraded to version 2 of the script and this version has a new Session file. Can you please tell me where the appropriate place to add this line:

$member_credits = get_member_credits($user_id);

to the new Session file? I'd be glad to provide the new Sessions file code here, if you're interested in helping me.
Thanks

[traq]

Have you tried anything yet? Did it work? What went wrong?

The obvious place to try would be right after you require the [font=monospace]function.inc.php[/font] file - that's where you have it now, and I assume from your comments that it "works" there.

Beyond that, there's not much more we could offer - we don't know what your script does, what your function does, or what you're trying to accomplish by adding it. It is not possible to help or offer useful advice without any context. You need to explain some of these things.

[chrisj]

Thanks for your reply.
Below is the new Session file, and I placed it after: if ( $user_id != '' )

I don't know if this invalidates anything, and I don't know where "right after you require the function.inc.php file"

Any additional help as to where in this file might be more appropriate, would be appreciated. Thanks

<?php

validate_user($_COOKIE['user']);

// set user vars for passing around each php page
$user_id	= $_SESSION['user_id'];
$user_name	= $_SESSION['user_name'];
$user_group = $_SESSION['user_group'];

$sql			= "SELECT user_id, user_name, account_status FROM member_profile WHERE user_id = '$user_id'";
$query 		= @mysql_query($sql);
$outcome		= @mysql_fetch_array($query);
$result		= $outcome['account_status'];
$result_user	= $outcome['user_name'];

if ($result_user == '') {

$user_id				= '';
$user_name				= '';
$_SESSION['user_id'] 		= NULL;
$_SESSION['user_name'] 		= NULL;
$_SESSION['user_group'] 	= NULL;
$_SESSION['admin_logged']	= NULL;

@session_start();
@session_destroy();

foreach ( $_COOKIE as $key => $value ) {
 		$logout = '';
		setcookie($key, $logout);
	}
	foreach ($_SESSION as $key => $value) {
	$_SESSION[$key] 	= NULL;
	unset($_SESSION[$key]);
}

}

if ( $result == 'suspended' ) {

$user_id				= '';
$user_name				= '';
$_SESSION['user_id'] 		= NULL;
$_SESSION['user_name'] 		= NULL;
$_SESSION['user_group'] 	= NULL;
$_SESSION['admin_logged']	= NULL;

@session_start();
@session_destroy();

foreach ( $_COOKIE as $key => $value ) {
 		$logout = '';
		setcookie($key, $logout);
	}
	foreach ($_SESSION as $key => $value) {
	$_SESSION[$key] 	= NULL;
	unset($_SESSION[$key]);
}

//account suspended
  $notification_type	= $config['notification_error'];
  $error_message 		= $config['account_suspended'];
  $blk_notification 	= 1;
  $template 			= "themes/$user_theme/templates/main_1.htm";
  $inner_template1		= "themes/$user_theme/templates/inner_notification.htm";
  $TBS 				= new clsTinyButStrong;
  $TBS->NoErr 		= true;
  $TBS->LoadTemplate("$template");
  $TBS->Render 		= TBS_OUTPUT;
  $TBS->Show();

@mysql_close();
  die();
}


//get some basic user things like email for logged in members
if ( $user_id != '' ) {

if ( defined('SMF_INSTALLED') ) {
	$loggedin 			= 1;
	$login_out 			= $config['logout_text'];
	$login_out_link 		= 'logout.php';
	$register_menu		= $config['fav_menu'];
} else {
	$loggedin 			= 1;
	$login_out 			= $config['logout_text'];
	$login_out_link 		= 'logout.php';
	$register_menu		= $config['fav_menu'];
	$member_credits = get_member_credits($user_id);
}


//email inbox
$sql				= "SELECT indexer FROM messages WHERE to_id = '$user_id' AND email_read = 'no'";
$number_of_emails 	= @mysql_num_rows(mysql_query($sql));
$show_email_count 	= 1;

//Friend Invites
$sql 				= "SELECT * FROM friends WHERE friends_id = '$user_id' AND invitation_status ='pending'";
$number_of_invites	= @mysql_num_rows(mysql_query($sql));
$show_invites_count 	= 1;

//show My favs link
$show_my_favs 		= 1;

//show My account link
$show_my_account 		= 1;

//do not show signup link
$show_register 		= '';

} else {

$show_register 		= 1;
}

?>

[traq]

chrisj;11029475 wrote:

Thanks for your reply.
Below is the new Session file, and I placed it after: if ( $user_id != '' )

...and did that work? did it cause problems? did it have any effect at all?

chrisj;11029475 wrote:

and I don't know where "right after you require the function.inc.php file"

Doesn't seem to happen in this new version of the script.

chrisj;11029475 wrote:

Any additional help as to where in this file might be more appropriate, would be appreciated. Thanks

As I said, there's nothing more I can offer without more of an explanation. Believe it or not, you know more about this than I do. I don't know what your script is supposed to do, what your function is supposed to do, how adding your line of code is supposed to modify the script or its results - nothing.

You need to explain these things.

You might also ask for help from whoever wrote the script.

[chrisj]

Thanks for your time, it's now been resolved.

[chrisj]

Actually, It's not resolved. My mistake. Any help will be appreciated.

[traq]

As I said before, you need to explain things.

So far, you have ignored all questions asked of you. If you take the time to answer my questions, I would be happy to take the time to help you.

[chrisj]

Thanks for your reply. The member_credits line is part of a script modification that provides web site members with credits to use on the site. When I've tried to place that line in the script, by guessing, where it might go, I get a page error. I thought someone who knows more about php lines that begin with $ could make a more educated guess

[traq]

Guessing, "educated" or not, is not a good way to approach coding tasks. It is a waste of time.

We need to know how that function is supposed to work in order to decide where it needs to be placed in your code.

Unfortunately, we don't have any clues from the existing code (your first post) - in fact, after you assign the result of the function to the variable [font=monospace]$member_credits[/font], you don't use it again.

Start with this:
1) What script are you "modifying"? Is it a CMS? Is it a collection of scripts you (or someone) have assembled to get what you want?

2) What does this function do? I know you've said it "provides members with credits to use on the site" - but that's too broad. Find the code that defines this function and post it (the definition will look something like this:

function get_member_credits( $userid ){
    // some code in here
    // more code
    // etc.
}

3) Wherever you are placing this line in your code now, what goes wrong? Do you get an error message? Is something on the page missing, or incorrect? Does it have any effect on the output at all?