PHP 5.3 help

phpnewbies

I been trying to make my site work on PHP 5.3. I had a bunch of depreciated stuff and have got them fixed but my problem I have now is a csv importer I have that updates the games player stats, game stats and team stats.

Every thing looks fine even when I push the submit button but after the pop up window closes it inserts a's for the scores and doesnt update anything else. When i switch back to PHP 5.2 the script works fine.

any ideas????

I can post the script but it is over 2000 lines just thought someone might know why its submiting a's instead of numerical value

Weedpacket

At a wild guess (not having seen any code) you're using something that expects strings and you're giving it an array.

Incidentally, PHP 5.3 is reaching its end of life and will no longer be supported in a year; the current versions are 5.4 and 5.5.

phpnewbies

I saw the php versions but my shared hosting only has php 4, php 5.2 and php 5.3 listed...
funny thing was that this script was working before they switched servers on me and now it doesnt work unless i goto php 5.2 which i dont wanna do..

I did find out in the script that its only the .csv part not uploading. the part where I can edit stats manually works.
here is some of my code for you to see

<?

if (!function_exists('str_getcsv')) {

function str_getcsv($input, $delimiter = ',', $enclosure = '"', $escape = null,
    $eol = null)
{
    $temp = fopen("php://memory", "rw");
    fwrite($temp, $input);
    fseek($temp, 0);
    $r = array();
    while (($data = fgetcsv($temp, 4096, $delimiter, $enclosure)) !== false) {
        $r[] = $data;
    }
    fclose($temp);
    return $r;
}
}


function fix($array)
{
    $newarray = array();
    for ($i = 1; $i != count($array); $i++) {
        $newarray[] = $array[$i];
    }

return $newarray;
}

function str_compare($str1, $str2)
{
    $count = 0;

$str1 = preg_replace("[^a-z]", ' ', strtolower($str1));
while (strstr($str1, '  ')) {
    $str1 = str_replace('  ', ' ', $str1);
}
$str1 = explode(' ', $str1);

$str2 = preg_replace("[^a-z]", ' ', strtolower($str2));
while (strstr($str2, '  ')) {
    $str2 = str_replace('  ', ' ', $str2);
}
$str2 = explode(' ', $str2);

if (count($str1) < count($str2)) {
    $tmp = $str1;
    $str1 = $str2;
    $str2 = $tmp;
    unset($tmp);
}

for ($i = 0; $i < count($str1); $i++) {
    if (in_array($str1[$i], $str2)) {
        $count++;
    }
}

return $count / count($str2) * 100;
}

$u = isset($_POST['u']) ? $_POST['u'] : $_GET['u'];

$max_scoring_summary = 20;
$max_penalty_summary = 25;


//SECURITY CHECK - SEE IF USERNAME EXISTS
if ($u) {

include ('../../../config.php');

$open = mysql_connect($hostname, $user, $password);
mysql_select_db("$db", $open);

$teams = mysql_query("SELECT * FROM teams WHERE username = '$u'");
$timeloggedin = mysql_result($teams, 0, "logtime");
$loggedin = mysql_result($teams, 0, "loggedin");
$sessionid = mysql_result($teams, 0, "sessionid");

$leagueinfo = mysql_query("SELECT timelength FROM leagueinfo");
$logtime = mysql_result($leagueinfo, 0, "timelength");

$sessid = isset($_POST['sessid']) ? $_POST['sessid'] : $_GET['sessid'];

if ($loggedin == "1" && $sessid == $sessionid) {

    $cktime = $timeloggedin + ($logtime * 60);
    $ctime = date("U");

    if ($ctime < $cktime) {

        $tsql = "UPDATE teams SET logtime = '" . date("U") . "' WHERE username = '$u'";
        $tdone = mysql_query($tsql);
        if (!$tdone) {
            echo mysql_errno() . ": " . mysql_error() . "<br>";
        }

?>

<html>
<head>
<title>Edit Game</title>

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link rel="stylesheet" href="../../../includes/leaguestyle.css">

<style type="text/css">
<!--
a {  color: #990000; text-decoration: none}
a:hover {  color: #990000; text-decoration: underline}
-->
</style>

<script language="JavaScript" src="../../../date-picker.js"></script>

</head>
<body bgcolor="#FFFFFF" leftmargin="10" topmargin="10" marginwidth="0" marginheight="0">

<?

        //SEE IF INTER-DIVISION PLAY IS ALLOWED AND GET USER PERMISSIONS
        $result_edit = mysql_query("SELECT edit FROM leagueinfo");
        $sedit = mysql_result($result_edit, 0, "edit");
        if ($u == 'admin' && $sedit == 0) {
            $sedit = 1;
        } elseif ($u != 'admin' && $sedit == 0) {
            $sedit = 0;
        } else {
            $sedit = 1;
        }

        $edit = $_POST['edit'];

        if ($edit == "yes") {

            $thisdiv = $_POST['thisdiv'];
            $selectteam = $_POST['selectteam'];
            $season = $_POST['season'];
            $gameid = $_POST['gameid'];
            $date = $_POST['date'];
            $time = $_POST['time'];
            $location = $_POST['location'];
            $arena = $_POST['arena'];
            $team1_score = $_POST['team1_score'];
            $team2_score = $_POST['team2_score'];
            $game_ot = $_POST['game_ot'];
            $gametype = $_POST['gametype'];
            $league = $_POST['league'];
            $team1_ppgf = $_POST['team1_ppgf'];
            $team1_ppo = $_POST['team1_ppo'];
            $team1_pkga = $_POST['team1_pkga'];
            $team1_pka = $_POST['team1_pka'];
            $team2_ppgf = $_POST['team2_ppgf'];
            $team2_ppo = $_POST['team2_ppo'];
            $team2_pkga = $_POST['team2_pkga'];
            $team2_pka = $_POST['team2_pka'];
            $goals = $_POST['goals'];
            $assists = $_POST['assists'];
            $goalsa = $_POST['goalsa'];
            $shotsa = $_POST['shotsa'];
            $minutes = $_POST['minutes'];
            $xtra1 = $_POST['xtra1'];
            $xtra2 = $_POST['xtra2'];
            $xtra3 = $_POST['xtra3'];
            $xtra4 = $_POST['xtra4'];
            $xtra5 = $_POST['xtra5'];
            $gminutes = $_POST['gminutes'];
            $gseconds = $_POST['gseconds'];
            $played = $_POST['played'];

            $sstime = $_POST['sstime'];
            $ssperiod = $_POST['ssperiod'];
            $ssplayer = $_POST['ssplayer'];
            $sstype = $_POST['sstype'];
            $ssassist1 = $_POST['ssassist1'];
            $ssassist2 = $_POST['ssassist2'];
            $sspic = $_POST['sspic'];

            $pstime = $_POST['pstime'];
            $psperiod = $_POST['psperiod'];
            $psplayer = $_POST['psplayer'];
            $pstype = $_POST['pstype'];
            $psminutes = $_POST['psminutes'];
            $pspic = $_POST['pspic'];

            mysql_query("DELETE FROM goalinfo WHERE gameid=$gameid");
            mysql_query("DELETE FROM penaltyinfo WHERE gameid=$gameid");
            for ($x = 0; $x < $max_scoring_summary; $x++) {





            //GET THE USER'S TEAM
            $userteam = $selectteam;

            if ($team1_score1) {
                $team1_score = $team1_score1 . "," . $team1_score2 . "," . $team1_score3;
                $team2_score = $team2_score1 . "," . $team2_score2 . "," . $team2_score3;
            }


            if (($location == "" || $arena == "" || $time == "" || $date == "") && $sedit ==
                1) {
                echo "
		<p class=warning align=center>NO NEW TEAM ADDED:<br>YOU DID NOT COMPLETE THE FORM.</p>\n\r
		<p class=header align=center>GO <a href='javascript:history.go(-1)'><u>BACK</u></a> AND TRY AGAIN.</p>";
            } else {
                $today = date("Y-m-d");
                if (($today < $newdate) || $newteam1_score == "" || $newteam2_score == "") {
                    $newteam1_score = "---";
                    $newteam2_score = "---";
                }

                //EDIT INFORMATION
                if ($sedit == 0 && $u != "admin") {
                    $sql = "UPDATE schedule_scores SET team1_score = '$team1_score', team2_score = '$team2_score' WHERE id = '$gameid'";
                } else {

phpnewbies

                        //UPDATE CURRENT STATS
                        foreach ($goals as $key => $value) {

                        $result = mysql_query("SELECT id FROM player_stats WHERE playerid = '$key' AND game_id = '$gameid'");
                        $total = mysql_numrows($result);

                        $test = $goals[$key] . $assists[$key] . $goalsa[$key] . $shotsa[$key] . $minutes[$key] .
                            $xtra1[$key] . $xtra2[$key] . $xtra3[$key] . $xtra4[$key] . $xtra5[$key] . $gminutes[$key] .
                            $gseconds[$key] . $played[$key];

                        if ($total > 0) {
                            if ($test == "0000000000000") {
                                $sql3 = mysql_query("DELETE FROM player_stats WHERE playerid = '$key' AND game_id ='$gameid'");
                            } else {
                                $sql2 = "UPDATE player_stats SET ";
                                $sql2 .= "goals = '$goals[$key]', assists = '$assists[$key]', ";
                                $sql2 .= "goalsa = '$goalsa[$key]', shotsa = '$shotsa[$key]', ";
                                $sql2 .= "minutes = '$minutes[$key]', xtra1 = '$xtra1[$key]', xtra2 = '$xtra2[$key]', xtra3 = '$xtra3[$key]', xtra4 = '$xtra4[$key]', xtra5 = '$xtra5[$key]', gminutes = '$gminutes[$key]', gseconds = '$gseconds[$key]', ";
                                $sql2 .= "played = '$played[$key]', div_id = '$thisdiv', leagueid = '$league' ";
                                $sql2 .= "WHERE game_id = '$gameid' ";
                                $sql2 .= "AND playerid = '$key' ";
                                $done2 = mysql_query($sql2);
                                if (!$done2) {
                                    echo mysql_errno() . ": " . mysql_error() . "<br>";
                                }

                            }
                        } else {
                            if ($test != "0000000000000") {

                                //check to see if userteam is correct for home or visitor team
                                $ut_check = mysql_query("SELECT teamid FROM players WHERE id = '" . $key . "'");
                                $ut_name = mysql_result($ut_check, 0, "teamid");
                                if ($ut_name == $userteam) {
                                    $ut_team = '0';
                                } else {
                                    $userteam = $ut_name;
                                }

                                $sql2 = "INSERT INTO player_stats VALUES ";
                                $sql2 .= "('NULL','$key','$goals[$key]','$assists[$key]','$goalsa[$key]',";
                                $sql2 .= "'$shotsa[$key]','$minutes[$key]','$xtra1[$key]','$xtra2[$key]','$xtra3[$key]','$xtra4[$key]','$xtra5[$key]','$gminutes[$key]','$played[$key]',";
                                $sql2 .= "'$gameid','$userteam','$thisdiv','$season','$gseconds[$key]','$league')";

                                $done2 = mysql_query($sql2);
                                if (!$done2) {
                                    echo mysql_errno() . ": " . mysql_error() . "<br>";
                                }


                            }
                        }
                    }

phpnewbies

i am still at a loss with this... i looked at weedpackets suggestion where it thinks its looking for a string and returning an array...

with the csv files where i gather them up i have this for getting the player stats from the player stats csv file

$playerstats_file = file_get_contents($_FILES['playerstats']['tmp_name']);

if not mistaken i believe the file_get_contents is supposed to read the contents into a string????

does this code below look right

if (!function_exists('str_getcsv')) {

function str_getcsv($input, $delimiter = ',', $enclosure = '"', $escape = null,
    $eol = null)
{
    $temp = fopen("php://memory", "rw");
    fwrite($temp, $input);
    fseek($temp, 0);
    $r = array();
    while (($data = fgetcsv($temp, 4096, $delimiter, $enclosure)) !== false) {
        $r[] = $data;
    }
    fclose($temp);
    return $r;
}
}


function fix($array)
{
    $newarray = array();
    for ($i = 1; $i != count($array); $i++) {
        $newarray[] = $array[$i];
    }

return $newarray;
}

function str_compare($str1, $str2)
{
    $count = 0;

$str1 = preg_replace("[^a-z]", ' ', strtolower($str1));
while (strstr($str1, '  ')) {
    $str1 = str_replace('  ', ' ', $str1);
}
$str1 = explode(' ', $str1);

$str2 = preg_replace("[^a-z]", ' ', strtolower($str2));
while (strstr($str2, '  ')) {
    $str2 = str_replace('  ', ' ', $str2);
}
$str2 = explode(' ', $str2);

if (count($str1) < count($str2)) {
    $tmp = $str1;
    $str1 = $str2;
    $str2 = $tmp;
    unset($tmp);
}

for ($i = 0; $i < count($str1); $i++) {
    if (in_array($str1[$i], $str2)) {
        $count++;
    }
}

return $count / count($str2) * 100;
}

Weedpacket

 $playerstats_file = file_get_contents($_FILES['playerstats']['tmp_name']);

That line isn't anywhere in the code you posted.

You do have

        while (($data = fgetcsv($temp, 4096, $delimiter, $enclosure)) !== false) {

But nowhere in the code you've posted do you call the function that contains it.

Here's a standard debugging technique. Try to reduce the problem to the smallest complete piece of code that actually shows the problem Take out all the irrelevant stuff and leave in what's relevant (this will require work on your part). Posting random blocks of code and asking "is the problem here?" is not an effective [thread=10240608]debugging technique[/thread].

phpnewbies

as for the first piece of code I didnt put all code in as its a big file and must have missed that part. I started searching up each function and when you said looks like its looking for a string i thought id post that to see if that is what that code was for.

where i posted the code in my previous thread i wasnt asking if the problem was there i was asking someone to look at to see if it looked correct. I had changed some stuff and wanted to make sure i didnt mess it up.

Also this is hard to debug as I am not getting any errors or stuff entered into my error logs. I have been removing code already to test different stuff, but i am thinking the problem is within the code i posted in my last post.

that part of the code where you say this isnt anywhere in the code you posted. here is the part that goes with it that was further down in the script.

                  if ($_FILES['teamstats']['error'] == UPLOAD_ERR_OK && is_uploaded_file($_FILES['teamstats']['tmp_name'])) {
                        $teamstats_file = file_get_contents($_FILES['teamstats']['tmp_name']);
                    } else {
                        $html .= "<b> YOU MUST SELECT A TEAM STATISTICS FILE TO UPLOAD! </b><br/>";
                    }

                if ($_FILES['gamestats']['error'] == UPLOAD_ERR_OK && is_uploaded_file($_FILES['gamestats']['tmp_name'])) {
                    $gamestats_file = file_get_contents($_FILES['gamestats']['tmp_name']);
                } else {
                    $html .= "<b> YOU MUST SELECT A GAME STATISTICS FILE TO UPLOAD! </b><br/>";
                }

                if ($_FILES['playerstats']['error'] == UPLOAD_ERR_OK && is_uploaded_file($_FILES['playerstats']['tmp_name'])) {
                    $playerstats_file = file_get_contents($_FILES['playerstats']['tmp_name']);
                } else {
                    $html .= "<b> YOU MUST SELECT A PLAYER STATISTICS FILE TO UPLOAD! </b><br/>";
                }

                if (isset($teamstats_file) && isset($gamestats_file) && isset($playerstats_file)) {

                    $teamstats_csv = fix(str_getcsv($teamstats_file));
                    $gamestats_csv = fix(str_getcsv($gamestats_file));
                    $playerstats_csv = fix(str_getcsv($playerstats_file));

                    $hometeam = $teamstats_csv[0];
                    $awayteam = $teamstats_csv[1];

                    $hometeam_query = mysql_query("SELECT * FROM teams WHERE id = $homeid");
                    $hometeam_data = mysql_fetch_assoc($hometeam_query);

                    $awayteam_query = mysql_query("SELECT * FROM teams WHERE id = $awayid");
                    $awayteam_data = mysql_fetch_assoc($awayteam_query);

                    $data = mysql_fetch_assoc(mysql_query("SELECT DISTINCT(team1pic) FROM `schedule_scores` WHERE team1 = '" .
                        $homeid . "' AND team1pic <> '' ORDER BY id DESC"));

                    if (!empty($data['team1pic']))
                        $homepic = $data['team1pic'];

                    $data = mysql_fetch_assoc(mysql_query("SELECT DISTINCT(team1pic) FROM `schedule_scores` WHERE team1 = '" .
                        $awayid . "' AND team1pic <> '' ORDER BY id DESC"));

                    if (!empty($data['team1pic']))
                        $awaypic = $data['team1pic'];

                    $open_season = mysql_result(mysql_query("SELECT * FROM seasons WHERE status = '1'"),
                        0, "id");

                    $hometeampp = explode('/', $hometeam[16]);
                    $awayteampp = explode('/', $awayteam[16]);
                    $insert = array("date" => $date, "time" => $time, "location" => $location,
                        "arena" => $arena, "team1" => $homeid, "team2" => $awayid, "team1_div" => $hometeam_data['division'],
                        "team2_div" => $awayteam_data['division'], "team1_score" => $hometeam[2],
                        "team2_score" => $awayteam[2], "team1pic" => $homepic, "team2pic" => $awaypic,
                        "season" => $open_season, "ot_game" => $otgame, "gametype" => $gametype,
                        "league" => $league, "team1_ppgf" => $hometeampp[0], "team1_ppo" => $hometeampp[1],
                        "team1_pkga" => $awayteampp[0], "team1_pka" => $awayteampp[1], "team2_ppgf" => $awayteampp[0],
                        "team2_ppo" => $awayteampp[1], "team2_pkga" => $hometeampp[0], "team2_pka" => $hometeampp[1]);


                    foreach ($insert as $key => $value) {
                        $value = mysql_real_escape_string($value);
                        $value = "'$value'";
                        $updates[] = "$key = $value";
                    }

will take your advice and remove parts and debug that way

johanafm

phpnewbies;11032743 wrote:
Also this is hard to debug as I am not getting any errors or stuff entered into my error logs.

Have you checked your settings? If error_level is not properly set or if you have not specified a writeable file for logging errors and/or turned on display errors (usually on in development environment, but should always be off in production) you will not see error messages.

I still believe that you should do what Weedpacket tells you to, but seeing error messages will probably speed up that process.

phpnewbies

I have been running display errors since i moved to this new server and using php 5.3

when i switched i had many depreciated functions and warnings and i have taken care of 97% of them so far. trying to make it so the site has no warnings or errors when it is turned on so when my host does provide php 5.4 or higher i will know what issues are new

My host says i have the error logging on as well cause i contacted them to make sure there was no issues there.

I am currently doing what weedpacket said to do its just going slow as I have a busy week this week until the weekend.

I think i will get it soon.