PHP Form using SMTP

[jasons]

Needing some help getting my form to work. I need to use SMTP now and having trouble getting everything to work. After my form is submitted the confirmation is sent but the form info that needs to go out to the $ToAddress does not get received. Additionally I would like the $ToAddress to go out to 2 emails not one. Any help would be appricated!

<?php
require_once "Mail.php";

$from = "[e-mail]";
$to = $_POST['Email'];
$subject = "Test email using PHP SMTP\r\n\r\n";
$body = "This is a test email message";

$host = "mail.emailserver.com";
$username = "[e-mail]";
$password = "password";

$headers = array ('From' => $from,
  'To' => $to,
  'Subject' => $subject);
$smtp = Mail::factory('smtp',
  array ('host' => $host,
    'auth' => true,
    'username' => $username,
    'password' => $password));

$mail = $smtp->send($to, $headers, $body);

if (PEAR::isError($mail)) {
  echo("<p>" . $mail->getMessage() . "</p>");
} else {
  echo("<p>Message successfully sent!</p>");
}

$ToAddress = "[e-mail]";

$message  = "Mailing List Submission\n";
$message .= "-------------------------------------------\n";
foreach ($_POST as $key => $value){$message .= "$key: $value\n";}
$message .= "-------------------------------------------\n";

mail("$ToAddress",
   "Contact Us Form",
    "\r\n".$message,
    "From: $to\r\nCc:\r\nBcc:\r\n\r\n");
?>

[sneakyimp]

Firstly, please use the code formatting capabilities of this forum -- it makes you code much easier to read and understand.

Second, why do you use pear mail for the first email and then the [man]mail[/man] function for the second email?

Third, you didn't even bother to check if the mail() call you made actually worked or not.

Fourth, your script could easily be exploited by someone else to use mail header injection if you choose to use the mail function.

Fifth, you don't validate the $to email to make sure it's a valid address (check out [man]filter_var[/man])

If I were you, I would copy the code that works to send the first email and modify it to send the other message.

[jasons]

Thanks for the tips sneakyimp. Thats why I went to the Newbies forum. I am pretty raw at this. Here is the code that works, but it does not send me anything letting me know that someone has filled out the form. It just sends the user a confirmation that it was received. Except I never receive it. What would I need to add to where I can receive the responses from the form? Before I just used the mail function but I need to use pear mail now.

<?php
require_once "Mail.php";

$from = "Web Master <[e-mail]>";
$to = $_POST['Email'];
$subject = "Test email using PHP SMTP\r\n\r\n";
$body = "This is a test email message";

$host = "mail.emailsrvr.com";
$username = "[e-mail]";
$password = "yourPassword";

$headers = array ('From' => $from,
  'To' => $to,
  'Subject' => $subject);
$smtp = Mail::factory('smtp',
  array ('host' => $host,
    'auth' => true,
    'username' => $username,
    'password' => $password));

$mail = $smtp->send($to, $headers, $body);

if (PEAR::isError($mail)) {
  echo("<p>" . $mail->getMessage() . "</p>");
} else {
  echo("<p>Message successfully sent!</p>");
}
?>

[bradgrafelman]

jasons;11034107 wrote:

Before I just used the mail function but I need to use pear mail now.

Right, so just do the same thing you're doing for the e-mail that is sent to the user (PEAR::Mail) rather than reverting back to using the built-in mail() function as you were doing above for the second e-mail.

[jasons]

bradgrafelman;11034109 wrote:

Right, so just do the same thing you're doing for the e-mail that is sent to the user (PEAR::Mail) rather than reverting back to using the built-in mail() function as you were doing above for the second e-mail.

Brad - That's the part I am having trouble figuring out. How can I go about doing that? Could someone show me an example? I also need to CC the results as well to another person other then my email address, how can that be done?

[sneakyimp]

You need to isolate the code that is sending the email to the user (which works) and get rid of all the stuff that sends email to you (which doesn't work). It looks like you have done this already. I would take the resulting isolated code and make it into its own function and call it something like my_mail_function and then you can call that function every time you want to send mail.

EDIT: check out the PHP docs on how to write user-defined functions: http://us2.php.net/manual/en/functions.user-defined.php