read bit value into checkbox in PHP

jrahma

Hi,

I am having difficulties reading the bit value from MySQL and showing it in a checkbox in PHP.

The value is not showing and it's always unchecked!

This is what I am using:

$mysql_command = "CALL sp_get_member_personal_information(:param_member_guid)";

$mysql_query = $mysql_connection->prepare($mysql_command);
$mysql_query->bindParam(':param_member_guid', $_SESSION["member_guid"], PDO::PARAM_STR);

$mysql_query->execute();

$mysql_row_count = $mysql_query->rowCount();

if ($mysql_row_count <= 0) { exit(header("Location: home")); }

while ($mysql_row = $mysql_query->fetch())
{
    $is_private = (bool)$mysql_row["is_private"];
    $hide_contact_details = (bool)$mysql_row["hide_contact_details"];
}

and then:

<input type="checkbox" id="chkPrivateProfile" name="chkPrivateProfile" value="<?php echo $is_private; ?>"> My Profile is Private<br><br>
<input type="checkbox" id="chkHideContactDetails" name="chkHideContactDetails" value="<?php echo $hide_contact_details; ?>"> Hide my contact details<br><br>

I have no problem reading a varchar value but my problem is juts with the bit as it's my first time trying checkbox with php.

Please help...

Thanks,
Jassim

traq

jrahma;11034633 wrote:
I am having difficulties reading the bit value from MySQL and showing it in a checkbox in PHP.

The value is not showing ...

Have you tried [man]var_dump[/man]ing out your [font=monospace]$is_private[/font] and [font=monospace]$hide_contact_details[/font] variables to make sure they contain the values you think they do? Keep in mind that, since you're casting to boolean, you will only see anything printed to the page if it is truthy ([font=monospace]print false;[/font] prints an empty string; [font=monospace]print true;[/font] prints 1).

jrahma;11034633 wrote:
and it's always unchecked!

That's because you're not checking them.

<input type=checkbox value=whatever checked>
<!-- or, of course, by clicking on them before submitting the form -->

However, I would think that this approach would be confusing and unreliable - you're dynamically determining the value of the input, but the label is always the same. How will the user know what option they are choosing?

jrahma

var_dumping is dumping the correct value (true and false) but when I changed the html to the following code I get it checked ALWAYS even when the value was var_dumped as false:

<input type="checkbox" id="chkPrivateProfile" name="chkPrivateProfile" value="<?php echo $is_private; ?>" <?php if ((bool)$is_private = true) { ?>checked="checked"<?php } ?>> My Profile is Private<br><br>
<input type="checkbox" id="chkHideContactDetails" name="chkHideContactDetails" value="<?php echo $hide_contact_details; ?>" <?php if ((bool)$hide_contact_details = true) { ?>checked="checked"<?php } ?>> Hide my contact details<br><br>

traq

Alright; to clarify: the [font=monospace]value[/font] of a checkbox has nothing to do with whether or not it is "checked." It's just the value that is assigned to the form field if the box is checked.

If you're trying to check the box depending on whether the value from the DB is true or false, you'd need to do the exact opposite: the value should always be the same, and the [font=monospace]checked[/font] attribute should be dynamically determined:

<?php

//  . . . 

$check_is_private = ($mysql_row["is_private"])? 'checked': '';

//  . . .

?>
<input type=checkbox name=chkPrivateProfile value=1 <?= $check_is_private ?> >

= = = = = edit = = = = =

I just saw what you meant by "checked ALLWAYS":

((bool)$is_private = true)

You're making an assignment there, not a comparison. Use triple equal ( === ) for equality (double equal ( == ) for loose equality; equal ( = ) for assignment).

Weedpacket

Just as a matter of code design:

if ($mysql_row_count <= 0) { exit(header("Location: home")); }

while ($mysql_row = $mysql_query->fetch())
{
    $is_private = (bool)$mysql_row["is_private"];
    $hide_contact_details = (bool)$mysql_row["hide_contact_details"];
}

Is there (a) much point in testing if fewer than 0 rows are returned, (b) writing an entire loop if you're going to ignore the results of all but one row?

jrahma

Thanks. My problem is solved using traq's code.

traq

glad to hear it. But Weedpacket's question is still valid - are you getting more than one row? would it cause problems if you did?

If you need + expect only one row, then looping is pointless. Additionally, you should test for what you need (1 row) rather than not-exactly-what-you-need (1 or more rows). Something like this would be a better pattern:

<?php

//  . . .

$stmt->execute()

if( $stmt->rowCount() === 1 ){
    $result = $stmt->fetch();
    /*  do stuff  */
}
else{
    /*  problem!  */
}