Display improper result after validating the form textboxes

salathia_partap

Hello Friends,
I am working on PHP and I am totally new to PHP. I want to validate the text boxes of this form. As it contains two text boxes with two buttons as cancel and save. I want when user click on save button it checks either the text boxes are empty or not. and if empty then display * very next to text boxes and not empty made a call to save function....

My code is as

<?php 
session_start();
if(!$_SESSION['sessionusername'])
{
	header("location:index.php");
}
else
{
	include ('connection2.php');
	$local_session = $_SESSION['sessionusername'] ;

$depnameErr = $depidErr= "";

if ($_SERVER["REQUEST_METHOD"] == "POST") 
{
	$depname = $depid = "";
	if (empty($_POST['text_depname'])) 
	{
    	$depnameErr = "*";
	}
	else
	{
		$depname = $_POST['text_depname'];	
	}

	if(empty($_POST['text_deptid']))
	{
		$depidErr = "*";
	}
	else
	{
		$depid = $_POST['text_deptid'];	
	}



if(($depname != "") && ($depid != ""))
{

	if(isset($_POST["btn_save"]))
	{	

		 $error_val = save_fxn($depid,$depname);
	}
}
}
}


?>



<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<link rel="stylesheet" media="screen" href="css/master.css">
<link rel="stylesheet" media="screen" href="css/menus.css">

<title>Phytec India</title>
</head>






<body>


<form method="POST" action=<?php 
	if(isset($_POST['s_close']))
	{
		header("location:department.php");	
	}
	elseif(isset($_POST["btn_save"]))
	{	
		"newdepartment.php";

}
?>

<div id="welcome">
	<div id="welcome_text">Welcome <?php echo "$local_session" ?>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a href="logout.php">Signout</a></div>
</div>

And some part of the code form text point of view

 <td id="table_controls" >
            	 <div id="text_controls">
	              <input type="text" maxlength="6" name="text_depid"  width="auto" style="height:15px;"/>
                 <span class="error"><?php echo $depidErr;?></span>
                </div>
            </td>

<td id="table_controls">
            	<div id="text_controls">
                	<input type="text" maxlength="30" name="text_depname"  width="auto" style="height:15px;"/>

                 <span class="error"><?php  echo $depnameErr;?></span>
            </div>
        </td>

And button code is as

<td>
        	<div id="nav_btn">
          <input type="submit" name="btn_save" value="Save"  onSubmit="save_fxn();" />

            <input type="submit" name="s_close" value="Close" />
            </div>
    </td>

Please help me to solve the problem

salathia_partap

After entering in the page and clicking on the save button without entering the value in the text boxes.. It displays symbol next to the text boxes but when i add some values in the text boxes and click on the save button, it display one near to first text box and did not save the data......

johanafm

Please use php tags instead of code tags when posting php code.

salathia_partap;11034909 wrote:
if (!$_SESSION['sessionusername']) {

!$variable only works if said $variable or array element has been defined. Otherwise you still get errors. Use [man]isset[/man] or [man]empty[/man]

salathia_partap;11034909 wrote:

<form method="POST" action=<?php 
	if(isset($_POST['s_close']))
	{
		header("location:department.php");	
	}

PHP code is not executed in the browser. The server executes PHP code. It is often used to produce output in the form of html code which is sent to the browser. But while the web server will most likely send output in chunks, you can assume that all server processing happens before the browser see any html code at all.

If you really wanted to redirect the user elsewhere on the other hand, then you should not do so after sending half a page of output. You do that before doing anything else.

salathia_partap;11034909 wrote:

if (!$_SESSION['sessionusername']) {
    header("location: index.php");
}

setting http headers does not interrupt execution of your php script.

salathia_partap;11034909 wrote:
header("location:department.php");
header("location: index.php");

Location headers must be specified using a fully qualified uri, and that means that protocol MUST be included.

I recommend collecting errors in an array instead of separate variables, since it will make error checking easier. As in

else {
    include('connection2.php');
    $local_session = $_SESSION['sessionusername'];

    $errors =  array();

    if ($_SERVER["REQUEST_METHOD"] == "POST") {
        $depname = $depid = "";
        if (empty($_POST['text_depname'])) {
            $errors['depname'] = "*";
        }
        # Which means you can remove these else blocks. And should.
        /*
        else {
            $depname = $_POST['text_depname'];
        }
        */

if (empty($_POST['text_deptid'])) {
    $error['depidErr'] = "*";
}

# Instead of having cumbersome checks against all variables that should be saved,
# just perform one.
if (count($errors) == 0) {

    if (isset($_POST["btn_save"])) {
        # Use _POST vars here. escape as needed inside save_fxn.
        # This way you will not have other variables floating around that may contain
        # either escaped or unescaped data.
        $error_val = save_fxn($_POST['depid'], $_POST['depname']);
    }
}
    }
}

dalecosp

johanafm;11034913 wrote:
Location headers must be specified using a fully qualified uri, and that means that protocol MUST be included.

Are you quoting/paraphrasing [man]header[/man] here, or the HTTP RFC/Spec.?

johanafm

HTTP/1.1 RFC

14.30 Location

The Location response-header field (…) value consists of a single absolute URI.
   Location       = "Location" ":" absoluteURI

salathia_partap

johanafm;11034967 wrote:
HTTP/1.1 RFC

i did the same thing in my code what you said but it was displaying me an error.. My new code is as

<?php 
session_start();
if(!$_SESSION['sessionusername'])
{
	header("location:index.php");
}
else
{
	include ('connection2.php');
	$local_session = $_SESSION['sessionusername'] ;

$errors =  array(); 
$error_val;

if ($_SERVER["REQUEST_METHOD"] == "POST") 
{ 
    $depname = $depid = ""; 

    if (empty($_POST['text_depname'])) 
	{ 
        $errors['depnameErr'] = "*"; 
    } 
    # Which means you can remove these else blocks. And should. 
    /* 
    else { 
        $depname = $_POST['text_depname']; 
    } 
    */ 

    if (empty($_POST['text_deptid'])) 
	{ 
        $error['depidErr'] = "*"; 
    } 

    # Instead of having cumbersome checks against all variables that should be saved, 
    # just perform one. 
    if (count($errors) == 0) 
	{ 
	echo "HELLO";

        if (isset($_POST['btn_save'])) 
		{ 
            # Use _POST vars here. escape as needed inside save_fxn. 
            # This way you will not have other variables floating around that may contain 
            # either escaped or unescaped data. 
            $error_val = save_fxn($_POST['depid'], $_POST['depname']); 
        } 
    } 
} 
}


?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<link rel="stylesheet" media="screen" href="css/master.css">
<link rel="stylesheet" media="screen" href="css/menus.css">

<title>Phytec India</title>
</head>






<body>


<form method="POST" action=<?php 
	if(isset($_POST['s_close']))
	{
		header("location:department.php");	
	}
	elseif(isset($_POST["btn_save"]))
	{	
		"newdepartment.php";

}
?>

<div id="welcome">
	<div id="welcome_text">Welcome <?php echo "$local_session" ?>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a href="logout.php">Signout</a></div>
</div>
<div id="header">
    	<div id="header_logo">
        	<img src="Images/logo.gif" height="29" width="178" />
        </div>
  </div>

 <div id="container">
      	<div id="departments">
        	<label id="dep_text">Add New Department</label>
            <div id="error_div">
            <span class="error"><?php echo "$error_val"?></span>

        </div>

    </div>

  <div id="text_area">
 		 <table width="auto" align="center" border="0" cellspacing="0" cellpadding="0">
    <tr>
    	<td colspan="4"></td>
   </tr>

    <tr>
    	<td >
        	<div id="text_labels">
            	<label>Department Id :</label>
            </div>
         </td>

        <td id="table_controls" >
        	 <div id="text_controls">
              <input type="text" maxlength="6" name="text_depid"  width="auto" style="height:15px;"/>
             <span class="error"><?php echo $depidErr;?></span>
            </div>
        </td>

    </tr>

    <tr>
    	 <td>
        	<div id="text_labels">
            	<label>Department Name :</label>
            </div>
         </td>


        <td id="table_controls">
        	<div id="text_controls">
            	<input type="text" maxlength="30" name="text_depname"  width="auto" style="height:15px;"/>

                 <span class="error"><?php  echo $depnameErr;?></span>
            </div>
        </td>
    </tr>



    </table>
     <table width="auto" align="center" border="0" cellspacing="0" cellpadding="0">
     <tr>
    <td>
    	<div id="nav_btn">
      <input type="submit" name="btn_save" value="Save"  onSubmit="save_fxn();" />

            <input type="submit" name="s_close" value="Close" />
            </div>
    </td>
    </tr>
    </table>

    </div>
		<!--<table width="998px" cellspacing="0" cellpadding="0" border="none">

        </table>
      -->
   </div>

It displaying me an error as
Notice: Undefined variable: error_val in C:\xampp\htdocs\OMS\newdepartment.php on line 198
Notice: Undefined variable: depidErr in C:\xampp\htdocs\OMS\newdepartment.php on line 220
Notice: Undefined variable: depnameErr in C:\xampp\htdocs\OMS\newdepartment.php on line 238

bradgrafelman

First problem I note is that the code you posted only has 163 lines. However....

salathia_partap;11035121 wrote:
Notice: Undefined variable: error_val in C:\xampp\htdocs\OMS\newdepartment.php on line 198

You always attempt to echo $error_val, however you only define that variable if $_SERVER["REQUEST_METHOD"] == "POST" and there are "errors" (i.e. the ones you're checking for beginning on line 19 of the posted code).

salathia_partap;11035121 wrote:
Notice: Undefined variable: depidErr in C:\xampp\htdocs\OMS\newdepartment.php on line 220

You always attempt to echo $depidErr, yet you never attempt to define it.

salathia_partap;11035121 wrote:
Notice: Undefined variable: depnameErr in C:\xampp\htdocs\OMS\newdepartment.php on line 238

You always attempt to echo $depnameErr, yet you never attempt to define it.