why my PHP is NOT ignoring the <select>?

jrahma

Hi,

I have a PHP page with cboindustry <select> item. I am doing the following to check if <select> has an entry then it will run the stored procedures:

if ($_POST['cboIndustry'])
{
    foreach ( $_POST['cboIndustry'] as $key => $value )
    {
        $mysql_query = $mysql_connection->prepare('CALL sp_add_new_company_industry(:param_member_guid, :param_company_guid, :param_company_industry, :param_created_ip_address)');
        $mysql_query->bindParam(':param_member_guid', $_SESSION["xoompage_member_guid"], PDO::PARAM_STR);
        $mysql_query->bindParam(':param_company_guid', $company_guid, PDO::PARAM_STR);
        $mysql_query->bindParam(':param_company_industry', $value, PDO::PARAM_STR);
        $mysql_query->bindParam(':param_created_ip_address', $_SERVER['REMOTE_ADDR'], PDO::PARAM_STR);
        $mysql_query->execute();
    }
}

but I am getting the following error:

PDO Exception Caught. Error with the database:
SQL Query: Code: HY000 Error: SQLSTATE[HY000]: General error: 1366 Incorrect integer value: '' for column 'param_company_industry' at row 1SQLSTATE[HY000]: General error: 1366 Incorrect integer value: '' for column 'param_company_industry' at row 1

here is my var_dump of the cboIndustry:

array(1) { [0]=> string(0) "" }

and here is the html:

<tr>
    <td valign="middle">Industry</td>
    <td valign="middle">:</td>
    <td valign="middle">         

        <div id="container">
        <select id="cboIndustry" name="cboIndustry[]" style="width: 80%" <?php if (!$_GET["id"]) { ?>required<?php } ?>>
            <option value="" selected>[Industry..]</option>
            <?php
                $mysql_command = "CALL sp_populate_industry()";
                $mysql_query = $mysql_connection->prepare($mysql_command);

            $mysql_query->execute();

            while($mysql_row = $mysql_query->fetch())
            {
        ?>
        <option value="<?php echo $mysql_row['industry_id']; ?>"><?php echo $mysql_row['industry_name']; ?></option>
        <?php } ?>
    </select>
    <button id="btnAddIndustry" type="button" style="width:150px">Add More</button>
    </div>
</td>
</tr>

NogDog

$mysql_query->bindParam(':param_company_industry', $value, PDO::PARAM_[B][COLOR="#B22222"]INT[/COLOR][/B]);

jrahma

but I am NOT passing any industry in the cboIndustry as you can see in the var_dump so the whole if block should be ignored!

traq

jrahma;11037027 wrote:
but I am NOT passing any industry in the cboIndustry as you can see in the var_dump so the whole if block should be ignored!

You're not posting the form? Or you're not choosing an option for the select box?
If the form is posted, the "cboIndustry" index will exist; if its default value is non-empty, your if condition will be truthy and the code will run.

array(1) { [0]=> string(0) "" }

An array that has an empty string in it is not empty.

NogDog

All I know is that the error message says that the column is an integer type, but your code is trying to pass it a string (even if it is an empty string, it is not an integer). Depending on the desired functionality, you'll either want ot pass it 0 or NULL in that case, I presume, but not any type of string (or float, or BLOB, etc.), and by specifying PDO:😛ARMA_STR, you are forcing it to treat the submitted value as a string.

jrahma

I am not selecting anything in the <select>. here is it when nothing is selected:

<option value="" selected>[Industry..]</option>

bradgrafelman

That corresponds to the data you posted above. The selected option above has a default value of an empty string, which is the same value depicted in the var_dump() output.

jrahma

and what's the solution for it?

bradgrafelman

The solution for what? Your broken logic? One possibility would be to change this if() statement:

if ($_POST['cboIndustry'])

to something more meaningful.

Based on quick inspection, it sounds like you really only want that code block to be executed if all of the following are true:

$_POST['cboIndustry'] exists (something you should always check first when it comes to external data)
it is an array
it has a length greater than zero

Even then, you'll want to skip over any values in the array that are equal to an empty string (since that's what you're using as the default value for the <select> entity).