Problem in processing AJAX response

cipars

Hi, i have problems with getting processing ajax.responsetext.
My php from where it sends response to ajax :

echo "fail";

ajax.responsetext processing:

if(ajax.responseText == "fail"){
					_("status").innerHTML = "Login unsuccessful, please try again.";
					_("loginbtn").style.display = "block";
				} else {
					window.location = "user.php?u="+ajax.responseText;
				}

And it is not working. Javascript returns "user.php?u="+ajax.responseText;" when it should return "Login unsuccessful, please try again."
please help me find problem in this.
Here is my whole code:

<?php
// AJAX CALLS THIS LOGIN CODE TO EXECUTE
if (isset ( $_POST ["u"] )) {
	// CONNECT TO THE DATABASE
	include_once ("php_includes/db_conx.php");
	// GATHER THE POSTED DATA INTO LOCAL VARIABLES AND SANITIZE
	$u = mysqli_real_escape_string ( $db_conx, $_POST ['u'] );
	$p = $_POST ['p'];
	$hashp = md5($p);
	// GET USER IP ADDRESS
	$ip = preg_replace ( '#[^0-9.]#', '', getenv ( 'REMOTE_ADDR' ) );
	// FORM DATA ERROR HANDLING
	if ($u == "" || $p == "") {	
		echo "fail";
		exit ();
	} else {
		// END FORM DATA ERROR HANDLING
		$sql = "SELECT id, email, password FROM users WHERE username='$u' AND activated='1' LIMIT 1";
		$query = mysqli_query ( $db_conx, $sql );   

		$row = mysqli_fetch_row ( $query );
		$db_id = $row [0];
		$db_email = $row [1];
		$db_pass_str = $row [2];
		if ($hashp != $db_pass_str) {
			echo "fail"; 
			exit ();
		} else {
			// CREATE THEIR SESSIONS AND COOKIES
			$_SESSION ['userid'] = $db_id;
			$_SESSION ['username'] = $u;
			$_SESSION ['password'] = $db_pass_str;
			setcookie ( "id", $db_id, strtotime ( '+30 days' ), "/", "", "", TRUE );
			setcookie ( "user", $u, strtotime ( '+30 days' ), "/", "", "", TRUE );
			setcookie ( "pass", $db_pass_str, strtotime ( '+30 days' ), "/", "", "", TRUE );
			// UPDATE THEIR "IP" AND "LASTLOGIN" FIELDS
			$sql = "UPDATE users SET ip='$ip', lastlogin=now() WHERE username='$u' LIMIT 1";
			$query = mysqli_query ( $db_conx, $sql );
			echo $u;
			exit ();
		}
	}
	exit ();
}
?>
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Log In</title>
<link rel="icon" href="favicon.ico" type="image/x-icon">
<link rel="stylesheet" href="style/style.css">
<script src="js/main.js"></script>
<script src="js/ajax.js"></script>
<script>
function emptyElement(x){
	_(x).innerHTML = "";
}
function login(){
	var u = _("username").value;
	var p = _("password").value;
	if(u == "" || p == ""){
		_("status").innerHTML = "Fill out all of the form data";
	} else {
		_("loginbtn").style.display = "none";
		_("status").innerHTML = 'please wait ...';
		var ajax = ajaxObj("POST", "index.php");
        ajax.onreadystatechange = function() {
	        if(ajaxReturn(ajax) == true) {
	            if(ajax.responseText == "fail"){
					_("status").innerHTML = "Login unsuccessful, please try again.";
					_("loginbtn").style.display = "block";
				} else {
					window.location = "user.php?u="+ajax.responseText;
				}
	        }
        }
        ajax.send("u="+u+"&p="+p);
	}
}
</script>
</head>
<body>

<div id="pageMiddle">
		<h3>Log In Here</h3>
		<!-- LOGIN FORM -->
		<form id="loginform" onsubmit="return false;">
			<div>Username:</div>
			<input type="text" id="username" onfocus="emptyElement('status')"
				maxlength="88">
			<div>Password:</div>
			<input type="password" id="password" onfocus="emptyElement('status')"
				maxlength="50"> <br />
			<br />
			<button id="loginbtn" onclick="login()">Log In</button>
			<p id="status"></p>
			<a href="signup.php" >Register</a>
		</form>
		<!-- LOGIN FORM -->
	</div>

</body>
</html>

Weedpacket

Perhaps you'd have better success by using the HTTP protocol as designed, and sending back a proper error response (a 403 or 404), and then use the ajax object's facilities for recognising a successful/unsuccessful request.

cipars

I want to fild problem in this method i am using. Here is another page where i use same method and it is working perfectly:

<?php
 if (isset($_POST['task'])){
	echo "success"; 
	//code for adding task to db
	exit();
} else {
    echo "fail";
    exit();	
}

?>
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title><?php echo $u; ?></title>
<link rel="icon" href="favicon.ico" type="image/x-icon">
<link rel="stylesheet" href="style/style.css">
<script src="js/main.js"></script>
<script src="js/ajax.js"></script>
<script>
function addtask(){
	var task = _("task").value;
	if(task == ""){
		_("status").innerHTML = "Field cannot be empty.";
	} else {
		_("taskbtn").style.display = "none";
		_("status").innerHTML = 'please wait ...';
		var ajax = ajaxObj("POST", "user.php");
        ajax.onreadystatechange = function() {
	        if(ajaxReturn(ajax) == true) {
	            if(ajax.responseText == "success"){
	            	window.location = "index.php";
				} else {
					_("status").innerHTML = "Adding task unsuccessful, please try again.";
					_("loginbtn").style.display = "block";
				}
	        }
        }
        ajax.send("task="+task);
	}
}
</script>
</head>
<body> 
<div id="ownertask">Add task:<br />
			<input type="text" id="task" onfocus="emptyElement('status')"
				maxlength="300">
			<br />
			<button id="taskbtn" onclick="addtask()">Add Task</button>
			<p id="status"></p>
</div>
</body>
</html>

i just cant find difference...

bradgrafelman

Thread moved to ClientSide Technologies forum since this isn't a PHP issue.

cipars;11037223 wrote:
Javascript returns "user.php?u="+ajax.responseText;" when it should return "Login unsuccessful, please try again."

So, what was the exact value of ajax.responseText then?

cipars

ajax.respnsetext is "fail" or "$u"(username). If it is "fail" it should process following:

_("status").innerHTML = "Login unsuccessful, please try again.";
					_("loginbtn").style.display = "block";

If it is anything else, then it means it is not "fail" and in my case it is "$u". Then following code should be executed. It redirects user to his profile page with his username in link.

window.location = "user.php?u="+ajax.responseText;

bradgrafelman

I wasn't asking what values it could be or what should be done based on those values. I already know all of that - I read the code.

I'm asking what is the value you're getting when you go to test this in your browser?

cipars

This is where odd part begins... It redirects me to URL: "user.php?u=fail"

bradgrafelman

Perhaps there is some whitespace? I'd probably set a breakpoint on the if(ajax.responseText == "fail") condition and inspect ajax.responseText to see what the debugger has to say about its value.