OOP - Call Method from another method in the same class

jeepin81

I am trying to call a method from inside a method that are in the same class. When I do this the first method doesn't return any data?

If I call them individually they work fine.

here is the code:

class shop extends model{

    //-----------------------------
//method to get drill3 content
//-----------------------------
public function getDrill3($d2id){
	$this->d2id = $d2id; 

	$sql = "SELECT * FROM abc.drill3 
			WHERE D3D2A = '".db2_escape_string($this->d2id)."' 
			OR D3D2B = '".db2_escape_string($this->d2id)."'
			OR D3D2C = '".db2_escape_string($this->d2id)."'";
	$this->db->query($sql,'');

	while($this->db->multiRows()){

		//check count on drills
		$this->tc = $this->checkDeadDrill($this->db->rec['D3ID']);

		$this->drill3[$this->c]['id']	= rtrim($this->db->rec['D3ID']);
		$this->drill3[$this->c]['desc'] = rtrim($this->db->rec['D3DESC']);	
		$this->drill3[$this->c]['cnt']	= $this->tc;

		$this->c++;	

	}

	return $this->drill3;

//end method getDrill2();
}

    //-----------------------------
//method to check for "dead" drills
//-----------------------------
public function checkDeadDrill($id){
	$this->checkD3 = $id;

	//set our current date to weed out DISC items
	$this->currDate = date('Ymd');

	$sql2 = "SELECT * FROM abc.drill4
			JOIN abc.itemmast on IITEM = D4ITEM AND ICO = 1
			WHERE (IDDATE > ".$this->currDate." OR IDDATE = 0)
			AND (
			D4D3A = '".db2_escape_string($this->checkD3)."'
			OR D4D3B = '".db2_escape_string($this->checkD3)."'
			OR D4D3C = '".db2_escape_string($this->checkD3)."')";
	$this->db->query($sql2,'');

	while($this->db->multiRows()){
		$this->checkDead[]['item'] = trim($this->db->rec['D4ITEM']);
	}

	return count($this->checkDead);

//end method checkDeadDrill();	
}


}

foreach($this->shop->getDrill3($subCat3) as $e=>$f){
//data echo'd out here
//i tried call the deadDrill here and it just add the values during iteration.
}

I'm not sure if this is something along the lines of if(!method_exists){.... type of thing?

Any insight would be appreciated. Thanks!

traq

Can you explain further? I don't see where you "call a method from inside a method that are in the same class"— it looks more like both calls are outside the class entirely, and the second method is being called inside a loop using the results from the first method, i.e.:

# psuedocode

foreach( $yourclass->method1() as $whatever ){
    $yourclass->method2();
}

Is this correct?

jeepin81

I apologize for being vague... you are correct.

here is a more condensed view

function getDrill3($id){
  //query db
  while(){
    // call the second method
    $count = checkDeadDrill($row['id']);
    $arr[]['item'] = $row['item'];
    $arr[]['count'] = $count;
  }
}

function checkDeadDrill($id){
  //get a count from db
}

when I call "$count = checkDeadDrill($row['id']);" in my first method I don't get any data back at all? If I removed the call to the second method it return the items w/o the count.

Derokorian

He calls checkDeadDrill from getDrill3, around the 13th line in the method.

Note, if I get rid of your sql calls and stub a response, this code is working for me. Possibly an error with passing values between functions incorrectly? Can you show us the method call that's not working, along with your series of method calls that works?

jeepin81

thanks for the reply


//in initiate 
$this->shop = new shop();

//then I am looping through my getDrill3();
foreach($this->shop->getDrill3($subCat3) as $e=>$f){
//echo out data
}


//here is my shop class
class shop extends model{ 

    //----------------------------- 
//method to get drill3 content 
//----------------------------- 
public function getDrill3($d2id){ 
    $this->d2id = $d2id;  

    $sql = "SELECT * FROM abc.drill3  
            WHERE D3D2A = '".db2_escape_string($this->d2id)."'  
            OR D3D2B = '".db2_escape_string($this->d2id)."' 
            OR D3D2C = '".db2_escape_string($this->d2id)."'"; 
    $this->db->query($sql,''); 

    while($this->db->multiRows()){ 

        //check count on drills 
        $this->tc = $this->checkDeadDrill($this->db->rec['D3ID']); 

        $this->drill3[$this->c]['id']    = rtrim($this->db->rec['D3ID']); 
        $this->drill3[$this->c]['desc'] = rtrim($this->db->rec['D3DESC']);     
        $this->drill3[$this->c]['cnt']    = $this->tc; 

        $this->c++;     

    } 

    return $this->drill3; 

//end method getDrill2(); 
} 

    //----------------------------- 
//method to check for "dead" drills 
//----------------------------- 
public function checkDeadDrill($id){ 
    $this->checkD3 = $id; 

    //set our current date to weed out DISC items 
    $this->currDate = date('Ymd'); 

    $sql2 = "SELECT * FROM abc.drill4 
            JOIN abc.itemmast on IITEM = D4ITEM AND ICO = 1 
            WHERE (IDDATE > ".$this->currDate." OR IDDATE = 0) 
            AND ( 
            D4D3A = '".db2_escape_string($this->checkD3)."' 
            OR D4D3B = '".db2_escape_string($this->checkD3)."' 
            OR D4D3C = '".db2_escape_string($this->checkD3)."')"; 
    $this->db->query($sql2,''); 

    while($this->db->multiRows()){ 
        $this->checkDead[]['item'] = trim($this->db->rec['D4ITEM']); 
    } 

    return count($this->checkDead); 

//end method checkDeadDrill();     
} 


}

if i remove the checkDeadDrill call inside the getDrill3 and call it via the foreach() loop it gets the correct return value on the 1st iteration but then it keeps adding up.

for example:


//then I am looping through my getDrill3();
foreach($this->shop->getDrill3($subCat3) as $e=>$f){

   $check = $this->shop->checkDeadDrill($f['id']);
   echo $check.'<br/>'; //
   //echo out data
}

the first return is the correct amount which is 9. Then from there it just keeps adding up that 9.

9
18
27
36
etc...

instead of return the correct value for each id I pass the method. Again, if I call the checkDeadDrill inside of getDrill3 my foreach loop doesn't return any data.

If I test:

echo $this->shop->checkDeadDrill('49'); // or any id it returns successfully.

Is it possible it has something to do w/ my DB class?

bradgrafelman

You're calling the second method from a loop inside the first method that's processing the rows returned from a SQL query. Not only is this potentially an inefficient design (SQL queries executed inside loops processing another SQL query is always a huge red flag to me), but it's also quite possibly overwriting the result set retrieved by getDrill3() after the first call in the loop to checkDeadDrill().

jeepin81

Thanks for the reply...

would I want to handle that like:


//then I am looping through my getDrill3(); 
$drill3 = $this->shop->getDrill3($subCat3);
foreach($drill3 as $e=>$f){ 

   $check = $this->shop->checkDeadDrill($f['id']); 
   echo $check.'<br/>'; // 
   //echo out data 
}

my end result is if the $check comes back as zero - I don't want to display that data and continue through my foreach loop.

Derokorian

Also note:

while($this->db->multiRows()){  

            $this->checkDead[]['item'] = trim($this->db->rec['D4ITEM']);  

        }

This is an object property array you are adding items to. You are then returning the count of this array. So on the first iteration it will only have the initially added items, however on the second iteration, those initial items still exist in the array, so that when you add more to it, you now get a count of what you added + what already existed. Try clearing out the array before adding more things to it. Also, try incrementing a counter you return instead of duplicating all the data in another array (which is slower and requires more memory).

jeepin81

I guess I am lost here... If i try the following:

$drill3 = $this->shop->getDrill3($subCat3);
foreach($drill3 as $e=>$f){
  $check = $this->shop->checkDeadDrill($f['id']);
  echo count($check);
  echo '<br/>';
  unset($check);
  $check = array();
}

It still appears to grab the first iteration and then add to it's self . ie:

9
18
27
etc..

not sure what else to try or look at?

johanafm

Maybe start by print_r($drill3)?