[Help] POST Unknown login system

ganjaboss

Hi there, coders!

I'm pretty new at coding, and i'm trying to make a basic login system..
But it's tripping my brain off..

This is index.php

<html>

	<from action='login.php' method='POST'>
		Username: <input type='text' name='username'><br>
		Password: <input type='password' name='password'><br>
		<input type='submit' value='Login'>
	</form>


</html>

And this is login.php

<?php
include_once  'index.php';

$username = $_POST['username'];
$password = $_POST['password'];

if ($username&&$password)
{

$connect = mysql_connect("localhost", "root", "") or die("Couldn't connect");
mysql_select_db("ganjausers_db") or die("Couldn't find the database!");

}
else
	die("Please enter username and password!");


?>

The problem:
[ATTACH]4989[/ATTACH]

I tried to use include command.. For importing the POST, but it doesn't work if it's there, and neither if it isn't there..
Can anybody help me ? 😛

test.png

bradgrafelman

ganjaboss;11037409 wrote:
I tried to use include command.. For importing the POST

No idea what you mean there... can you elaborate?

The only thing your include statement is going to do is display the login form again after it has been submitted (since that's all that index.php appears to do).

ganjaboss;11037409 wrote:
but it doesn't work if it's there, and neither if it isn't there..

What do you mean? How do you know "it" doesn't work? What are you seeing and what did you expect to see?

In the code you posted above, assuming there are no errors connecting to the MySQL server and selecting the database, the only thing you should expect to see is the login form displayed again with no error messages.

Speaking of connecting to MySQL... Stop Using the MySQL Extension!

EDIT: Missed the attachment link the first time around (probably because it would have been easier to just post the errors). Since you never check to see if the external variables exist before you attempted to use them, I would expect to see those errors if you visited the login.php directly.

If you're trying to submit the form and getting those messages, you might try using [man]var_dump/man or [man]print_r/man on $_POST to see what it contains.

EDIT2: Is "<from" a typo in your original post or is that actually in the HTML document?

ganjaboss

Well thanks for the answer.. I know i'm a bigass noob 😃
But..
why doesn't my index.php get effected by the login.php if now we say i removed the include_once?

bradgrafelman

ganjaboss;11037413 wrote:
why doesn't my index.php get effected by the login.php if now we say i removed the include_once?

Do you know the purpose of [man]include_once[/man]? It's essentially equivalent to copying and pasting a different file inside the file that contains that statement. Obviously, that's fairly useless (and probably completely undesired) here.

ganjaboss

Would you mind to fix the code? or..
I really need help i'm pretty bad at coding, i guess that's why..

sneakyimp

Bradgrafelman is being quite helpful. It's up to you to fix your own code. The goal here is to teach people the principles, not do their work for them.