make it PHP instead of C#

[jrahma]

Hi,

I have the following code in C#.NET

Can anyone help to convert it to PHP? I am totally lost!

private int ValidateID(string input)
{
    // Check length
    if (string.IsNullOrEmpty(input) || input.Length != 9)
        return 1;

if (int.Parse(input.Substring(2, 2)) > 12)
    return 2;

int total = 0;
for (int i = 0; i < 8; i++)
    total += int.Parse(input.Substring(i, 1)) * (9 - i);

int remainder = total % 11;
int digit9;
if (remainder < 2)
    digit9 = 0;
else
    digit9 = 11 - remainder;

if (digit9 != (int.Parse(input) % 10))
    return 3;

return 0;
}

switch (ValidateID(sql_reader["id_number"].ToString()))
{
    case 0: id_status = "Success"; break;
    case 1: id_status = "Invalid length"; MessageBox.Show("Incorrect ID Number [ID Number length]", "error", MessageBoxButtons.OK, MessageBoxIcon.Exclamation); this.Cursor = Cursors.Default; break;
    case 2: id_status = "Invalid month"; MessageBox.Show("Incorrect ID Number [ID Number month]", "error", MessageBoxButtons.OK, MessageBoxIcon.Exclamation); this.Cursor = Cursors.Default; break;
    case 3: id_status = "Invalid number"; MessageBox.Show("Incorrect ID Number [ID Number number]", "error", MessageBoxButtons.OK, MessageBoxIcon.Exclamation); this.Cursor = Cursors.Default; break;
    default: id_status = "Unknown"; MessageBox.Show("Incorrect ID Number [unknown]", "error", MessageBoxButtons.OK, MessageBoxIcon.Exclamation); this.Cursor = Cursors.Default; break;
}

[bradgrafelman]

What have you come up with so far?

[sneakyimp]

That first snip of code looks like a class function. The word 'private' means that the function could only be used by some other code within the class. You might want to check out the PHP docs:
http://us3.php.net/private

The second one is a simple switch statement. You may find the [man]switch[/man] docs useful.

[jrahma]

this is what I tried to code but getting Invalid number for a valid number:

<?php
    function validate_id($id_number)
    {
        if (!isset($id_number) || (strlen($id_number) != 9)) return 1;
        if (substr($id_number, 2, 2) > 12) return 2;

    for ($i = 0; $i < 8; $i++)
    { $total = substr($id_number, $i, 2) * (9 - $i); }

    $remainder = $total % 11;

    if ($remainder < 2) $digit9 = 0; else $digit9 = 11 - $remainder;
    if ($digit9 != $id_number % 10) return 3;

    return 0;
}

switch (validate_id("731004167"))
{
    case 0: $status = "Success"; break;
    case 1: $status = "Invalid length"; break;
    case 2: $status = "Invalid month"; break;
    case 3: $status = "Invalid number"; break;
    default: $status = "Uknown"; break;
}

echo $status;
?>

[sneakyimp]

I am not sure exactly what this function is supposed to do, but would point out that you are calling it with a string value instead of a number. Your original function also accepts a string as parameter, but takes care to parse the string into an int before attempting to do calculate % 10.

Perhaps instead of this:

if ($digit9 != $id_number % 10) return 3;

you could try this:

if ($digit9 != (intval($id_number) % 10)) return 3;

[jrahma]

Same problem. Actually I am trying to validate a national ID card number. It's working perfect on C#

[bradgrafelman]

The intval() shouldn't be necessary since PHP is (fortunately and/or unfortunately) very forgiving and loosely-typed.

One issue I do see, however, is that you've translated this C# code:

input.Substring(i, 1)

to this PHP code:

substr($id_number, $i, 2)

Next, inside the for() loop, total was previously being used as a running total of the math being performed, however your PHP code is constantly overwriting the value stored in $total on each iteration of the loop.

Once I fixed those two issues, the output was "Success".

[jrahma]

sorry I didn't understand the second problem (total). could you please explain?

[jrahma]

ok ok

I got it

It's working now

Thank you so much