Working on a OOP login/register system and getting some errors

fearlessxgamer

I am working on the actual logging in part and i am getting these two errors:

Notice: Trying to get property of non-object in M:\xampp\htdocs\FM Website\classes\user.php on line 36

I am getting the same error twice in my user.php file.

user.php

<?php
class User {
	private $_db,
			$_data,
			$_sessionName;

public function __construct($user = null) {
	$this->_db = DB::getInstance();

	$this->_sessionName = Config::get('session/session_name');
}

public function create($fields = array()) {
	if(!$this->_db->insert('users', $fields)) {
		throw new Exception('There was a problem creating a new account.');
	}
}

public function find($user = null) {
	if($user) {
		$field = (is_numeric($user)) ? 'id' : 'username';
		$data = $this->_db->get('users', array($field, '=', $user));

		if($data->count()) {
			$this->_data = $data->first();
			return true;
		}
	}
	return false;
}

public function login($username = null, $password = null) {
	$user = $this->find($username);

	if($user) {
		if($this->data()->password === Hash::make($password, $this->data()->salt)) {
			Session::put($this->_sessionName, $this->data()->id);
			return true;
		}

	}

	return false;
}

private function data() {
	return $this->_data;
}
}

If you need any more of my code to help i can gladly post it.

NogDog

Well, it seems to be telling you that $this->data is not an object (since that's what $this->data() is returning), so you might want to start out with some debug code doing a var_export() of $this->data to find out what it actually is, the work from there to find out why it is what it is.

fearlessxgamer

NogDog;11039393 wrote:
Well, it seems to be telling you that $this->data is not an object (since that's what $this->data() is returning), so you might want to start out with some debug code doing a var_export() of $this->data to find out what it actually is, the work from there to find out why it is what it is.

where would i do that var_export($this->_data); i did it in my user.php file and i get the same error and i did it in my index.php file and i get the error:

Fatal error: Using $this when not in object context in M:\xampp\htdocs\FM Website\index.php on line 11

my index.php file

 
<?php
require_once 'core/init.php';

if(Session::exists('home')) {
	echo '<p>' . Session::flash('home') . '</p>';
}

$user = new User();
//echo $user->data()->username;

var_export($this->_data);

?>

NogDog

You could put it in that data() method, e.g.:

    private function data() {
        error_log("DEBUG of _data:".PHP_EOL.var_export($this->_data, 1));
        return $this->_data;
    }

Then tail your php error log to see what it says, or if you just want to echo something direct to the screen:

    private function data() {
        echo "<pre>DEBUG of _data:\n".var_export($this->_data, 1)."</pre>";
        return $this->_data;
    }

fearlessxgamer

I did that and thanks for tell me how and i get this:

DEBUG of _data:
NULL

Notice: Trying to get property of non-object in M:\xampp\htdocs\FM Website\classes\user.php on line 50
DEBUG of _data:
NULL

Notice: Trying to get property of non-object in M:\xampp\htdocs\FM Website\classes\user.php on line 50

fearlessxgamer

fearlessxgamer;11039403 wrote:
I did that and thanks for tell me how and i get this:

DEBUG of _data:
NULL

Notice: Trying to get property of non-object in M:\xampp\htdocs\FM Website\classes\user.php on line 50
DEBUG of _data:
NULL

Notice: Trying to get property of non-object in M:\xampp\htdocs\FM Website\classes\user.php on line 50

It is line 50 because i have added some other stuff. It is still line 36 for the main post.

NogDog

Well, NULL is not an object, so now you have to work backwards through the code and find out where $this->_data is being populated. From the supplied code, that only appears to happen in the find() method, and that only appears to be called by the login() method. So you may want to inspect some variables in those methods, check if if() conditions are passing, and so forth. It might help to add some defensive code, such as checking return values from function calls for unexpected values and handling them accordingly (raising an exception, just logging info in the error_log, responding with an error message to the user, or whatever).