Registeration Error

rajatahirqaiser

Can anyone can help me ?
This code always Show "Failed to Register you This time" When I register account 🙁

I am unable to find the error, Anyone of you ? Figure out please !

<?php
require 'core.inc.php';
require 'connect.inc.php';

if(!loggedin())
{
if(isset($_POST['username'])&&isset($_POST['password'])&&isset($_POST['password_again'])&&isset($_POST['firstname'])&&isset($_POST['surname']))
{
$username=$_POST['username'];
$password=$_POST['password'];
$password_again=$_POST['password_again'];
$firstname=$_POST['firstname'];
$surname=$_POST['surname'];
$password_hash=md5($password);

if(!empty($username)&&!empty($password)&&!empty($password_again)&&!empty($firstname)&&!empty($surname))
{
 if($password!==$password_again)
 {
 echo " The Password Don't Match with Each Other";
 }
 else

{

$query="SELECT `username` FROM `users` WHERE `username`='$username'";
$query_run=mysql_query($query);	
if(mysql_num_rows($query_run)==1)
{
echo "The Username Already Exists";
}
else
{
$query=" INSERT INTO `users` VALUES ('','".mysql_real_escape_string($username)."','".mysql_real_escape_string($password_hash)."','".mysql_real_escape_string($firstname)."','".mysql_real_escape_string($surname)."')";
if($query_run=mysql_query($query))
{
header('Location: register_success.php');
}
else
{
echo "Failed to Register you This time";
}
}
}
}
else
{
echo "All Fields are Required";
}
}
?>
<form action="register.php" method="POST">
Username : <br><input type="text" name="username"><br><br>
Password : <br><input type="password" name="password"><br><br>
Password Again : <br><input type="password" name="password_again"><br><br>
First Name : <br><input type="text" name="firstname"><br><br>
Last Name : <br><input type="text" name="surname" ><br><br>
<input type="submit" name="Register">

</form>


<?php
}
else if (loggedin())
{
echo 'You\'re Already Logged in';
}


?>

bradgrafelman

Welcome to PHPBuilder! When posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze. Speaking of being able to read... are you truly writing code as depicted above, i.e. with little to zero indentation? If so, I would highly recommend you reconsider your style of coding - it can immensely help you (and others) attempt to read the code.

As for your issue... what debugging steps have you taken? The message you referenced appears to only be displayed if the INSERT SQL query fails to execute. Thus, you would obviously want to determine why that query didn't execute successfully. To do so, examine the string returned by [man]mysql_error/man. It can also be helpful to output the query string itself exactly as it was sent to the SQL server for execution.

Finally, if you'll visit the manual page I linked to above, you'll hopefully notice a big red box that begins with the word "Warning." That brings me to my last point: Stop Using the MySQL Extension!

rajatahirqaiser

Sir,
I am not Good at Php, I didn't get in what you said above, moreover I also didn't coded that, I watched a tutorial and than written that code

But I can see there is an error in this Code, Can you please check it where the mistake is ?

And where to add mysql_error() in the code to check the error ?

$query=" INSERT INTO `users` VALUES ('','".mysql_real_escape_string($username)."','".mysql_real_escape_string($password_hash)."','".mysql_real_escape_string($firstname)."','".mysql_real_escape_string($surname)."')";
if($query_run=mysql_query($query))
{
header('Location: register_success.php');
}
else
{
echo "Failed to Register you This time";
}