[RESOLVED] do I need an else if I'm using exit?

schwim

Hi there folks!

I've always written in the following manner:


if($if_its_safe){

/* Do the stuff */

}else{

/* Don't do the stuff.

}

but have always come across:


if(!$its_safe){

   exit;

}

/* Do the stuff only if it's safe */

I've never written that way because visually, the super secret stuff is only an "exit;" away from the checks and balances. It's worried me.

It looks much neater, however so I wouldn't mind moving to that. Is it a safe way to handle things? I know this can be a loaded question, but I'm only asking if exiting a script really exits the script or if there's any added security in burying my stuff in an else.

Thanks for your time!

Weedpacket

You don't need it in the syntactic sense of course. Personally I would go with the latter, since it saves a level of indentation that doesn't provide any useful information through the rest of the code; "if you're here then you didn't exit - since you didn't exit I thought you'd like to know that you're still here."

schwim wrote:
I'm only asking if exiting a script really exits the script

Yes.

schwim

Thanks a bunch for your help, weed, I'll handle it that way from here on out, as I like the look of it better.

Thanks again!

Derokorian

FYI the same is true of a return statement in a function. IE:

function foo($var) {
   if( $var === BAR ) {
      return false;
   }
   return true;
}

schwim

Derokorian;11042875 wrote:
FYI the same is true of a return statement in a function. IE:
function foo($var) {
   if( $var === BAR ) {
      return false;
   }
   return true;
}

Thank you for that, Derokorian. I've not done much more than modify other's functions, but will try to keep this method in use, as it seems much cleaner to me.

thanks again!