Paypal Sucess

tracyn2k2

Hello Members,

My developer has a problem with paypal success, and he could not find out where is the issue. Please anyone can help me out.
it is confusing between url success and url cancel. Very Appreciated your help!

Paypal form

==========================================

paypal success page code

if(isset($REQUEST['tx']) && isset($REQUEST['tx']) == "Completed")
{

echo "<div class='box'>";
echo "Your Transcation Id is : " . $_REQUEST['tx'] . "<br>";
echo "Your Transcation has been successfull";echo "<br>";
echo "Thank You!";
echo "</div>";
echo "<div class='box1'>Your Account was created successfully. Please Check your Email to complete the activation of your account</div>";

            // this insert query is not run      
            global $wpdb; 
             $time1 = current_time('mysql'); 
            $wpdb->insert( 'user_meta' , array( 
                'Email' => $_SESSION['user_email'], 
                'user_login' => $_SESSION['user_login'], 
                'first_name' => $_SESSION['first_name'], 
                'last_name' => $_SESSION['last_name'], 
                'compny_name' => $_SESSION['compny_name'], 
                'H_PhoneNumber' => $_SESSION['H_PhoneNumber'], 
                'address1' => $_SESSION['address1'], 
                'address2' => $_SESSION['address2'], 
                'city' => $_SESSION['city1'], 
                'state' => $_SESSION['state1'], 
                'zip' => $_SESSION['zip'], 
                'country' => $_SESSION['country'], 
                'select_plan' => $_SESSION['amount'], 
                'box_number' => $_SESSION['step_1'], 
                'toll_free_prefix_number' => $_SESSION['prefix'], //toll_free_prefix_number 
                'toll_free_choose_number' => $_SESSION['tollfreeselect'], //toll_free_prefix_number 

                'local_number_city' => $_SESSION['city'], //local_number 
                'local_number_state' => $_SESSION['state'], //local_number 
                'local_number_choose_number' => $_SESSION['localdidselect'],//$_POST['localdidselect'] Local_number 

                'existing_port_number' => $_SESSION['port_number'], 
                'Transcation_ID' => $_REQUEST['tx'], 
                'date_time' => $time1), 
                array('%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s','%s'));  
        }else{ 
            echo "<div class='box'>"; 
            echo "<p  style='color:black!important;margin-top:20px;'>Your request  to cancel your order was successful.</p>";   
            echo "</div>"; 
        } ?>

sneakyimp

You haven't even described what the issue is.

tracyn2k2

Hello sneakyimp!
after transaction is completed, return url has to display " Your Transcation Id is : "
Your Transcation has been successfull"
"Thank You!"
Your Account was created successfully. Please Check your Email to complete the activation of your account"
i called "paypal success"

if cancel transaction . i called "paypal cancel and display cancel url. Your request to cancel your order was successful

Instead of paypal success display url success and send email to buyer to activate their account,then it displays url cancel.

but when developer test on sandbox it works, so up live, it does not works.
Pleasa help me!

Thank you.

sneakyimp

Your description is a little hard to follow, but I think this line of code is certainly a problem:

if(isset($_REQUEST['tx']) && isset($_REQUEST['tx']) == "Completed")

If you were to look up [man]isset[/man] in the documentation, then you would see that it returns a boolean value of TRUE or FALSE and so will never, ever, under any circumstances return the string "Completed"

Derokorian

sneakyimp;11047103 wrote:
Your description is a little hard to follow, but I think this line of code is certainly a problem:
if(isset($_REQUEST['tx']) && isset($_REQUEST['tx']) == "Completed") 
If you were to look up [man]isset[/man] in the documentation, then you would see that it returns a boolean value of TRUE or FALSE and so will never, ever, under any circumstances return the string "Completed"

actually (bool) "Completed" === true 🙂 so if its set, it should always be true! Try it out:

$_REQUEST['tx'] = "Incomplete";
if(isset($_REQUEST['tx']) && isset($_REQUEST['tx']) == "Completed")
	echo "Truth";

This is because of the loose comparison (==).

sneakyimp

Technically, my post was not incorrect, but I hadn't even thought it through enough to realize that it would always return true. In any case the correct would be to change it to this, no?

if(isset($_REQUEST['tx']) && ($_REQUEST['tx'] == "Completed") )

Derokorian

Yup that fix would certainly help, although I still like to use strict equals always. Check out the output from this:

$a = array(null, false, true, 0, 1, 0.0, 0.1, 1.0, 1.1);

foreach ($a as $v) {
	$tx = $v;
	if (isset($tx) && $tx == "Completed") {
    	var_dump($tx);
	}
}

bool(true)
int(0)
float(0)

Weedpacket

Though the elements of the [font=monospace]$_REQUEST[/font] array should always be strings anyway.