[RESOLVED] php edit data page issue

ianhaney

I got the profile page sorted but now have made a edit profile php page so the user can update their info, I have made the php page with the form and php but is not displaying no data within the form, I just ran the query directly in the phpmyadmin and returned no results so would explain the form being empty

Just seeing if the code can be checked over and see where I have gone wrong please if ok

My code is below

<?php
$db = mysqli_connect("" , "", "") or die("Check connection parameters!"); 
// Optionally skip select_db and use: mysqli_connect(host,user,pass,dbname)  

mysqli_select_db($db,"") or die(mysqli_error($db));

if (mysqli_connect_error()) {
    die ('Failed to connect to MySQL');
} else {
	echo '';
}

$visitor_id = 'visitor_id';

$sql = "SELECT
        v.visitor_id
        , visitor_name
        , visitor_email
		, visitor_firstline
		, visitor_secondline
		, visitor_town
		, visitor_county
		, visitor_postcode
		, visitor_tel
		, visitor_mobile
        , visitor_model
        , visitor_plate
        , DATE_FORMAT(renewal_date, '%e %M %Y') as datedue
        FROM visitors v
			INNER JOIN renewal USING (visitor_id)
            INNER JOIN item USING (item_id)
			WHERE visitor_id='".$visitor_id."'";

  $query = mysqli_query($db, $sql) or die (mysqli_error($db));

  while ($row = mysqli_fetch_array($query)) {
$visitor_name=$row['visitor_name'];
$visitor_email=$row['visitor_email'];
$visitor_firstline=$row['visitor_firstline'];
$visitor_secondline=$row['visitor_secondline'];
$visitor_town=$row['visitor_town'];
$visitor_county=$row['visitor_county'];
$visitor_postcode=$row['visitor_postcode'];
$visitor_tel=$row['visitor_tel'];
$visitor_mobile=$row['visitor_mobile'];
$visitor_model=$row['visitor_model'];
$visitor_plate=$row['visitor_plate'];
$insurance_date=$row['visitor_insurance'];
$tax_date=$row['visitor_tax'];
$mot_date=$row['visitor_mot'];
  }

?>
<form method="post" action="edit-data.php">
<input type="hidden" name="visitor_id" value="<?php echo $row['visitor_id']; ?>">
<label>Name :</label>
<input type="text" name="visitor_name" required="required" placeholder="Please Enter Name" value="<?php echo $row['visitor_name']; ?>" />
<br /><br />
<label>Email :</label>
<input type="email" name="visitor_email" required="required" placeholder="Please Enter Email" value="<?php echo $row['visitor_email']; ?>" />
<br /><br />
<label>Address Line 1 :</label>
<input type="text" name="visitor_firstline" required="required" placeholder="Please Enter Address Line 1" value="<?php echo $row['visitor_firstline'];?>" />
<br /><br />
<label>Address Line 2 :</label>
<input type="text" name="visitor_secondline" required="required" placeholder="Please Enter Address Line 2" value="<?php echo $row['visitor_secondline'];?>" />
<br /><br />
<label>Town :</label>
<input type="text" name="visitor_town" required="required" placeholder="Please Enter Town" value="<?php echo $row['visitor_town'];?>" />
<br /><br />
<label>Copunty :</label>
<input type="text" name="visitor_county" required="required" placeholder="Please Enter County" value="<?php echo $row['visitor_county'];?>" />
<br /><br />
<label>Postcode :</label>
<input type="text" name="visitor_postcode" required="required" placeholder="Please Enter Postcode" value="<?php echo $row['visitor_postcode'];?>" />
<br /><br />
<label>Telephone Number :</label>
<input type="text" name="visitor_tel" required="required" placeholder="Please Enter Telephone Number" value="<?php echo $row['visitor_tel'];?>" />
<br /><br />
<label>Mobile Number :</label>
<input type="text" name="visitor_mobile" required="required" placeholder="Please Enter Mobile Number" value="<?php echo $row['visitor_mobile'];?>" />
<br /><br />
<label>Model of Car/Van :</label>
<input type="text" name="visitor_model" required="required" placeholder="Please Enter Model of Car/Van" value="<?php echo $row['visitor_model'];?>" />
<br /><br />
<label>Car Tax Renewal Date :</label>
<input type="text" id="datepicker" name="visitor_tax" required="required" placeholder="Please Enter your Car Tax Renewal Date" value="<?php echo $row['visitor_tax'];?>" />
<br /><br />
<label>MOT Renewal Date :</label>
<input type="text" id="datepicker" name="visitor_mot" required="required" placeholder="Please Enter your Car MOT Renewal Date" value="<?php echo $row['visitor_mot'];?>" />
<br /><br />
<label>Insurance Renewal Date :</label>
<input type="text" id="datepicker" name="visitor_insurance" required="required" placeholder="Please Enter your Car Insurance Renewal Date" value="<?php echo $row['visitor_insurance'];?>" />
<br />
<input type="submit" name="submit value" value="Update">
</form>

<?php
}
?>

<?php

//close the connection
mysqli_close($db);
?>

maxxd

If there are no results in phpMyAdmin, then no data in your database matches the criteria. I should venture a guess that's because there's not a row in table visitors with a 'visitor_id' value in the visitor_id field. You'll probably need to assign an actual integer ID to the variable $visitor_id instead of the string you are currently assigning to it.

dalecosp

I assume this:

$db = mysqli_connect("" , "", "") or die("Check connection parameters!");  

// Optionally skip select_db and use: mysqli_connect(host,user,pass,dbname)   

mysqli_select_db($db,"") or die(mysqli_error($db));

is just you obfuscating your personal details?

Is the script going ahead past this point?

$query = mysqli_query($db, $sql) or die (mysqli_error($db));

I just ran the query directly in the phpmyadmin and returned no results so would explain the form being empty

I suppose it would! Do you actually expect it to return data? It's pretty hard to test DB stuff without data ... perhaps you should insert some? 😉

ianhaney

Within the visitor_id is a number for the visitor whose data is stored within the database

sorry yeah is me dalecosp I just removed the personal info

as far as I know it is going past

$query = mysqli_query($db, $sql) or die (mysqli_error($db));

Is there a way to check to see if it is?

yeah am expecting it to return some data as there is data within the database

maxxd

ianhaney;11048717 wrote:
Within the visitor_id is a number for the visitor whose data is stored within the database

So, the line $visitor_id = 'visitor_id'; - is this just dummied out because typing $visitor_id = $GET['visitor_id']; or $visitor_id = $POST['visitor_id']; is too dangerous? Or are you actually assigning the string 'visitor_id' to the variable $visitor_id? Try echoing the variable before you run the query and see what it contains.

ianhaney

I have dumped the variable before the query and it outputs the following

string(2) "14"

that id of 14 is from the users table when the user signs up, so am thinking I might need to do a JOIN the users table in? i'm not 100% sure as just taking a guess on that

maxxd

So $visitor_id contains the user id? Is there a record in the visitor table with an id of 14, and if so, does that id correspond with the user that has the id 14?

dalecosp

If the query in PHPMyAdmin still returns nothing, you need to analyze your query. It could be that INNER JOIN is too restrictive, and you really don't have any data that matches your query.

ianhaney

yeah visitor_id is containing the user_id of 14

no there is no record within the visitors table with a id of 14

I think the site is getting confused, in the users table is a record of 14 when the user(me) signed up and when I went to the second form, it's storing the data from the second form with a visitor_id record of 75

so I think I need the user_id of 14 to correspond with the visitor_id of 75 within the database tables but am not 100% sure on how to do that?

maxxd

ianhaney;11048727 wrote:
yeah visitor_id is containing the user_id of 14

OK, but are users and visitors interchangeable? If so, why do you need both?

ianhaney;11048727 wrote:
no there is no record within the visitors table with a id of 14

Well that certainly explains why your form isn't populating...

ianhaney;11048727 wrote:
I think the site is getting confused, in the users table is a record of 14 when the user(me) signed up and when I went to the second form, it's storing the data from the second form with a visitor_id record of 75
so I think I need the user_id of 14 to correspond with the visitor_id of 75 within the database tables but am not 100% sure on how to do that?

I'm not trying to be an ass or anything, but I don't think it's the site that's getting confused. If you're creating a user profile edit page, why do you need the visitor id at all? Even if it's not set up that only an authenticated user can edit their own profile, only an authenticated user should be able to edit anyone's profile (but specifically, only their own). So, you've got users, not visitors. I'm not really sure why the visitor table is here in the first place. How different are the visitor and user tables?

ianhaney

na your ok I think I am the one being the ass and getting confused lol

I am trying to simplyfy it and make the register form have all the other info as well such as address, phone numbers etc. I have done it but no data is being added

my code is at the following pastebin link

http://pastebin.com/sfEWBkG9

Below is my database structure for each table

users
-- phpMyAdmin SQL Dump
-- version 4.0.7

-- http://www.phpmyadmin.net

-- Host: localhost
-- Generation Time: Jun 30, 2015 at 06:52 PM
-- Server version: 5.5.42
-- PHP Version: 5.3.28

SET SQL_MODE = "NO_AUTO_VALUE_ON_ZERO";
SET time_zone = "+00:00";

/!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT /;
/!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS /;
/!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION /;
/!40101 SET NAMES utf8 /;

-- Database: `databasename`

-- Table structure for table `users`

CREATE TABLE IF NOT EXISTS users (
id int(11) NOT NULL AUTO_INCREMENT,
username varchar(255) NOT NULL,
password varchar(255) NOT NULL,
name varchar(255) NOT NULL,
email varchar(255) NOT NULL,
address1 varchar(250) NOT NULL,
address2 varchar(250) NOT NULL,
town varchar(250) NOT NULL,
county varchar(250) NOT NULL,
postcode varchar(250) NOT NULL,
telnumber varchar(255) NOT NULL,
mobnumber varchar(255) NOT NULL,
model varchar(255) NOT NULL,
numplate varchar(255) NOT NULL,
status int(11) NOT NULL,
PRIMARY KEY (id),
UNIQUE KEY username (username),
UNIQUE KEY email (email)
) ENGINE=InnoDB DEFAULT CHARSET=latin1 AUTO_INCREMENT=15 ;

/!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT /;
/!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS /;
/!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION /;

renewal
-- phpMyAdmin SQL Dump
-- version 4.0.7

-- http://www.phpmyadmin.net

-- Host: localhost
-- Generation Time: Jun 30, 2015 at 06:53 PM
-- Server version: 5.5.42
-- PHP Version: 5.3.28

SET SQL_MODE = "NO_AUTO_VALUE_ON_ZERO";
SET time_zone = "+00:00";

-- Database: `databasename`

-- Table structure for table `renewal`

CREATE TABLE IF NOT EXISTS renewal (
renewal_id int(11) NOT NULL AUTO_INCREMENT,
id int(11) NOT NULL,
item_id int(11) NOT NULL,
renewal_date date NOT NULL,
date_notified datetime DEFAULT NULL,
PRIMARY KEY (renewal_id),
KEY renewal_id (renewal_id),
KEY renewal_id_2 (renewal_id)
) ENGINE=InnoDB DEFAULT CHARSET=latin1 AUTO_INCREMENT=181 ;

/!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT /;
/!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS /;
/!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION /;

Can't work why the data is not being added?

maxxd

You don't have a table 'visitor'?

ianhaney

Sorry have got it all sorted now

dalecosp

Please use the "Thread Tools" at the top right of your original post to "Mark Thread Resolved" ... thanks!