[RESOLVED] more efficient code

[jeepin81]

Hello All...

I am trying to figure out a way to write the following code in a more efficient manner... I am familiar with FOR() loops but I get confused on how to make this more efficient when the numbers tick up and elements change. Would this be something that is done recursively or would I add an incrementing counter?

  var selCheck = selectedCheck;
  if(selCheck == 'changeCC1'){
    $('#changeCC1').prop('checked', true);
    $('#changeCC2').prop('checked', false);
    $('#changeCC3').prop('checked', false);
  }

  if(selCheck == 'changeCC2'){
    $('#changeCC1').prop('checked', false);
    $('#changeCC2').prop('checked', true);
    $('#changeCC3').prop('checked', false);
  }

  if(selCheck == 'changeCC3'){
    $('#changeCC1').prop('checked', false);
    $('#changeCC2').prop('checked', false);
    $('#changeCC3').prop('checked', true);
  }

I appreciate any insight.

Thanks,
j

[Bonesnap]

One thing you could do is combine some selectors, but you'd only be saving 3 lines total:

var selCheck = selectedCheck;
  if(selCheck == 'changeCC1'){
    $('#changeCC1').prop('checked', true);
    $('#changeCC2, #changeCC3').prop('checked', false);
  }

  if(selCheck == 'changeCC2'){
    $('#changeCC1, #changeCC3').prop('checked', false);
    $('#changeCC2').prop('checked', true);
  }

  if(selCheck == 'changeCC3'){
    $('#changeCC1, #changeCC2').prop('checked', false);
    $('#changeCC3').prop('checked', true);
  }

Is it "efficient"? I guess so. I don't think it warrants a switch() statement. You could refactor it slightly so it's in an if-else if-else pattern. As it stands now if the first condition is true, it will still check the second two if statements. There may be more "clever" ways to do it, but I think it's pretty straightforward as it is and I think trying to change it would inevitably make it harder to read and maintain later.

Just curious though... are these radio buttons? Because this sort of functionality is native in HTML.

[Derokorian]

Does this code run often? If so you could declare variables outside the scope and set them to the result of the selectors. Then each time the code runs you don't have to run the selector again.

[Weedpacket]

for(idx = 1; idx <= 3; ++idx) {
    $('#changeCC'+idx).prop('checked', selCheck == 'changeCC'+idx);
}

[jeepin81]

Thanks for the replies... I completely spaced on using radio buttons.

@ - that works great but I am curious how does that code know how to mark the non-selected checkboxes as false?

[Bonesnap]

jeepin81;11049065 wrote:

@ - that works great but I am curious how does that code know how to mark the non-selected checkboxes as false?

The second argument in .prop() is actually a conditional. Notice the double equals. If the comparison is true, then it returns true, otherwise it returns false.

[jeepin81]

aah! I see. Thanks for the clarifying that. I will mark this thread resolved.