Why Redirect page code doesn't work !?

[JohnJeans]

Hello everyone
Why in this PHP code !? the last redirect line: header ('Location: get_ebooks_form_M.php');
Doesn't work and redirect the user to new PHP page !?

if(empty($errors))
{ //send the email
$to = $your_email;
$subject="New form submission";
$from = $your_email;
$ip = isset($SERVER['REMOTE_ADDR']) ? $SERVER['REMOTE_ADDR'] : '';

	$body = "A user  $name submitted the contact form:\n".
	"Name: $name\n".
	"Email: $visitor_email \n".
	"Gender:$Gender \n ".
	"IP: $ip\n";	

	$headers = "From: $from \r\n";
	$headers .= "Reply-To: $visitor_email \r\n";

	mail($to, $subject, $body,$headers);

	header ('Location: get_ebooks_form_M.php');
}

and the "action" on the actual page is:
<form method="POST" name="get_ebook_form_M" action="<?php echo htmlentities($_SERVER['PHP_SELF']); ?>">

Thank you in advance for your help.!?

[dalecosp]

Does it send the email? The header call is inside the error-checking conditional 😉

Also, it probably shouldn't matter, but the spec for a location header (302) specifies a fully-qualified URL:

header("Location: http://mysite.com/get_ebook_form_M.php");

[sneakyimp]

Also, have you output any text to the browser by the time [man]header[/man] gets called? If so, then it won't work. You have to send all your headers BEFORE you send any text (even an empty space) to the browser.

[JohnJeans]

dalecosp;11049479 wrote:

Does it send the email? The header call is inside the error-checking conditional 😉

Also, it probably shouldn't matter, but the spec for a location header (302) specifies a fully-qualified URL:

header("Location: http://mysite.com/get_ebook_form_M.php");

Dear dalecosp, It didn't work! I tried it before to put the whole URL but it didn't work!!!

Even I copied and paste your line! and tried it but it didn't work as well!!

[laserlight]

JohnJeans wrote:

Dear dalecosp, It didn't work! I tried it before to put the whole URL but it didn't work!!!

Even I copied and paste your line! and tried it but it didn't work as well!!

How does it not work? For example, is there an error message? Is there output? Just saying "it didn't work" is not helpful. There is no need to have so many exclamation marks either: it indicates that you are probably in a panic, and that's likely to make it harder for you to debug your script. Rather, calm down and examine what worked and what could have went wrong.

By the way, you should also exit immediately after sending the location header, e.g.,

if (empty($errors))
{
    //send the email
    $to = $your_email;
    $subject = "New form submission";
    $from = $your_email;
    $ip = isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : '';

$body = "A user $name submitted the contact form:\n" .
        "Name: $name\n" .
        "Email: $visitor_email\n" .
        "Gender:$Gender\n" .
        "IP: $ip\n";

$headers = "From: $from \r\n";
$headers .= "Reply-To: $visitor_email \r\n";

mail($to, $subject, $body,$headers);

header('Location: http://mysite.com/get_ebook_form_M.php');
exit;
}

[JohnJeans]

sneakyimp;11049493 wrote:

Also, have you output any text to the browser by the time [man]header[/man] gets called? If so, then it won't work. You have to send all your headers BEFORE you send any text (even an empty space) to the browser.

Dear sneakyimp; I don't know what you mean by sending text to the browser!?
Here is the link try it yourself:
http://www.0101bay.com/get_ebooks_form_M.php

Suppose that the user after submitting the form without error ( leaving any text empty or the captcha didn't match! ) the browser should redirect the actual page to thank you page:
get_ebooks_form_W_p.php ( and NOT get_ebboks_form_M.php as I stated in my thread mistakenly )

[JohnJeans]

So guys, my actual code is:

 if(empty($errors))
{	//send the email
	$to = $your_email;
	$subject="New form submission";
	$from = $your_email;
	$ip = isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : '';

	$body = "A user  $name submitted the contact form:\n".
	"Name: $name\n".
	"Email: $visitor_email \n".
	"Gender:$Gender \n ".
	"IP: $ip\n";	

	$headers = "From: $from \r\n";
	$headers .= "Reply-To: $visitor_email \r\n";

	mail($to, $subject, $body,$headers);

	header("Location: http://www.0101bay.com/get_ebooks_form_W_p.php");
}

The brwser don't redirect the user to "get_ebooks_form_W_p.php" page!

it stays on the form page "http://www.0101bay.com/get_ebooks_form_M.php !!!!!

[laserlight]

JohnJeans wrote:

The brwser don't redirect the user to "get_ebooks_form_W_p.php" page!

it stays on the form page "http://www.0101bay.com/get_ebooks_form_M.php !!!!!

Change your code to:

if (empty($errors))
{
    //send the email
    $to = $your_email;
    $subject = 'New form submission';
    $from = $your_email;
    $ip = isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : '';

$body = "A user $name submitted the contact form:\n" .
        "Name: $name\n" .
        "Email: $visitor_email\n" .
        "Gender:$Gender\n" .
        "IP: $ip\n";

$headers = "From: $from\r\n";
$headers .= "Reply-To: $visitor_email\r\n";

mail($to, $subject, $body, $headers);

header('Location: http://www.0101bay.com/get_ebooks_form_W_p.php');
exit;
}

Is there any difference? If not, before the //send the email comment, add:

echo 'Reached sending of email';

If that text is not printed, then perhaps your problem is that $errors isn't actually empty.

[JohnJeans]

laserlight;11049503 wrote:

How does it not work? For example, is there an error message? Is there output? Just saying "it didn't work" is not helpful. There is no need to have so many exclamation marks either: it indicates that you are probably in a panic, and that's likely to make it harder for you to debug your script. Rather, calm down and examine what worked and what could have went wrong.

By the way, you should also exit immediately after sending the location header, e.g.,

if (empty($errors))
{
    //send the email
    $to = $your_email;
    $subject = "New form submission";
    $from = $your_email;
    $ip = isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : '';

$body = "A user $name submitted the contact form:\n" .
        "Name: $name\n" .
        "Email: $visitor_email\n" .
        "Gender:$Gender\n" .
        "IP: $ip\n";

$headers = "From: $from \r\n";
$headers .= "Reply-To: $visitor_email \r\n";

mail($to, $subject, $body,$headers);

header('Location: http://mysite.com/get_ebook_form_M.php');
exit;
}

Dear laserlight, I already put "exit;"
at the end but it gives blank page !

[JohnJeans]

Guys, if someone of you wants to try the form! don't go to my website and click on "get a free ebook" on top right corner !!
Because that's will use the old version of the form..( get_ebooks_form.php !) !! instead use this link:

http://www.0101bay.com/get_ebooks_form_M.php

Thank you all guys.!!

[laserlight]

JohnJeans wrote:

Dear laserlight, I already put "exit;"
at the end but it gives blank page !

I tried your current form and it does not give a "blank page".

I suggest that you create a file named test_redirect.php, with the following code, and only the following code:

<?php
header('Location: http://www.0101bay.com/get_ebooks_form_W_p.php');
exit;

Visit test_redirect.php. Do you get redirected as expected?

[JohnJeans]

laserlight;11049511 wrote:

Change your code to:

if (empty($errors))
{
    //send the email
    $to = $your_email;
    $subject = 'New form submission';
    $from = $your_email;
    $ip = isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : '';

$body = "A user $name submitted the contact form:\n" .
        "Name: $name\n" .
        "Email: $visitor_email\n" .
        "Gender:$Gender\n" .
        "IP: $ip\n";

$headers = "From: $from\r\n";
$headers .= "Reply-To: $visitor_email\r\n";

mail($to, $subject, $body, $headers);

header('Location: http://www.0101bay.com/get_ebooks_form_W_p.php');
exit;
}

Is there any difference? If not, before the //send the email comment, add:

echo 'Reached sending of email';

If that text is not printed, then perhaps your problem is that $errors isn't actually empty.

I put exit; at the end and "Reached sending of email"
Here is my current code:

      if(empty($errors))
{   echo 'Reached sending of email'; 
	//send the email
	$to = $your_email;
	$subject="New form submission";
	$from = $your_email;
	$ip = isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : '';

	$body = "A user  $name submitted the contact form:\n".
	"Name: $name\n".
	"Email: $visitor_email \n".
	"Gender:$Gender \n ".
	"IP: $ip\n";	

	$headers = "From: $from \r\n";
	$headers .= "Reply-To: $visitor_email \r\n";

	mail($to, $subject, $body,$headers);

	header("Location: http://www.0101bay.com/get_ebooks_form_W_p.php");
	exit;
}

  You can try it:
          [url]http://www.0101bay.com/get_ebooks_form_M.php[/url]

[laserlight]

I see 'Reached sending of email', which indicates that the location header should have been sent. Have you tried the simple test script I suggested in post #11?

[JohnJeans]

laserlight;11049521 wrote:

I see 'Reached sending of email', which indicates that the location header should have been sent. Have you tried the simple test script I suggested in post #11?

I've creted this:
http://www.0101bay.com/test_redirect.php
Try it'
It gives blank!
and inside this test page is the code:
<body>
<?php
header('Location: http://www.0101bay.com/get_ebooks_form_W_p.php');
exit;
?>
</body>
</html>

[laserlight]

It looks like somehow the location header has no effect. I have not encountered this, but my guess would be that you have some kind of webserver or PHP configuration problem, or your webhost is deliberately preventing you from sending location headers via PHP for some inexplicable reason.

EDIT:
When I said "only the following code", I meant it. That is, no "<body>" tags. Nothing else. No blank lines before the "<?php" either. This is to ensure that you do not end up with an error that is misinterpreted as "the location header has no effect". It might not matter if there is output buffering, but this is a precaution.

If you followed by instructions to the letter, there would still be one possibility to eliminate, i.e., a Unicode byte order mark, but if you have this problem I would have expected it to have resulted in a different output for your get_ebooks_form_M.php script.

[JohnJeans]

laserlight;11049525 wrote:

It looks like somehow the location header has no effect. I have not encountered this, but my guess would be that you have some kind of webserver or PHP configuration problem, or your webhost is deliberately preventing you from sending location headers via PHP for some inexplicable reason.

Dear laserlight, I really appreciate your efforts !!! and I thank you a lot.!!!

[dalecosp]

Please read the EDIT he made to his post. You're missing his point.

[dalecosp]

Incidentally, it appears we're talking to an nginx server instead of Apache.

[laserlight]

You really should set up a local development environment in which you have display_errors set to 1 and error_reporting set to at least E_ALL in php.ini

If not, you should check the error log on the server, but that might not be available to you, and error_reporting will probably be set to a lower level.

[sneakyimp]

I just visited this page:
http://www.0101bay.com/test_redirect.php

It appears to be a blank page, but if you look at the HTML source, you see this:

<!DOCTYPE html>
<html lang="en">

<head>
<title>Get our free eBook</title>

</head>

<body>

It seems pretty clear to me that you did not create the script that laserlight suggested OR perhaps (and this is much less likely) your server is configured to automatically include/execute other PHP files. Like maybe one of these:
http://php.net/manual/en/ini.core.php#ini.auto-prepend-file
http://php.net/manual/en/ini.core.php#ini.auto-append-file

As I said in my post

sneakyimp wrote:

You have to send all your headers BEFORE you send any text (even an empty space) to the browser.

By "send text to the browser" I mean anything you [man]echo[/man] or [man]print[/man] or [man]print_r[/man] or [man]var_dump[/man] OR anythign in your script that occurs outside the <?php and ?> tags. For example, if you have anything in your file that comes before the <?php tag, that would be OUTPUT from your script.