File upload script not working. PLZ help!!

Paul_help_

Hi guys.

I am having problems getting the below script to work:

if ( isset( $_POST["sendPhoto"] ) ) {
processForm();
} else {
displayForm();
}


function processForm() {
if ( isset( $_FILES["photo"] ) and $_FILES["photo"]["error"] ==
UPLOAD_ERR_OK ) {
if ( $_FILES["photo"]["type"] != "image/jpeg" ) {
echo "<p>JPEG photos only, thanks!</p>";
} elseif ( !move_uploaded_file( $_FILES["photo"]["tmp_name"],
"photos/" . basename( $_FILES["photo"]["name"] ) ) ) {
echo "<p>Sorry, there was a problem uploading that photo.</p>" .
$_FILES["photo"]["error"] ;
} else {
displayThanks();
}
} else {
switch( $_FILES["photo"]["error"] ) {
case UPLOAD_ERR_INI_SIZE:
$message = "The photo is larger than the server allows.";
break;
case UPLOAD_ERR_FORM_SIZE:
$message = "The photo is larger than the script allows.";
break;
case UPLOAD_ERR_NO_FILE:
$message = "No file was uploaded. Make sure you choose a file to
upload.";
break;
default:
$message = "Please contact your server administrator for help.";
}
echo "<p>Sorry, there was a problem uploading that photo. $message</p>";
}
}




function displayForm() {
?>
<h1>Uploading a Photo</h1>
<p>Please enter your name and choose a photo to upload, then click
Send Photo.</p>
<form action="photo_upload.php" method="post" enctype="multipart/
form-data">
<div style="width: 30em;">
<input type="hidden" name="MAX_FILE_SIZE" value="50000" />
<label for="visitorName">Your name</label>
<input type="text" name="visitorName" id="visitorName" value="" />
<label for="photo">Your photo</label>
<input type="file" name="photo" id="photo" value="" />
<div style="clear: both;">
<input type="submit" name="sendPhoto" value="Send Photo" />
</div>
</div>
</form>
<?php
}


function displayThanks() {
?>
<h1>Thank You</h1>
<p>Thanks for uploading your photo<?php if ( $_POST["visitorName"] )
echo ", " . $_POST["visitorName"] ?>!</p>
<p>Here’s your photo:</p>
<p><img src="photos/<?php echo $_FILES["photo"]["name"] ?>" alt="Photo"
/></p>
<?php
}

The above code is supposed to allow the user to browse for an image file, select it and click the send button. Basically, I keep getting the following error message when i click the 'send photo' button:

Notice: Undefined index: photo in C:\wamp\www\phpsite1\php forms\5 photo upload\photo_upload.php on line 50

In the book i am reading, after typing up the above code, it states:

Next, create a photos folder in the same folder on your Web server (the document root). This folder is
to store the uploaded photos. You’ll need to give your Web server user the ability to create files in this
folder. On Linux or Mac OS X you can do this in a Terminal window as follows:

cd /path/to/document/root
chmod 777 photos

On Windows you can use Windows Explorer to set permissions on the photos folder.
Now try running the script in your browser. You should see the form shown in Figure 9-10. Enter your
name and choose a JPEG photo to upload, then click Send Photo. You should see a thank-you message
appear along with your uploaded photo.

Basically, I just created a folder named 'photos' on my local host, on my laptop. Is this where I am going wrong? Will the above script only work on the remote host?

And if so, I have no idea what the above quote from my book actually means. especially this?:

cd /path/to/document/root
chmod 777 photos

Paul.

Weedpacket

Do you have a file field in your form named "photo"?

Paul_help_

yeah. its in the code above:

<input type="file" name="photo" id="photo" value="" />

... i don't understand what you mean though?

Paul.

Paul_help_

Can anyone help me with this? Its driving me crazy! lol.

To be honest, the code above was copied and pasted from the book i am reading.

I never typed it by hand.

I don't know whether this is why it isn't working properly, or if the file needs to be run on a remote host, rather than the local one.

I can't figure it out.

Paul.

dalecosp

Try adding these lines to the top of your script, and report back with any new information:

<?php
error_reporting(E_ALL);
ini_set("display_errors",1);

//rest of your script below

Paul_help_

Hi.

I did what you said and I still get the same error:

Notice: Undefined index: photo in C:\wamp\www\phpsite1\php forms\5 photo upload\photo_upload.php on line 54

Paul.

Paul_help_

This is why I am wondering, if this file needs to be uploaded to a remote host in order to work?

schwim

Can you tell us what line 54 is in your code? Clearly it isn't what the first post would lead us to believe.

Paul_help_

this line:

switch( $_FILES["photo"]["error"] ) {

Paul_help_

If you saved this code (given at the top of the page) and then executed it on your own computer, it might help u understand better.

Paul.

sneakyimp

Paul help!;11050047 wrote:
If you saved this code (given at the top of the page) and then executed it on your own computer, it might help u understand better.

You shouldn't expect people to always download and execute your code. You'll have a lot more success if you can provide more detail to people about the exact error that's happening.

Your error clearly says what your problem is:

Notice: Undefined index: photo in C:\wamp\www\phpsite1\php forms\5 photo upload\photo_upload.php on line 54

Your code refers to an array index "photo" on line 54 that does not exist.

You could examing your $FILES variable by temporarily putting this line right before that line:

var_dump($_FILES);

What you will probably see is that the $FILES array does not have any member element $FILES["photo"]

$_FILES is often not properly defined if you fail to set the correct encoding on your form. It looks to me like your form tag is broken:

<form action="photo_upload.php" method="post" enctype="multipart/
form-data">

there is a new line char in your code between "multipart/" and "form-data" -- that newline char probably has the effect that you are specifying an invalid coding type.

Paul_help_

Thanks sneakyimp.

Its working!

But there is just one little thing I don't understand in this code.

In the processForm() function, we have the following line (inside the inner IF statement:

echo "Sorry, there was a problem uploading that photo." . $_FILES["photo"]["error"] ;

I do not understand why:

$_FILES["photo"]["error"]

.... is concatonated at the end?

Paul.

Paul_help_

And another thing i wanted to ask was - Inside the displayThanks() function, we have the line:

Here’s your photo:
<img src="photos/<?php echo $_FILES["photo"]["name"] ?>" alt="Photo"/>

Obviously, this displays the uploaded photo. But in the below line:

src="photos/<?php echo $_FILES["photo"]["name"] ?>"

.... the src attribute references the image file, inside the photos folder with:

$_FILES["photo"]["name"]

... and there is no document type extension (such as .jpg).

So I am just wondering, does ["name"] hold the file type extension (e.g - jpeg ) aswell as the name of the file?

For example (the whole thing): mypicture.jpg

Paul.

sneakyimp

Paul help!;11050071 wrote:
Thanks sneakyimp.
In the processForm() function, we have the following line (inside the inner IF statement:

.... is concatonated at the end?
Paul.

You should read about PHP File Uploads and a lot of this will be much clearer. The basic idea, if I recall correctly, is that PHP will generate a file-by-file error message if any of the uploaded files result in an error. Here's a list of PHP error messages for file uploads.

sneakyimp

Paul help!;11050073 wrote:
And another thing i wanted to ask was - Inside the displayThanks() function, we have the line:
Obviously, this displays the uploaded photo. But in the below line:

I wonder if that code is always going to work. You should read about PHP File Uploads.

You should also look closely at this line, which moves the uploaded photo to the photos directory:

} elseif ( !move_uploaded_file( $_FILES["photo"]["tmp_name"],
"photos/" . basename( $_FILES["photo"]["name"] ) ) ) {

You should see right there that the destination filename for [man]move_uploaded_file[/man] doesn't have any extension added either.

You should also know that you should never just take an uploaded file and stick it in your web root. I could upload a virus, or a PHP file that lets me inspect your source code and download all your passwords. You should be very careful with uploaded files and be sure to:
make damn sure the uploaded file contents are the type of file you want
never, ever trust the original file name.

Paul_help_

Thank you for this.

I don't know where I would be if it wasn't for the helpful folks on this website.

Your life savers!