Loop within a loop?

[jarv]

Hi,

I have 2 tables of data REVIEWS and RATINGS

I would like to show a list of my reviews and a list of rating for each of my reviews

I have tried putting my second WHILE loop inside teh first one but that doesn't work, can anyone please help?

here is my code:

$SQL = "SELECT
                        *
                    FROM
                        school_reviews
                    WHERE
                        active = 1
                        AND is_deleted = 0
                        AND school_id = '" . $school_id . "'
                        ORDER BY
                        review_date DESC";
    $q->query($DB,$SQL);


while($review = $q->getrow()):
    $reviewid = $review['review_id'];
    echo $reviewid;
    echo '<h3>'.$review['review'].'</h3>';


endwhile;

echo '<ul>';
$SQL = "SELECT
                *
            FROM
                ratings
            WHERE
                review_id = '".$reviewid."'";
$q->query($DB,$SQL);
while($rating = $q->getrow()):
    echo '<li>'.$rating['rating_name'].': '.$rating['rating'].'</li>';
endwhile;
echo '</ul>';

here is an example of the review I get:

ReviewID: 46
Review: testing the reviews
ReviewID: 43
Review: Because I know John is sooo handsome and he works at Cactus
ReviewID: 40
Review: iuhi

Ratings:
Course / Course content: 5
Teacher: 5
Social Programme: 5
School Facilities: 5
Atmosphere: 5
Location: 5
Accommodation: 4
Service from Cactus: 2
Value for money: 3
Overall Experience: 5

[Weedpacket]

Because you go through the entire result set but only keep the last [font=monospace]$reviewid[/font] for the second query.

All the information can be retrieved with one query (and one loop).

SELECT
	review, review_id, rating_name, rating
FROM
	school_reviews JOIN ratings
		ON school_reviews.review_id = reviews.review_id
WHERE
	active=1
	AND is_deleted=0
	AND school_id = ?
ORDER BY review_date DESC, review_id, rating_name

(Adding "ORDER BY rating_name" so that they're in the same order for each review).

Then go through that row by row. To avoid having every rating of every review ending up in its own list, there are at least two approaches:

1. Remember what the review ID of the previous row was (for the first row this would be null). Before printing the current row, look to see if its review_id is different from the previous one. If it is, then this is the first rating of a new review and new heading and stuff is needed.

2. Do two loops, one after the other. The first loop goes through the result set and builds an array of reviews; the contents of each element of the array would be the review and an array of rating/rating_name pairs (the latter probably being an associative array keyed by rating_name). The second loop goes through this array, and prints a heading for each review and a list of the rating/rating_name pairs

[sneakyimp]

You don't have a loop within a loop, you have a loop and then another loop after that. This is a nested loop:

$i=0;
while ($i<10) {
    echo "this is the outer loop, i=$i\n";
    $i++;

$j=0;
while($j < 10) {
    echo "\tthis is the inner loop, j=$j\n";
    $j++;
}
}