PHP nested loops

starrwell82

Hi,

I'm looking for a little help. I need to do a nested loop that does this

shows the Housekeeper name
then shows any records with that name and loop in tell all the records for that name are done
then go to the next name and do the same thing
Here is the code I have

mysql_select_db($database_hk, $hk);
$query_Recordset1 = "SELECT * FROM room_problems ORDER BY Housekeeper_name";
$Recordset1 = mysql_query($query_Recordset1, $hk) or die(mysql_error());
$row_Recordset1 = mysql_fetch_assoc($Recordset1);
$totalRows_Recordset1 = mysql_num_rows($Recordset1)

;


<?php do { ?>
  <table width="80%" border="0">
    <tbody>
      <tr>
        <th width="21%" align="left" valign="middle" scope="col"><?php echo $row_Recordset1['Housekeeper_name']; ?> <?php echo $row_Recordset1['Date']; ?></th>
        <th width="79%" align="left" valign="middle" scope="col">&nbsp;</th>
      </tr>
    </tbody>
  </table>

  <table width="80%" border="0">
    <tbody>
      <tr>
        <th width="17%" align="left" valign="middle" scope="col"><?php echo $row_Recordset1['Room']; ?><?php echo $row_Recordset1['Room_Type']; ?></th>
        <th width="83%" align="left" valign="middle" scope="col">&nbsp;</th>
      </tr>
      <tr>
        <td colspan="2" align="left" valign="middle"><?php echo $row_Recordset1['Room_problems']; ?></td>
      </tr>
    </tbody>
  </table>
  <?php } while ($row_Recordset1 = mysql_fetch_assoc($Recordset1)); ?>

Thanks for any help

dalecosp

Hello, and welcome to PHPBuilder!

Before I start ... there's a bit of antique-looking stuff here. What's your PHP Version? Have you heard of mysqli (note the "i"), which is the preferred interface to MySQL from PHP and has been since, oh, about 2005? 🙂

Next ... what's WRONG with your code, from YOUR point of view? Does it do anything at all? What doesn't work? There's not much description of your actual problem here.

At any rate, I've gone through and made some comments in your code ... perhaps this will get you thinking and you'll discover whatever your issue is.

Best of luck! 🙂

<?php
mysql_select_db($database_hk, $hk); // I assume you have a mysql_connect() call before this somewhere?
// Do you check to see if this select call was successful? ;)

$query_Recordset1 = "SELECT * FROM room_problems ORDER BY Housekeeper_name";

$Recordset1 = mysql_query($query_Recordset1, $hk) or die(mysql_error());

$row_Recordset1 = mysql_fetch_assoc($Recordset1); // you're calling this again below ... why did you do it here?

$totalRows_Recordset1 = mysql_num_rows($Recordset1);  // why did you do this?  Are you, maybe, trying to make sure you actually got rows? 
    // Good idea.  How come there's no test then to see what this value is before you start the loop below?

 do { ?>
  <table width="80%" border="0">
    <tbody>
      <tr>
        <th width="21%" align="left" valign="middle" scope="col"><?php echo $row_Recordset1['Housekeeper_name']; ?> <?php echo $row_Recordset1['Date']; ?></th>
        <th width="79%" align="left" valign="middle" scope="col">&nbsp;</th>
      </tr>
    </tbody>
  </table>

  <table width="80%" border="0">
    <tbody>
      <tr>
        <th width="17%" align="left" valign="middle" scope="col"><?php echo $row_Recordset1['Room']; ?><?php echo $row_Recordset1['Room_Type']; ?></th>
        <th width="83%" align="left" valign="middle" scope="col">&nbsp;</th>
      </tr>
      <tr>
        <td colspan="2" align="left" valign="middle"><?php echo $row_Recordset1['Room_problems']; ?></td>
      </tr>
    </tbody>
  </table>
  <?php } while ($row_Recordset1 = mysql_fetch_assoc($Recordset1)); ?>

starrwell82

The SQL is set up by Dreamwearver

What I get is this

Housekeeper 1
room problems text 2
Housekeeper 1
Room problems text 2
ect...
Housekeeper 2
room problems text 1
housekeeper 2
room problem text 2
ect...

What I want is
Housekeeper 1
Room Problem text 1
room Problem text 2
ect...
housekeeper 2
room problem 1
room problem 2
ect...

without the Group by I get records in order from the database (and that's not in order by name). So I need it sorted.

dalecosp

OK, then, here's pseudo code:

query_the_database_for_housekeepers_and_store_in_PHP_array();

foreach housekeeper (loop):

   query_the_database_for_room-problems_with_this_housekeeper_assigned_and_store_in_array_keyed_to_housekeeper();

end loop

//OUTPUT TIME

foreach housekeeper
   print housekeeper
   foreach room_problem
      print roomproblem
   end loop
end loop

Now, that's pseudo-code, not PHP (kinda looks a tad like Python, actually, heh heh ...) .

You're talking about DreamWeaver ... you don't know much about PHP then?

starrwell82

So being new to PHP I'd like to ask if you could put that in PHP or is nested loops just something that you can't do in PHP.

Thanks

laserlight

Yes, that can be done in PHP. If it couldn't, dalecosp's pseudocode would be useless.

dalecosp

Well, two things:

I was hoping that you might learn something by doing some of this work yourself.
My employer pays me to turn ideas into working PHP code, and we aren't in the motel business, so I don't think you are him.

I'm not trying to be mean. I have enough Real Work to do that I typically feel like a one-armed paperhanger, my company hasn't paid me a bonus in years (3, maybe?) because our sector of the economy apparently sucks (or else our sales department does), and I've a very busy weekend planned as I head out on vacation.

Perhaps someone with more time will have mercy and write your code for you for free.

Assuming a web browser and supposing you have some arrays, here's the nested loop part translated to valid PHP, even with a little HTML formatting:

foreach ( $housekeeper_array as $housekeeper=>$problems_array ) {

   echo "<h2>Housekeeper: <em>".$housekeeper."</em></h2>";

   foreach ( $problems_array as $problem ) {

  echo "<p>".$problem."</p>";

   } // foreach
} // foreach