filebased sorting problem (html table)

[chrisdee]

The script below lists out all my mp3's in a folder and echo's it into a html table so I can sort after the title headers.

Problem is that I want the default sorting to be alphabetically after filename. But when I try to change the order of the sorting below :

if      ($sort=='name') { usort($dir, "sort_name");     } 
elseif  ($sort=='size') { usort($dir, "sort_size");     } 
else                    { usort($dir, "sort_time");     }

to

if      ($sort=='size') { usort($dir, "sort_size");     } 
elseif  ($sort=='time') { usort($dir, "sort_time");     } 
else                    { usort($dir, "sort_name");     }  

the date sorting doesnt work properly anymore.
What am I doing wrong ?

Below is the full code :

<style type="text/css">
* {
        font-family: Helvetica;
}
a:link { text-decoration:  none; }
table.b {
        border-radius: 0px 20px 20px 0px;
        background: linear-gradient(to right,white,lightblue,white);
        padding: 3px;
        box-shadow: gray 5px -5px 15px;
        border: dotted 2px;
}
td.c {
        border-radius: 0px 20px 20px 0px;
        background: linear-gradient(to right,lightblue,white,lightblue);
}
.glow {
        text-decoration: underline;
        color: white;
        font-weight: bold;
        text-shadow: 0px 0px 5px lime, 0px 0px 10px orange;
}
</style>

<?php 
// Variables 
$dir    = glob("*.mp3"); 
$sort   = $_GET['sort']; 

// Functions for sorting each table column title 
function sort_name($a,$b) { return $a > $b;                             } 
function sort_time($a,$b) { return filemtime($b) - filemtime($a);       } 
function sort_size($a,$b) { return filesize($a) < filesize($b);         } 

// Checks wich table column title is selected 
if      ($sort=='size') { usort($dir, "sort_size");     } 
elseif  ($sort=='time') { usort($dir, "sort_time");     } 
else                    { usort($dir, "sort_name");     } 

// Table 
echo "<table class=b>"; 
echo "<tr>"; 
$titles = array('nr','name','size','date'); 
foreach($titles as $title) { 
        if      ($title==$sort) { echo "<td>&nbsp;<a href=$_SERVER[PHP_SELF]?sort=$title>".ucfirst($title)."</a>&nbsp;</td>"; } 
        elseif  ($title=='nr')  { echo "<td class=glow><a href=./>&nbsp;<span class=glow>".ucfirst($title)."</span></a>&nbsp;</td>"; } 
        else                    { echo "<td>&nbsp;<a href=$_SERVER[PHP_SELF]?sort=$title>".ucfirst($title)."</a>&nbsp;</td>"; } 
} 
echo "</tr>"; 

// Table content 
for($i=0; $i<count($dir); $i++) { 
        echo "<tr>"; 
        echo "<td>&nbsp;" . $i . "&nbsp;</td>"; 
        echo "<td>&nbsp;<a href=" . rawurldecode($dir[$i]) . ">" . $dir[$i] . "</a>&nbsp;</td>"; 
        echo "<td>&nbsp;" . round(filesize($dir[$i])/(1024)/(1024),1) . " MB&nbsp;</td>"; 
        echo "<td>&nbsp;" . date("d.m.Y", filemtime($dir[$i])) . "<sub> - " .date("H:i:s", filemtime($dir[$i])) . "</sub>&nbsp;</td>"; 
        echo "</tr>"; 
} 

echo "</table>"; 
?>

[sneakyimp]

I'll bet the time sorting works just fine, you just don't seem to have anything you can click on the page that'll tell the script you want to sort by time.

[Bonesnap]

Additionally your sorting functions should handle if the variables are equal.

[chrisdee]

I do have that part :

echo "<tr>";  

$titles = array('nr','name','size','date');  

foreach($titles as $title) {  

        if      ($title==$sort) { echo "<td>&nbsp;<a href=$_SERVER[PHP_SELF]?sort=$title>".ucfirst($title)."</a>&nbsp;</td>"; }  

        elseif  ($title=='nr')  { echo "<td class=glow><a href=./>&nbsp;<span class=glow>".ucfirst($title)."</span></a>&nbsp;</td>"; }  

        else                    { echo "<td>&nbsp;<a href=$_SERVER[PHP_SELF]?sort=$title>".ucfirst($title)."</a>&nbsp;</td>"; }  

}  

echo "</tr>"; 

[Weedpacket]

You seem to have provide for sorting by [font=monospace]date[/font], but not [font=monospace]time[/font].

[chrisdee]

I'll check. Thanks

[chrisdee]

Acutally it works now. I cleaned it up a bit, corrected the date / time misstake in the array and removed the sort_name since that was unessesary.

Sorting by name goes fast (like 1 second), but sorting by size and time takes 4-5 seconds. I have 147 files in the folder.
Is there a way to speed things up?

<head><link rel="stylesheet" type="text/css" href="style.css"></head>

<?php
// Variables
$dir    = glob("*.mp3");
$sort   = $_GET['sort'];

// Functions for sorting each table column title
function sort_size($a,$b) { return filesize($a) < filesize($b);         }
function sort_time($a,$b) { return filemtime($b) - filemtime($a);       }

// Checks wich table column title is selected
if      ($sort=='size') { usort($dir, "sort_size");     }
if      ($sort=='time') { usort($dir, "sort_time");     }

// Table titles
echo "<table class=b>";
echo "<tr>";
$titles = array('nr','name','size','time');
foreach($titles as $title) {
        if      ($title==$sort) { echo "<td><a href=$_SERVER[PHP_SELF]?sort=$title>".ucfirst($title)."</a></td>"; }
        elseif  ($title=='nr')  { echo "<td><a href=./>".ucfirst($title)."</a></td>"; }
        else                    { echo "<td><a href=$_SERVER[PHP_SELF]?sort=$title>".ucfirst($title)."</a></td>"; }
}
echo "</tr>";

// Table content
for($i=0; $i<count($dir); $i++) {
        echo "<tr>";
        echo "<td>" . $i . "</td>";
        echo "<td><a href=" . rawurldecode($dir[$i]) . ">" . $dir[$i] . "</a></td>";
        echo "<td>" . round(filesize($dir[$i])/(1024)/(1024),1) . " MB</td>";
        echo "<td>" . date("d.m.Y", filemtime($dir[$i])) . "<sub> - " .date("H:i:s", filemtime($dir[$i])) . "</sub></td>";
        echo "</tr>";
}

echo "</table>";
?>

[Bonesnap]

Where's your name/title sorting function? You had it in your original code but it seems to be missing in the above code.

[Weedpacket]

Four seconds seems like a hideously long time to get the sizes of 147 files....

The results of [man]filemtime[/man] and [man]filesize[/man] ought to be cached, so they should only be getting read once each per file (even though they'd be called three times). But starting off with a call to [man]stat[/man] on each such file might help. I kind of doubt it because of that horribly slow performance already.

Incidentally, if you're not doing any other validation, your code allows someone to retrieve any file on your server.

[chrisdee]

It's for personal use so I havent bothered doing validation yet.

So i tried to use the same script in another directory with only 1kb textfiles (101 files to be excact).
Just to check if the size of the mp3 files has anything to do with the slow sorting.

But sorting is still slow even with the small textfiles. Also as I said befor the server doesn't seem to have any speed problem.
I guess this narrows it down to something with my code??

[chrisdee]

I tried to run the microtime suggestion on the php.net standard glob example (fist example).

<?php
$start = microtime(true);
foreach (glob("*.mp3") as $filename) {
    echo $filename . " " . filesize($filename) .  "<br>";
}
$end = microtime(true);
print "<hr>" . (($end - $start) * 1000) . " ms";
?>

No extra loops or anything. Just regular glob.

With the filesize function I get an average of 290 ms running the simple glob script above.
If I remove the filesize function and just list out the filename I get an average of 95 ms each time I open the page.

Is this concidered slow? If so maby my NAS is the bottleneck?

[chrisdee]

So I have access to another server at work (with Debian installed). When loading the page or performing a sort it feels almost instant.

I ran the microtime test on a directory with about 160 wave files ranging from 10MB to 800MB in size with the excact same script as befor.
Sorting by name averages around 10ms and by size and time 20ms.

I guess my DS213J NAS is just very slow (with name sorting taking 100ms and size/time sorting taking 300ms)🙁

I'll contact Synology asap.

[Bonesnap]

I may be mistaken as I have never used glob() before, but wouldn't the sort be taking place long after the file system has been polled for data? The function returns an array, which is the thing that is being sorted. Is it the glob() portion that is slow or the actual sorting?

[Derokorian]

Bonesnap;11051297 wrote:

I may be mistaken as I have never used glob() before, but wouldn't the sort be taking place long after the file system has been polled for data? The function returns an array, which is the thing that is being sorted. Is it the glob() portion that is slow or the actual sorting?

Glob gets the list of files, but the sorting function is calling filesize or filemtime on average 2+ times per file. One way to improve the speed would be to map these values once FIRST. Also, both functions are called for every file on output as well, filemtime being called twice for every file on output. Something like:

// Get files for sorting and output
$files = [];
foreach(glob($pattern) as $file) {
   $files[] = [
      'path' => $file,
      'size' => filesize($file),
      'mtime' => filemtime($file)
   ];
}

// Sorts
function sort_size($a,$b) { return $a['size'] < $b['size'] ? -1 : ($a['size'] > $b['size'] ? 1 : 0);         }
function sort_time($a,$b) { return $a['mtime'] < $b['mtime'] ? -1 : ($a['mtime'] > $b['mtime'] ? 1 : 0);      }

// output
foreach($files as $file) {
        echo "<tr>";
        echo "<td>" . $i . "</td>";
// Perhaps this urldecode should actually be an encode??
        echo "<td><a href=" . rawurldecode($file['path']) . ">" . $file['path'] . "</a></td>";
        echo "<td>" . round($file['size']/(1024)/(1024),1) . " MB</td>";
        echo "<td>" . date("d.m.Y", $file['mtime']) . "<sub> - " .date("H:i:s", $file['mtime']) . "</sub></td>";
        echo "</tr>";
}

Although stat cache should keep you from having to access disk more than once for each type of op per file, this way also prevents accessing the cache needlessly.

[chrisdee]

Thanks, but when I try to run your example nothing it echo'ed.
What's missing?

[Derokorian]

chrisdee;11051329 wrote:

Thanks, but when I try to run your example nothing it echo'ed.
What's missing?

Well its not complete. I don't ever call any sorting function, I don't define $pattern, and I'm fairly certain there are still more things missing. It was an example meant to illustrate what I meant, not designed to be a working solution however. You'll have to use that logical and deductive reasoning to apply my example to what you're actually trying to do.

[chrisdee]

I've found another example on Stackoverflow that is much faster sorting by either filesize or filemtime (like below).
Any tips on how I make it sortable via table title fields?

<?php
$dir = glob('{*.mp3,wav}', GLOB_BRACE|GLOB_NOSORT);

$dir = array_combine($dir, array_map("filemtime", $dir));
arsort($dir);

echo "<table border=1>";
foreach ($dir as $file => $mtime) {
        echo "<tr>";
        echo "<td><a href=" . $file . ">" . $file . "</a></td>";
        echo "<td>" . round(filesize($file)/1024/1024,1) . " MB</td>";
        echo "<td>" . date("d.m.Y", filemtime($file)) . " - <sub>" . date("H:i:s", filemtime($file))  .  "</sub></td>";
        echo "</tr>";
}
echo "</table>";
?>

[chrisdee]

Ok, I'v tried to incorporte your suggestion into my script but I'm getting errors when I try to sort by size and time. Sorting by name goes ok.

<?php
$start = microtime(true);

// Variables
$dir = glob("*.{mp3,wav}",GLOB_BRACE);
$sort   = $_GET['sort'];

$files = [];
foreach($dir as $file) {
   $files[] = ['path' => $file,'size' => filesize($file),'mtime' => filemtime($file)];
}

function sort_path($a,$b) { return $a['path'] < $b['path'] ? -1 : ($a['path'] > $b['path'] ? 1 : 0);            }
function sort_size($a,$b) { return $a['size'] < $b['size'] ? -1 : ($a['size'] > $b['size'] ? 1 : 0);            }
function sort_time($a,$b) { return $a['mtime'] < $b['mtime'] ? -1 : ($a['mtime'] > $b['mtime'] ? 1 : 0);        }

// Checks wich table column title is selected
if ($sort=='path') { usort($dir, "sort_path");  }
if ($sort=='size') { usort($dir, "sort_size");  }
if ($sort=='time') { usort($dir, "sort_time");  }

// Table titles
echo "<table>";
echo "<tr>";
$titles = array('nr','name','size','time');
foreach($titles as $title) {
        if      ($title==$sort) { echo "<td>&nbsp;<a href=$_SERVER[PHP_SELF]?sort=$title><span class=glow>".ucfirst($title)."</span></a>&nbsp;</td>"; }
        elseif  ($title=='nr')  { echo "<td><a href=./>".ucfirst($title)."</a></td>"; }
        else                    { echo "<td>&nbsp;<a href=$_SERVER[PHP_SELF]?sort=$title>".ucfirst($title)."</a>&nbsp;</td>"; }
}
echo "</tr>";

// Table content
for($i=0; $i<count($dir); $i++) {
        echo "<tr>";
        echo "<td>" . $i . "</td>";
        echo "<td class=a><a href=" . rawurldecode($dir[$i]) . ">" . $dir[$i] . "</a>&nbsp;</td>";
        echo "<td>&nbsp;" . round(filesize($dir[$i])/(1024)/(1024),1) . " <sub>MB</sub>&nbsp</td>";
        echo "<td class=b>&nbsp;" . date("d.m.Y", filemtime($dir[$i])) . "<sub> - " .date("H:i:s", filemtime($dir[$i])) . "</sub>&nbsp;</td>";
        echo "</tr>";
}

echo "</table>";

$end = microtime(true);
print "<br>" . (($end - $start) * 1000);
?>

[chrisdee]

Error message is :

Warning: Illegal string offset 'mtime' in /volume1/web/omert/findex.php on line 17 Warning: Illegal string offset 'mtime' in /volume1/web/omert/findex.php on line 17 Warning: Illegal string offset 'mtime' in /volume1/web/omert/findex.php on line 17 Warning: Illegal string offset 'mtime' in /volume1/web/omert/findex.php on line 17 Warning: Illegal string offset 'mtime' in /volume1/web/omert/findex.php on line 17 Warning: Illegal string offset 'mtime' in /volume1/web/omert/findex.php on line 17 Warning: Illegal string offset 'mtime' in /volume1/web/omert/findex.php on line 17 Warning: Illegal string offset 'mtime' in /volume1/web/omert/findex.php on line 17 Warning: Illegal string offset 'mtime' in /volume1/web/omert/findex.php on line 17 Warning: Illegal string offset 'mtime' in /volume1/web/omert/findex.php on line 17 Warning: Illegal string offset 'mtime'

[Derokorian]

Its because you are passing $dir to the usorts and not $files which is the array you just built with the extra data in it.