[RESOLVED] Problem with dropdown selection values

[masimies]

Hello,
I'm practicing PHP-coding, and creating portal for common repository. I have doing this just about 3-weeks, so i'm not so professional of it, yet.

Now im stuck with dropdown selection. As seen from code below. It query data from table, and get values, but not adding them to correct input fields.
Something is incorrectly coded. Any ideas to make it working?
This portal target is, to functioning without any additional code, like java-scripts. Pure PHP only.

Here is the part of nonworking code:

<?php
include '/csrconn.php';
$query 	= mysql_query("SELECT ProductName, ProductItem, RetailPrice FROM `product` ORDER BY ProductName ASC");
$ProdQuery="SELECT ProductName, ProductItem, RetailPrice FROM product";
$ProdResult=mysql_query($ProdQuery) or die ("Query to get data from firsttable failed: ".mysql_error());
echo "<option>--- Select Product ---></option>";
while ($prodrow=mysql_fetch_array($ProdResult)) {
$ProductName=$prodrow["ProductName"];
$ProductItem=$prodrow["ProductItem"];
$RetailPrice=$prodrow["RetailPrice"];
echo "<option>$ProductName</option>";
}
?>
<tr><td>Product Item:&nbsp;</td><td><input name="ProductItem" type="text" id="ProductItem" value="<?php echo($prodrow['ProductItem']); ?>" id="ProductItem"></td></tr>
<tr><td>Retail Price:&nbsp;</td><td><input name="RetailPrice" type="text" id="RetailPrice" value="<?php echo($prodrow['RetailPrice']); ?>" id="RetailPrice"></td></tr>
<tr><td>Offer ID:&nbsp;</td><td><input name="OfferID" type="text" id="OfferID" autofocus="autofocus"></td></tr>
<tr><td>Customer Name:&nbsp;</td><td><input name="CustName" type="text" id="CustName"></td></tr>
<tr><td>Customer Number:&nbsp;</td><td><input name="CustNum" type="text" id="CustNum"></td></tr>
<tr><td>Customer Phone:&nbsp;</td><td><input name="CustPhone" type="text" id="CustPhone"></td></tr>
<tr><td>Customer Email:&nbsp;</td><td><input name="CustEmail" type="text" id="CustEmail"></td></tr>
<tr><td>Provider:&nbsp;</td><td><input name="Provider" type="text" id="Provider"></td></tr>					 
<tr><td>Ordered Amount:&nbsp;</td><td><input name="OrderedAmt" type="text" id="OrderedAmt"></td></tr>
<td>Order Status:&nbsp;</td><td>
<select name="OrderStatus" type="text" id="OrderStatus">
<option value="Processing">Processing</option>}
<option value="Active">Active</option>
<option value="Removed">Removed</option>
</select></td>
<tr><td><input name="add" type="submit" class="more right" id="add"></td></tr>
</table>
</form>
<p>
<?php
}
?>

[dalecosp]

Hello, and welcome to PHPBuilder!

1. Wrapping your code in [noparse]

   [/noparse] tags will help by highlighting your code to give visual feedback to all of us. It also provides a scrollable CODE area which helps organize the page better.

2. The mysql_ functions are deprecated. As of last week, they don't even exist* in the newest release of the language, PHP7. It's fairly trivial to switch to the MySQLI ('improved') interface ... like this:

<?php
// DB connection, provides object '$conn'
$conn = mysqli_connect( "localhost", "user", "passw0rd", "my_database_name" );

// Our SQL query
$sql = "SELECT ProductName, ProductItem, RetailPrice FROM product;";

//The query function expects to be passed the MySQLI object created above:
$result = mysqli_query( $conn, $sql );

// The above live is "procedural style".  The query function may also be called in Object-Oriented fashion, like this:
$result = $conn->query( $sql );

// the fetch functions belong to the $result object:
while ( $row = $result->fetch_array() ) {

  // do something here

}

3. As far as your code goes, there aren't glaring HUGE problems, but here are some minor points. a] You assign $query but never use it. b] Same with $ProductName, $ProductItem, and $RetailPrice.

4. Probably the thing you need to do is test that the query actually returned rows:

if ( !$ProdResult || mysql_num_rows( $ProdResult ) < 1 ) {
   echo "No result, or zero rows returned from query.\n";
   die(); // probably your app should be more eloquent than just "die()", but whatever ...
}

Note that using MySQLI would be:

if ( !$ProdResult || $ProdResult->num_rows < 1 ) {

Hope this is helpful,

[masimies]

Thanks for the reply,
Yeah, i move to MySQLI, as soon i get this working.
Meanwhile, with this problem, i solved it already with very short java-script, what creates better dropdown function. All needed pre values are fetched nicely to input rows. :-)
Yes, life is much easier with better functionality in some places.

br,