not showing data

hissam78

Dear all,
i am new in PHP development somebody can help me to rectify the error in the following code. it is not showing data from mysql. before this code was showing Undefined index error then i used if (isset ($_GET["e_submit"])){ that function. but now it is not showing data

Code:

<html>
<head>
<title>Employee's Data  </title>
</head>

<body>
<form action = "Employee_frm.php" method  = "post">
<table width = "500" border = "5" align  = "center">
<tr>
<td bgcolor = "Yellow" align = "center" colspan = "5"><h1> Employee's Registration </h1></td>
</tr>

<tr>
<td>Employee Name: </td>
<td><input type = "text" name = "e_name"> </td>
</tr>

<tr>
<td>Designation: </td>
<td><input type = "text" name = "Desig_A"> </td>
</tr>

<tr>
<td>Date of Joining: </td>
<td><input type = "text" name = "doj"> </td>
</tr>


<tr>
<td>Date of Birth: </td>
<td><input type = "text" name = "dob"> </td>
</tr>


<tr>
<td>Passport #: </td>
<td><input type = "text" name = "psst"> </td>
</tr>


<tr>
<td>Visa Expiry Date: </td>
<td><input type = "text" name = "vis"> </td>
</tr>


<tr>
<td>Company Name: </td>
<td><input type = "text" name = "Comp"> </td>
</tr>



<tr>
<td>Address: </td>
<td><input type = "text" name = "addrs"> </td>
</tr>



<tr>
<td>City: </td>
<td><input type = "text" name = "cty"> </td>
</tr>



<tr>
<td>Country: </td>
<td><input type = "text" name = "cntry"> </td>
</tr>


<tr>
<td align = "center" colspan = "5"><input type = "submit" name = "e_submit" value = "submit now"> </td>
</tr>




</table>
</form>
<table width = "800" border = "5" align = "center">
<tr>
<th> Emp_no: </th>
<th> Emp_Name: </th>
<th> Designation: </th>
<th> DOJ: </th>
<th> DOB: </th>
<th> Passport #: </th>
<th> Visa Expiry: </th>
<th> Company: </th>
<th> Address: </th>
<th> City: </th>
<th> Country: </th>
<th> Delete: </th>
<th> Edit: </th>
</tr>

<?php
if (isset ($_GET["e_submit"])){
mysql_connect("localhost","root", "");
mysql_select_db("construction");

$query1 = "select * from employee";
$run = mysql_query($query1);


while ($row=mysql_fetch_array($run)){
	$ecode = $row['emp_code'];
	$ename1 = $row['emp_name'];
	$desig_d1 = $row['desig_d'];
	$doj_d1 = $row['doj'];
	$dob_d1 = $row['dob'];
	$psst_d1 = $row['passport_no'];
	$vis_d1 = $row['visa_exp_dt'];
	$comp_d1 = $row['company_d'];
	$addrs_d1 = $row['address_d'];
	$city_d1 = $row['city_d'];
	$country_d1 = $row['country_d'];	

}

?>


<tr>
<td> <?php echo $ecode; ?> </td>
<td> <?php echo $ename1; ?> </td>
<td> <?php echo $desig_d1; ?> </td>
<td> <?php echo $doj_d1; ?> </td>
<td> <?php echo $dob_d1; ?> </td>
<td> <?php echo $psst_d1; ?> </td>
<td> <?php echo $vis_d1; ?> </td>
<td> <?php echo $comp_d1; ?> </td>
<td> <?php echo $addrs_d1; ?> </td>
<td> <?php echo $city_d1; ?> </td>
<td> <?php echo $country_d1; ?> </td>
<td> Delete </td>
<td> Edit</td>

<?php } ?>

</tr>







</table>
</body>

</html>


<?php
mysql_connect("localhost","root", "");
mysql_select_db("construction");

if (isset ($_POST['e_submit'])){
	//$code  = $_post['e_code'];
	$ename = $_POST['e_name'];
	$desig_d = $_POST['Desig_A'];
	$doj_d = $_POST['doj'];
	$dob_d = $_POST['dob'];
	$psst_d = $_POST['psst'];
	$vis_d = $_POST['vis'];
	$comp_d = $_POST['Comp'];
	$addrs_d = $_POST['addrs'];
	$city_d = $_POST['cty'];
	$country_d = $_POST['cntry'];

$query = "insert into Employee 
(emp_name, desig_d, doj, dob, passport_no, visa_exp_dt, company_d, address_d,city_d, country_d )
values ('$ename','$desig_d','$doj_d','$dob_d','$psst_d','$vis_d','$comp_d','$addrs_d','$city_d','$country_d')";
IF (mysql_query($query))	{
	echo "<h1> Data Inserted</h1>";
}
}

?>

thanks

Weedpacket

...
$comp_d1 = $row['company_d'];
$addrs_d1 = $row['address_d'];
$city_d1 = $row['city_d'];
$country_d1 = $row['country_d'];

} // <-- You need to move this to *after* you echo the values.

?>

hissam78

Sorry dear can't understand can you please amend the code , i am new in PHP i don't have idea what to do?

please help me.

Weedpacket;11052841 wrote:

...
$comp_d1 = $row['company_d'];
$addrs_d1 = $row['address_d'];
$city_d1 = $row['city_d'];
$country_d1 = $row['country_d'];

} // <-- You need to move this to *after* you echo the values.

?>

dalecosp

You have the assignments in a while loop, but the echo is NOT inside the loop, so only the final values are printed to the screen. Weedpacket has correctly advised you to move the curly brace that is currently below the assignments to the same spot as the curly brace following the echo statements.

NogDog

There's really no need to assign elements of $GET or $POST to new variables. You can get rid of that redundant code, as well as a lot of repetitious stuff with something like this (warning: untested):

<table width="800" border="5" align="center">
    <tr>
        <th> Emp_no:</th>
        <th> Emp_Name:</th>
        <th> Designation:</th>
        <th> DOJ:</th>
        <th> DOB:</th>
        <th> Passport #:</th>
        <th> Visa Expiry:</th>
        <th> Company:</th>
        <th> Address:</th>
        <th> City:</th>
        <th> Country:</th>
        <th> Delete:</th>
        <th> Edit:</th>
    </tr>
<?php
$fields = array(
    'emp_code',
    'emp_name',
    'desig_d',
    'doj',
    'dob',
    'passport_no',
    'visa_exp_dt',
    'company_d',
    'address_d',
    'city_d',
    'country_d'
);
if (isset ($_GET["e_submit"])) {
    mysql_connect("localhost", "root", "");
    mysql_select_db("construction");
    $query1 = "select * from employee";
    $run = mysql_query($query1);
?>
    <?php
    while ($row = mysql_fetch_array($run)) {
        echo "    <tr>\n";
        foreach ($fields as $field) {
            echo "      <td>" . htmlentities($row[$field]) . "</td>\n";
        }
        echo "    </tr>\n";
    }
}
?>
</table>
</body>
</html>
<?php
mysql_connect("localhost", "root", "");
mysql_select_db("construction");
if (isset ($_POST['e_submit'])) {
    $query = "
insert into Employee (
  emp_name,
  desig_d,
  doj,
  dob,
  passport_no,
  visa_exp_dt,
  company_d,
  address_d,
  city_d,
  country_d
) values (
";
    foreach($fields as $field) {
        if($field == 'emp_code') {
            continue;
        }
        $query .= "  '".mysql_real_escape_string($_POST[$field])."',\n";
    }
    $query = rtrim($query, ',').')';
    if (mysql_query($query)) {
        echo "<h1> Data Inserted</h1>";
    }
}

Of course, you're still using the long-deprecated mysql_*() functions, when you should instead be using the MySQLi or PDO extensions instead. Since you are using the mysql stuff, I added some escaping of inputs to help prevent SQL injection.

(Yes, I had some time to waste. 😉 )

hissam78

thanks for reply,
i have moved the following bracket } but it is showing the following error.

Parse error: syntax error, unexpected end of file in C:\xampp\htdocs\sarwat_cons\Select_Emp.php on line 181
(Line 181 is the last line of below code)

COde:

<html>
<head>
<title>Employee's Data </title>
</head>

<body>
<form action = "Employee_frm.php" method = "post">
<table width = "500" border = "5" align = "center">
<tr>
<td bgcolor = "Yellow" align = "center" colspan = "5"><h1> Employee's Registration </h1></td>
</tr>

<tr>
<td>Employee Name: </td>
<td><input type = "text" name = "e_name"> </td>
</tr>

<tr>
<td>Designation: </td>
<td><input type = "text" name = "Desig_A"> </td>
</tr>

<tr>
<td>Date of Joining: </td>
<td><input type = "text" name = "doj"> </td>
</tr>

<tr>
<td>Date of Birth: </td>
<td><input type = "text" name = "dob"> </td>
</tr>

<tr>
<td>Passport #: </td>
<td><input type = "text" name = "psst"> </td>
</tr>

<tr>
<td>Visa Expiry Date: </td>
<td><input type = "text" name = "vis"> </td>
</tr>

<tr>
<td>Company Name: </td>
<td><input type = "text" name = "Comp"> </td>
</tr>

<tr>
<td>Address: </td>
<td><input type = "text" name = "addrs"> </td>
</tr>

<tr>
<td>Country: </td>
<td><input type = "text" name = "cntry"> </td>
</tr>

</table>
</form>
<table width = "800" border = "5" align = "center">
<tr>
<th> Emp_no: </th>
<th> Emp_Name: </th>
<th> Designation: </th>
<th> DOJ: </th>
<th> DOB: </th>
<th> Passport #: </th>
<th> Visa Expiry: </th>
<th> Company: </th>
<th> Address: </th>
<th> City: </th>
<th> Country: </th>
<th> Delete: </th>
<th> Edit: </th>
</tr>

<?php
if (isset ($_GET["e_submit"])){
mysql_connect("localhost","root", "");
mysql_select_db("construction");

$query1 = "select * from employee";
$run = mysql_query($query1);

while ($row=mysql_fetch_array($run)){
$ecode = $row['emp_code'];
$ename1 = $row['emp_name'];
$desig_d1 = $row['desig_d'];
$doj_d1 = $row['doj'];
$dob_d1 = $row['dob'];
$psst_d1 = $row['passport_no'];
$vis_d1 = $row['visa_exp_dt'];
$comp_d1 = $row['company_d'];
$addrs_d1 = $row['address_d'];
$city_d1 = $row['city_d'];
$country_d1 = $row['country_d'];

<tr>
<td> <?php echo $ecode; ?> </td>
<td> <?php echo $ename1; ?> </td>
<td> <?php echo $desig_d1; ?> </td>
<td> <?php echo $doj_d1; ?> </td>
<td> <?php echo $dob_d1; ?> </td>
<td> <?php echo $psst_d1; ?> </td>
<td> <?php echo $vis_d1; ?> </td>
<td> <?php echo $comp_d1; ?> </td>
<td> <?php echo $addrs_d1; ?> </td>
<td> <?php echo $city_d1; ?> </td>
<td> <?php echo $country_d1; ?> </td>
<td> Delete </td>
<td> Edit</td>

</tr>
<?php } ?>
}

</table>
</body>

</html>

<?php
mysql_connect("localhost","root", "");
mysql_select_db("construction");

if (isset ($POST['e_submit'])){
//$code = $post['e_code'];
$ename = $POST['e_name'];
$desig_d = $POST['Desig_A'];
$doj_d = $POST['doj'];
$dob_d = $POST['dob'];
$psst_d = $POST['psst'];
$vis_d = $POST['vis'];
$comp_d = $POST['Comp'];
$addrs_d = $POST['addrs'];
$city_d = $POST['cty'];
$country_d = $POST['cntry'];

$query = "insert into Employee  
(emp_name, desig_d, doj, dob, passport_no, visa_exp_dt, company_d, address_d,city_d, country_d ) 
values ('$ename','$desig_d','$doj_d','$dob_d','$psst_d','$vis_d','$comp_d','$addrs_d','$city_d','$country_d')"; 
IF (mysql_query($query))    { 
    echo "<h1> Data Inserted</h1>"; 
}

}

cretaceous

<?php } ?>
}
is wrong - that second curly bracket will just appear on the page as a pretty curly bracket - it's being output as html, not as part of the PHP control logic

I'm guessing (without examining you code) it should be :

<?php
}
}
?>

hissam78

Dear thanks for reply,
i have tried the same with changes you told me. but now it is showing the following
error.Parse error: syntax error, unexpected '}' in C:\xampp\htdocs\sarwat_cons\Select_Emp.php on line 147
(Line 147 is the second curly bracket
<?php
}
}
?> )

Code:

<?php 
//if (isset ($_GET["e_submit"])){ 
mysql_connect("localhost","root", ""); 
mysql_select_db("construction"); 

$query1 = "select * from employee"; 
$run = mysql_query($query1); 


while ($row=mysql_fetch_array($run)){ 
    $ecode = $row['emp_code']; 
    $ename1 = $row['emp_name']; 
    $desig_d1 = $row['desig_d']; 
    $doj_d1 = $row['doj']; 
    $dob_d1 = $row['dob']; 
    $psst_d1 = $row['passport_no']; 
    $vis_d1 = $row['visa_exp_dt']; 
    $comp_d1 = $row['company_d']; 
    $addrs_d1 = $row['address_d']; 
    $city_d1 = $row['city_d']; 
    $country_d1 = $row['country_d'];     



?> 


<tr> 
<td> <?php echo $ecode; ?> </td> 
<td> <?php echo $ename1; ?> </td> 
<td> <?php echo $desig_d1; ?> </td> 
<td> <?php echo $doj_d1; ?> </td> 
<td> <?php echo $dob_d1; ?> </td> 
<td> <?php echo $psst_d1; ?> </td> 
<td> <?php echo $vis_d1; ?> </td> 
<td> <?php echo $comp_d1; ?> </td> 
<td> <?php echo $addrs_d1; ?> </td> 
<td> <?php echo $city_d1; ?> </td> 
<td> <?php echo $country_d1; ?> </td> 
<td> Delete </td> 
<td> Edit</td> 



</tr> 
<?php 
} 
}
?>





</table> 
</body> 

</html> 


<?php 
mysql_connect("localhost","root", ""); 
mysql_select_db("construction"); 

if (isset ($_POST['e_submit'])){ 
    //$code  = $_post['e_code']; 
    $ename = $_POST['e_name']; 
    $desig_d = $_POST['Desig_A']; 
    $doj_d = $_POST['doj']; 
    $dob_d = $_POST['dob']; 
    $psst_d = $_POST['psst']; 
    $vis_d = $_POST['vis']; 
    $comp_d = $_POST['Comp']; 
    $addrs_d = $_POST['addrs']; 
    $city_d = $_POST['cty']; 
    $country_d = $_POST['cntry']; 

$query = "insert into Employee  
(emp_name, desig_d, doj, dob, passport_no, visa_exp_dt, company_d, address_d,city_d, country_d ) 
values ('$ename','$desig_d','$doj_d','$dob_d','$psst_d','$vis_d','$comp_d','$addrs_d','$city_d','$country_d')"; 
IF (mysql_query($query))    { 
    echo "<h1> Data Inserted</h1>"; 
} 
} 

?>

(MOD: Edited to put [noparse]

[/noparse] tags around the code and remove the superfluous HTML that preceded any of the PHP code.)[/i]

NogDog

Please, please post your code inside of [noparse]

...

[/noparse] tags. It will be so much easier to read. Also, you can leave out all the HTML that precedes the first <?php tag, as it will have no bearing on an PHP parse errors.

hissam78

Dear Following is the PHP codes, i have removed all the html coding as well.

<?php
//if (isset ($_GET["e_submit"])){
mysql_connect("localhost","root", "");
mysql_select_db("construction");
$query1 = "select * from employee";
$run = mysql_query($query1);
while ($row=mysql_fetch_array($run)){
$ecode = $row['emp_code'];
$ename1 = $row['emp_name'];
$desig_d1 = $row['desig_d'];
$doj_d1 = $row['doj'];
$dob_d1 = $row['dob'];
$psst_d1 = $row['passport_no'];
$vis_d1 = $row['visa_exp_dt'];
$comp_d1 = $row['company_d'];
$addrs_d1 = $row['address_d'];
$city_d1 = $row['city_d'];
$country_d1 = $row['country_d'];
?>

</tr>
<?php
}
}
?>

NogDog

You commented out an "isset()" line that ends in a "{", leaving the number of matching braces unbalanced.

And you still are not using this forum's [noparse]

[/noparse] [URL="http://board.phpbuilder.com/misc.php?do=bbcode"]bbcode tags[/URL]. :( (I edited your previous post to add them.)

hissam78

Dear i have used your code. but it is also showing error.

hissam78

Dear NogDog
please i have following code, can you please add the PHP code for Select command i will be thankful to you.
for insert statement it is working fine.