PHP script writing xml-document with array values.

[masimies]

Hello, stuck again...

I'm trying to store offers to xml-documents. Managed to present query grid to form, but write to xml-file section does only first value to xml-file.
I think that even storing values to form input fields completes, fwrite needs something more to write all rows in array?

Here is my code so far, what does the thing:

<?php
	$query=mysqli_query($db,"SELECT * FROM offer WHERE OfferID='$OfferID' AND OrderStatus<>'Removed' AND OrderStatus<>'Poistettu' ORDER BY ProductName ASC");
	while($row=mysqli_fetch_array($query))
 	{
	$id=$row['id'];
  	$Custname=$row['Custname'];
	$Custnum=$row['Custnum'];
	$Custphone=$row['Custphone'];
	$Custemail=$row['Custemail'];
	$Custpostadd=$row['Custpostadd'];
	$Custpostnum=$row['Custpostnum'];
	$Custpostloc=$row['Custpostloc'];
	$OfferID=$row['OfferID'];
	$ProductName=$row['ProductName'];
	$OrderedAmt=$row['OrderedAmt'];
	$unit=$row['unit'];
	$RetailPrice=$row['RetailPrice'];
	$TaxRate=$row['TaxRate'];
	$TaxFree=$row['TaxFree'];
	$Tax=$row['Tax'];
	$FullCost=$row['FullCost'];
	$Profit=$row['Profit'];
	$Discount=$row['Discount'];
	$Total=$row['Total'];
	$OrderStatus=$row['OrderStatus'];
	?>

<input name="relement" type="hidden" id="relement" value="Offer"/>
<tr><td><input name="ProductName" type="text" id="ProductName"  value="<?php echo $ProductName; ?>"/></td>
<td><input name="OrderedAmt" type="text" id="OrderedAmt"  value="<?php echo $OrderedAmt; ?>"/></td>
<td><input name="unit" type="text" id="unit"  value="<?php echo $unit; ?>"/></td>
<td><input name="RetailPrice" type="text" id="RetailPrice"  value="<?php echo $RetailPrice; ?>"/></td>
<td><input name="TaxRate" type="text" id="TaxRate"  value="<?php echo $TaxRate; ?>"/></td>
<td><input name="Discount" type="text" id="Discount"  value="<?php echo $Discount; ?>"/></td>
<td><input name="Tax" type="text" id="Tax"  value="<?php echo $Tax; ?>"/></td>
<td><input name="TaxFree" type="text" id="TaxFree"  value="<?php echo $TaxFree; ?>"/></td>
<td><input name="Total" type="text" id="Total"  value="<?php echo $Total; ?>"/></td>
<td><input name="FullCost" type="text" id="FullCost"  value="<?php echo $FullCost; ?>"/></td>
<td><input name="Profit" type="text" id="Profit"  value="<?php echo $Profit; ?>"/></td>
<td><input name="OrderStatus" type="text" id="OrderStatus"  value="<?php echo $OrderStatus; ?>"/></td></tr>
</form>
<?php
}
?>
<?php
//create file
if(isset($_POST['submit'])){
$msg = "";
if(empty($_POST['offer'])){
$msg = "Please enter a file name";
}
if(empty($msg)){
$xmldoc=$_POST['offer'].".xml";
if(!file_exists($xmldoc)){ 
if($fp=fopen($xmldoc,'w+')){
fwrite($fp,"<?xml version='1.0' ?>\n");
fwrite($fp,'<'.$_POST['relement'].'>');
fwrite($fp,"\n");
fwrite($fp,"<content>\n");
fwrite($fp,'<ProductName>'.$ProductName."</ProductName>\n");
fwrite($fp,'<OrderedAmt>'.$OrderedAmt."</OrderedAmt>\n");
fwrite($fp,'<unit>'.$unit."</unit>\n");
fwrite($fp,'<RetailPrice>'.$RetailPrice."</RetailPrice>\n");
fwrite($fp,'<TaxRate>'.$TaxRate."</TaxRate>\n");
fwrite($fp,'<Discount>'.$Discount."</Discount>\n");
fwrite($fp,'<Tax>'.$Tax."</Tax>\n");
fwrite($fp,'<TaxFree>'.$TaxFree."</TaxFree>\n");
fwrite($fp,'<Total>'.$Total."</Total>\n");
fwrite($fp,'<FullCost>'.$FullCost."</FullCost>\n");
fwrite($fp,'<Profit>'.$Profit."</Profit>\n");
fwrite($fp,'<OrderStatus>'.$OrderStatus."</OrderStatus>\n");
fwrite($fp,"</content>\n");
fwrite($fp,"</".$_POST['relement'].">");
fclose($fp);
$msg =  "The XML document called ".$xmldoc. " has been created";
}else{
$msg =  "There was an error, could not create the XML document.";
}
}else{
$msg = "File name already exists, please try again";
}
}
}
?>

[masimies]

I need to manage xml-file save location also. Now this is storing files to root folder.

[sneakyimp]

You run mysqli_query and then fail to check the result before attempting to use it. You should ALWAYS check for error conditions before attempting to loop through a query result.

You then loop through the results (if any) and create the exact same inputs for each record that is returned. The result is that you have duplicate input names. Even if you had a million records, when you submit the form, you'll only get one of each. If you want to have this page submit more than one of your records, you'll need a way to have the input names be different for each record. E.g., instead of this as you have now:

input name="ProductName" type="text" id="ProductName" value="<?php echo $ProductName; ?>" />

you might consider this:

input name="ProductName[]" type="text" id="ProductName[]" value="<?php echo $ProductName; ?>" />

Note the square brackets. This will cause your form to define a nested array in the page that handles its submission.

I also don't see any opening <form> tag.

[masimies]

Hi, and thanks for comments,
The sample part is not complete code of the php-page. form opening is in upper in code.
But with square brackets, there is no difference for the function in result. Without them, i have the correct result to input form allready. All the included rows are there.
Problem is the fwrite section. It does not write all rows to xml-file. Only one row in form.
So i need somekind of loop to it, write all productname-rows to xml-file.

[laserlight]

masimies wrote:

But with square brackets, there is no difference for the function in result. Without them, i have the correct result to input form allready. All the included rows are there.

How do you know all the included rows are there?

masimies wrote:

Problem is the fwrite section. It does not write all rows to xml-file. Only one row in form.
So i need somekind of loop to it, write all productname-rows to xml-file.

Yes, you need a loop. You also really need to indent your PHP code or it is hard to read, e.g.,

if (isset($_POST['submit'])) {
    $msg = "";
    if (empty($_POST['offer'])) {
        $msg = "Please enter a file name";
    }
    if (empty($msg)) {
        $xmldoc = $_POST['offer'] . ".xml";
        if (!file_exists($xmldoc)) {
            if ($fp = fopen($xmldoc, 'w+')) {
                fwrite($fp, "<?xml version='1.0' ?>\n");
                fwrite($fp, '<'.$_POST['relement'].'>');
                fwrite($fp, "\n");
                fwrite($fp, "<content>\n");
                fwrite($fp, '<ProductName>'.$ProductName."</ProductName>\n");
                fwrite($fp, '<OrderedAmt>'.$OrderedAmt."</OrderedAmt>\n");
                fwrite($fp, '<unit>'.$unit."</unit>\n");
                fwrite($fp, '<RetailPrice>'.$RetailPrice."</RetailPrice>\n");
                fwrite($fp, '<TaxRate>'.$TaxRate."</TaxRate>\n");
                fwrite($fp, '<Discount>'.$Discount."</Discount>\n");
                fwrite($fp, '<Tax>'.$Tax."</Tax>\n");
                fwrite($fp, '<TaxFree>'.$TaxFree."</TaxFree>\n");
                fwrite($fp, '<Total>'.$Total."</Total>\n");
                fwrite($fp, '<FullCost>'.$FullCost."</FullCost>\n");
                fwrite($fp, '<Profit>'.$Profit."</Profit>\n");
                fwrite($fp, '<OrderStatus>'.$OrderStatus."</OrderStatus>\n");
                fwrite($fp, "</content>\n");
                fwrite($fp, "</".$_POST['relement'].">");
                fclose($fp);
                $msg =  "The XML document called ".$xmldoc. " has been created";
            } else {
                $msg =  "There was an error, could not create the XML document.";
            }
        } else {
            $msg = "File name already exists, please try again";
        }
    }
}

Furthermore, you should be escaping the values that come from incoming variables like $_POST['relement'], e.g., by using [man]htmlspecialchars[/man].

Actually, you do not need so many fwrite calls. You could have constructed a string, then write that string with a single fwrite call.

[masimies]

Yes, im just a beginner of all this stuff. Creating a portal for learning purposes, and present in live, the competence level. To get work. Nowadays it is hard to find work, if you cannot stand up from the mass, and show what you can do. :-)
So far, in 3-months, from scratch, without previous knowledge of technologies, i have managed to publish portal, included number of PHP, CSS, Jquery, HTML functions working in practice.
You can visit and see it here http://www.csrportal.fi/

Currently im trying to create 3rd party integrations. As this xml-function. For transfer information to other systems.

For this "loop" issue. It is hard to me find the correct solution to my function, from hundreds of examples. Needed for simplier examples.

[masimies]

For the result, i have input presented:
[ATTACH]5297[/ATTACH]

And the xml-result is only for one row:
[ATTACH]5299[/ATTACH]

result.JPG xmltietue.JPG

[masimies]

Saving the xml-file to other location than root, i handled with $path variable:
$path="xml/";
$offer=$_POST['offer'];
if(empty($msg)){
$xmldoc=$path.$offer.".xml";