[RESOLVED] Somekind of accesscontrolled navigation

masimies

Got an idea of creating very simply way, navigation, depending of logged users.
Taught that it could be handled with logical operators. But no, logical operators were not functioning logically, or me...

Here is the navigation part of code. It doesn't work logically. Why not?
usergroup 1 is admin-group.

			<?php
			if($usergroup=='1' || '3' || '4' || '5') echo'<li><a href="news.php">Reports</a></li>';
			if($usergroup=='1' || '3' || '4' || '5') echo'<li><a href="updateproducts.php">Products</a>';
			if($usergroup=='1' || '4' || '5' && ! '3') echo'<li><a href="updateprices.php">Pricing</a>';
			if($usergroup=='1' || '4' || '5' && ! '3') echo'<li><a href="updateoffer.php">Offers</a></li>';
			if($usergroup=='1' || '4' || '5' && ! '3') echo'<li><a href="updatecustomer.php">Customers</a></li>';
			if($usergroup=='1' || '5' && ! '3' && '4') echo'<li><a href="updatecontrol.php">Controls</a></li>';
			if($usergroup=='1' || '5' && ! '3' && '4') echo'<li><a href="updateprocess.php">Processes</a></li>';
			if($usergroup=='1') echo'<li><a href="updateusers.php" title="Manage users">Users</a></li>';
			if($usergroup=='1') echo'<li><a href="updatereports.php" title="Manage reports">Reports</a></li>';
			?>

Derokorian

|| combines 2 boolean values into a single one, where if either side is true, the result is true. So for the first if statement, if($usergroup=='1' || '3' || '4' || '5') you are saying: IF a variable is equal to 1, OR the boolean representation of the string 3 is true, OR the boolean representation of the string '4' is true, OR the boolean representation of the string '5' is true THEN the resulting if statement is true. Also, since converting a non-empty string to boolean results in a true value, this if statement will ALWAYS evaluate to true.

What you are looking for is probably [man]in_array[/man], to check if $usergroup is one of a list of values. Again, using just your first if statement it would be like:

if (in_array($usergroup, [1,3,4,5])) ...

masimies

Thanks for reply,
Im quite bad with arrays. Going to blind when see those thousands of syntax variables. :-)
Here, i got already the value what is needed from session variable:
$usergroup=$_SESSION['group_of_user'];

Maybe this can be completed somehow other way?

Derokorian

If you are going to do things in PHP you really do need to learn arrays at some point.

Anyway, if you wanted to do it with logical or operators || then you could do something like this:

if($usergroup=='1' || $usergroup=='3' || $usergroup=='4' || $usergroup=='5') ...

NogDog

For a somewhat different approach that at least sort of separates out the data from the code:

<html>
<head><title>test</title></head>
<body>
<?php
function menu($usergroup)
{
    $menuData = array(
        array('link' => 'news.php', 'text' => 'Reports', 'groups' => array(1, 3, 4, 5)),
        array('link' => 'udateproducts.php', 'text' => 'Products', 'groups' => array(1, 3, 4, 5)),
        array('link' => 'updateprices.php', 'text' => 'Pricing', 'groups' => array(1, 4, 5)),
        array('link' => 'updateusers.php', 'text' => 'Manage users', 'groups' => array(1))
    );
    $result = '';
    foreach($menuData as $item) {
        if(in_array($usergroup, $item['groups'])) {
            $result .= "<li><a href='{$item['link']}'>{$item['text']}</a></li>\n";
        }
    }
    return $result;
}
// test with usergroup values from 1 to 5:
echo "<h2>TEST</h2>";
for($usergroup = 1; $usergroup <= 5; $usergroup++) {
    echo "<h3>User Group $usergroup</h3>\n<ul>".menu($usergroup)."</ul>\n";
}
?>
</body>
</html>

You could take it a step further by putting the menu data into a JSON file, perhaps, and read that into your script as a PHP array.

Bonesnap

Derokorian;11053871 wrote:
If you are going to do things in PHP you really do need to learn arrays at some point.

Agreed. Do as much as you can with arrays (within reason) as they will become invaluable to you in the future. They can also help keep your code neat and concise. For example using an [man]in_array/man call instead of a whole bunch of ||'s.

Weedpacket

Not being able to cope with arrays is like not being able to count past 1.

masimies

Yes, this code is more easy to understand, and you almost got the resolution. [ATTACH]5301[/ATTACH]
It can be display all choices, but cannot recognize session user-group variable, and present only that menu.
As with previous ways, it recognize only first, "Group 1". Others are as "Group 0", tested with different user levels. [ATTACH]5303[/ATTACH]

I tested it only with:
echo "<h3>User Group $usergroup</h3>\n<ul>".navi($usergroup)."</ul>\n";

arraynav1.JPG group0.JPG

masimies

->Derokorian,
Yep, that is the simplest solution, but i try to manage this with arrays, even it is complex way....

masimies

Gotcha!
Fault was in $usergroup=$_SESSION['group_of_user']; variable. Somehow, it is posting only group id 1. Don't get it why... session "name" is working every time.
Changed it to normal query of user values, and all variations presented here get to work.
Next time, i remember put variables echoing to start of code, before trying to test many versions of coding :-D

So,
This access controlled navigation, can make happen 2-ways. With operators, or with array:

			if($usergroup=='1' || $usergroup=='3' || $usergroup=='4' || $usergroup=='5') echo'<li><a href="news.php">Reports</a></li>';
				if($usergroup=='1' || $usergroup=='3' || $usergroup=='4' || $usergroup=='5') echo'<li><a href="updateproducts.php">Products</a>';
				if($usergroup=='1' || $usergroup=='4' || $usergroup=='5') echo'<li><a href="updateprices.php">Pricing</a>';
				if($usergroup=='1' || $usergroup=='4' || $usergroup=='5') echo'<li><a href="updateoffer.php">Offers</a></li>';
				if($usergroup=='1' || $usergroup=='4' || $usergroup=='5') echo'<li><a href="updatecustomer.php">Customers</a></li>';
				if($usergroup=='1' || $usergroup=='5') echo'<li><a href="updatecontrol.php">Controls</a></li>';
				if($usergroup=='1' || $usergroup=='5') echo'<li><a href="updateprocess.php">Processes</a></li>';
				if($usergroup=='1') echo'<li><a href="updateusers.php" title="Manage users">Users</a></li>';
				if($usergroup=='1') echo'<li><a href="updatereports.php" title="Manage reports">Reports</a></li>';

				function navi($usergroup)
				{
				$menuData = array(
				array('link' => 'news.php', 'text' => 'Reports', 'groups' => array(1, 3, 4, 5)),
				array('link' => 'udateproducts.php', 'text' => 'Products', 'groups' => array(1, 3, 4, 5)),
				array('link' => 'updateprices.php', 'text' => 'Pricing', 'groups' => array(1, 4, 5)),
				array('link' => 'updateoffer.php', 'text' => 'Offers', 'groups' => array(1, 4, 5)),
				array('link' => 'updatecustomer.php', 'text' => 'Customers', 'groups' => array(1, 4, 5)),
				array('link' => 'updatecontrol.php', 'text' => 'Controls', 'groups' => array(1, 5)),
				array('link' => 'updateprocess.php', 'text' => 'Processes', 'groups' => array(1, 5)),
				array('link' => 'updateusers.php', 'text' => 'Manage users', 'groups' => array(1)),
				array('link' => 'updatereports.php', 'text' => 'Manage Reports', 'groups' => array(1, 3, 4, 5))
				);
				$result = '';
				foreach($menuData as $item) {
				if(in_array($usergroup, $item['groups'])) {
				$result .= "<li><a href='{$item['link']}'>{$item['text']}</a></li>\n";
				}
				}
				return $result;
				}
				echo "<ul>".navi($usergroup)."</ul>\n";