[RESOLVED] Form controls

cluelessPHP

So I have been working with this code, the basic idea is it will loop through any inputs

<form name="auditform" action="input.php" method="POST">
	<label class="chutesTitle">Sort </label>
	<label class="chutesTitle">Error</label>

<?php

try{
	   $db = new PDO("mysql:host=localhost;dbname=amazon", 'root', '');
	   $db ->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
	}  catch(PDOException $e){
		echo $e->getMessage();
		die();
	}

$names = $db->prepare("
				SELECT sort
				FROM sorts WHERE section = 'chutes'
			");

 $names->execute();
 $names = $names->fetchAll(PDO::FETCH_ASSOC);

			 foreach($names as $name):
			?>
<div class="chuteAudit">
			<div>
				<label for="x1"><?php echo $name['sort']; ?></label>
					<input  type="number" name="count">
					<input	type="number" name="error"  >
					<input  type="hidden" name="sort" value="<?php echo $name['sort']; ?>" readonly>
			</div>
			<div class="errors">
				<span></span>
				<span class="error"></span>
				<span class="error"></span>
			</div>
</div>   		
			<?php endforeach;?>

<input type="submit" value="Submit">
	</form>


if ($_SERVER["REQUEST_METHOD"] == "POST"){

	$sort = $_POST["sort"];
	$count = $_POST["count"];
	$error = $_POST["error"];

   foreach ($audits['sort'] as $key => $auditing) {

	$sort = $audits["sort"][$key];
	$count = $audits["count"][$key];
	$error = $audits["error"][$key];

	$sql = "INSERT INTO audits (`sort`, `count`, `error`, `timeentered`)
            VALUES ('$sorts','$count','$error', NOW());
			";	
	$query = $db->prepare($sql);

                            $query->execute(array(
                                ':sort' => $sort,
                                ':count' => $count,
                                ':error' => $error
                            ));

	}	
}

Currently I'm getting the error Invalid argument supplied for foreach()

NogDog

I'd guess your query is not executing. Try changing this...

$names->execute();

...to this...

if($names->execute() == false) {
    die("<pre>Query failed:\n".print_r($names->errorInfo(),1)."</pre>");
}

You'll eventually want "nicer" error trapping/reporting, but for now this let you know if that's where it's failing.

cluelessPHP


if ($_SERVER["REQUEST_METHOD"] == "POST"){

	$sort = $_POST["sort"];
	$count = $_POST["count"];
	$error = $_POST["error"];

   foreach ($audits['sort'] as $key => $auditing) {

	$sort = $audits["sort"][$key];
	$count = $audits["count"][$key];
	$error = $audits["error"][$key];

	$sql = "INSERT INTO audits (`sort`, `count`, `error`, `timeentered`)
            VALUES ('$sorts','$count','$error', NOW());
			";	
	$query = $db->prepare($sql);

                            $query->execute(array(
                                ':sort' => $sort,
                                ':count' => $count,
                                ':error' => $error
                            ));

	}



}

Ah to clarify it's currently this part I'm working on, at most it will only insert the last entry of the form, I can work on validation a little later after I get the insert working

NogDog

Then you need to find out why $audits['sort'] is not an array (or an iterable object) -- assuming it's supposed to be? To find out what it is, a simple way is to use something like this right before you try to use it:

die("<pre>".var_export($audits['sort'], 1)."</pre>");

cluelessPHP

It keeps giving me the error

 PHP Warning:  Invalid argument supplied for foreach()

NogDog

So whatever you are supplying as the first argument to foreach() on the line the error message says is failing is not an array (nor an iterable object). So as I stated above, you need to find out what it is, and then work backwards from there to figure out why it's not what you think it should be -- or rethink your expectations. 😉

cluelessPHP

Yeah I gave up on it.

cluelessPHP

if ($_SERVER["REQUEST_METHOD"] == "POST"){

	$sort  = $_POST['sort'];
	$count = $_POST["count"];
	$error = $_POST["error"];


if (isset($_POST['sort'])) {
	for ( $i=0;$i<count($_POST['sort']);$i++) {
	$sort = $_POST['sort'][$i];

	}
}
 $sql = "INSERT INTO audits (`sort`, `count`, `error`, `timeentered`)
                VALUES ('$sort','$count','$error', NOW());
                ";   
$query = $db->prepare($sql);

                            $query->execute(array(
                                ':sort' => $sort,
                                ':count' => $count,
                                ':error' => $error
                            ));
}

Well I attempted this same result, I'm sure the answer is simple

cluelessPHP

 if (isset($_POST['sort'])) {
                            for ( $i=0;$i<count($_POST['sort']);$i++) {
                            $sort = $_POST['sort'][$i];
                            $count = $_POST['count'][$i];
							$error = $_POST['error'][$i];	

                        $query = $db->prepare("INSERT INTO audits (`sort`, `count`, `error`, `timeentered`)
												VALUES ('$sort','$count','$error', NOW())");
                                 $query->bindValue(1, $sort);
                                 $query->bindValue(2, $count);
                                 $query->bindValue(3, $error);
                                            try{
                                                $query->execute();
                                                echo 'got the data';
                                            }catch(PDOException $e){
                                                die($e->getMessage());
                                            }

                        }
                }

And tried this

Weedpacket

It's probably not helping that you're misusing the prepare() by having it inside the loop, and you're embedding values directly into the SQL instead of using parameters.

You can't still be getting the same result, because without a foreach statement you can't be supplying an invalid argument to one.

cretaceous

Just do
echo '<pre>';
print_r($_POST);
echo '</pre>';
and you can see exactly what's in the POST array all nicely laid out so you can see any sub-arrays

cluelessPHP

I deleted everything more or less and started again,


if ($_SERVER["REQUEST_METHOD"] == "POST"){

	$sort  = $_POST['sort'];
	$count = $_POST["count"];
	$errors = $_POST["error"];

/* $sql = "INSERT INTO audits (`sort`, `count`, `error`, `timeentered`)
                VALUES ('$sort','$count','$error', NOW());
                "; */   
//print_r($count);
//print_r($errors);

foreach ($sort as $s) {
  echo "$s<br />";
}
	foreach ($count as $c){
		echo $c . ' ';
	}

foreach ($errors as $e){
	echo $e;
}
/*	$query = $db->prepare($sql);

                            $query->execute(array(
                                ':sort' => $s,
                                ':count' => $c,
                                ':error' => $e
                            ));

*/
	}

this outputs all the correct values, I'll build from here and see what happens


if ($_SERVER["REQUEST_METHOD"] == "POST"){

	$sort  = $_POST['sort'];
	$count = $_POST["count"];
	$errors = $_POST["error"];

/* $sql = "INSERT INTO audits (`sort`, `count`, `error`, `timeentered`)
                VALUES ('$sort','$count','$error', NOW());
                "; */   


$audit = array( ':sort' => $sort,
				':count' => $count,
                ':error' => $errors
				);
foreach($audit as $completeAudit => $display) {             

  print_r($display);
}

/*
$query = $db->prepare($sql);

                            $query->execute(array(
                                ':sort' => $sort,
								':count' => $count,
								':error' => $errors
                            ));

*/
	}

Seems neater

cluelessPHP

<?php
	try{
	   $db = new PDO("mysql:host=localhost;dbname=amazon", 'root', '');
	   $db ->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
	}  catch(PDOException $e){
		echo $e->getMessage();
		die();
	}

if ($_SERVER["REQUEST_METHOD"] == "POST"){


    $stmt = array(
                                ':sort' =>  $_POST['sort'],
			    ':count' =>  $_POST['count'],
			    ':error' =>  $_POST['error']
                            );



  $sql = "INSERT INTO `audits` (`sort`, `count`, `error`, `timeentered`) VALUES (?,?,?, NOW())";
 foreach($stmt as $row){


    $stmt = $db->prepare($sql);
	$stmt->execute($row);

}  



}

Current error message

Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens'

I'm not sure if it's because of the way I'm trying to insert time or not.

Weedpacket

You're trying to insert values into slots named [font=monospace]:sort[/font], [font=monospace]:count[/font], and [font=monospace]:error[/font] but there aren't any slots with those names in the statement.

cluelessPHP



<div class="chuteAudit">
				<div>
					<label for="x1"><?php echo $name['sort']; ?></label>
						<input  type="hidden" name="sort[]" value="<?php echo $name['sort']; ?>" >
						<input  type="number" name="count[]">
						<input	type="number" name="error[]">

			</div>

</div>   	


<?php 
    try{ 
       $db = new PDO("mysql:host=localhost;dbname=amazon", 'root', ''); 
       $db ->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION); 
    }  catch(PDOException $e){ 
        echo $e->getMessage(); 
        die(); 
    } 

if ($_SERVER["REQUEST_METHOD"] == "POST"){ 

$sort = $_POST['sort'];
$count = $_POST['count'];
$error = $_POST['error'];

    $stmt = array( 
                ':sort' =>  $sort, 
                ':count' =>  $count, 
                ':error' =>  $error 
                            ); 



  $sql = "INSERT INTO `audits` (`sort`, `count`, `error`) VALUES (:sort,:count,:error, NOW())"; 
 foreach($stmt as $row){ 


    $stmt = $db->prepare($sql); 
    $stmt->execute($row); 

}   



}

I'm sure I have done a full 360 now

cluelessPHP

<?php
try{
	$db = new PDO("mysql:host=localhost;dbname=amazon", 'root', '');
	$db ->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
	} catch(PDOException $e){
	echo $e->getMessage();
	die();
}

	$sql = 'INSERT INTO `audits` (`sort`, `countAudit`, `error`, `timeentered`) VALUES';
	$values = " (?,?,?, NOW()),";

	$sort = $_POST['sort'];
	$count = $_POST['count'];
	$error = $_POST['error'];
	$rows = [];

	foreach($sort as $i=>$value){
		$rows[] = [$sort[$i],$count[$i],$error[$i]];
	}

	foreach($rows as $row){
		$sql = $sql . $values;
	}

	$sql = substr_replace($sql, "", -1);
	$stmt = $db->prepare($sql);
	$data = call_user_func_array('array_merge', $rows);
	$stmt->execute($data);

It works now
:glare:

cluelessPHP

<div class="controlPanel">
<script>
  $(document).ready(function(){
  $("form").on("submit", function (event) {
  			$.ajax({
  				type: 'POST',
  				url: 'input.php',
  				data: $(this).serialize(),
  				success: function (data) {
  					$(".error").html(data);

			}
		});
		event.preventDefault();
		//console.log($(this).serialize());
	});
  });		

</script>
<h4>Chutes audit</h4>
<script>
  $(function(){
      $('.chuteAudit :input').on("invalid blur", function(e) {
          var ok = this.validity.valid
          var index=$(this).index()-1
          $(this).closest(".chuteAudit").find(".error").eq(index).text( ok?"":"Enter a number")
      });
      $("form").submit(function(){
          $.post(this.action,$(this).serialize(),function(response){
              $(".error").empty()
              console.log(response)
              var hasErrors=false
              $.each(response,function(name,error){
                  var field= $(document.getElementsByName(name)),
                      errorField = field.closest(".chuteAudit").find(".error").eq(field.index()-1)
                  errorField.text(error)
  //                   console.log(name,field,error)
                  hasErrors=hasErrors||error
              })

      },"JSON")
      return false
  })
  })
</script>	
<form name="auditform" action="input.php" method="POST">
  <label class="chutesTitle">Count </label>
  <label class="chutesTitle">Error</label>
  <?php
    try{
    	   $db = new PDO("mysql:host=localhost;dbname=amazon", 'root', '');
    	   $db ->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
    	}  catch(PDOException $e){
    		echo $e->getMessage();
    		die();
    	}

$names = $db->prepare("
				SELECT sort
				FROM sorts WHERE section = 'chutes' AND active ='yes'
			");

 if($names->execute() == false) {
    die("<pre>Query failed:\n".print_r($names->errorInfo(),1)."</pre>");
}  
 $names = $names->fetchAll(PDO::FETCH_ASSOC);

				 foreach($names as $name):
				?>
  <div class="chuteAudit">
    <div>
      <label for="x1"><?php echo $name['sort']; ?></label>
      <input  type="hidden" name="sort[]" value="<?php echo $name['sort']; ?>" >
      <input  type="number" name="count[]"  required min="0">
      <input	type="number" name="error[]" required min="0">
    </div>
    <div class="errors">
      <span></span>
      <span class="error"></span>
      <span class="error"></span>
    </div>
  </div>
  <?php endforeach;?>
  <input type="submit" value="Submit" name="submit">
</form>

<?php
<?php
try{
	$db = new PDO("mysql:host=localhost;dbname=amazon", 'root', '');
	$db ->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
	} catch(PDOException $e){
	echo $e->getMessage();
	die();
}

	$sort = $_POST['sort'];
	$count = $_POST['count'];
	$error = $_POST['error'];
	$rows = [];

	 if (!is_numeric($count && $error))
		 {
			 echo "Enter a number";
		 }		
else if (empty($count && $error))  
        { 
			echo "Enter a number";
		}
else
		{		
			$sql = 'INSERT INTO `audits` (`sort`, `countAudit`, `error`, `timeentered`) VALUES';
			$values = " (?,?,?, NOW()),";

foreach($sort as $i=>$value)
		{
			$rows[] = [$sort[$i],$count[$i],$error[$i]];
		}

foreach($rows as $row)
		{
			$sql = $sql . $values;
		}

$sql = substr_replace($sql, "", -1);
$stmt = $db->prepare($sql);
$data = call_user_func_array('array_merge', $rows);
$stmt->execute($data);
		}

So this seems to work fine, I really should make one connection but other than that it's ok I guess

cluelessPHP

<div class="controlPanel">
<script>
  $(document).ready(function(){
  $("form").on("submit", function (event) {
  			$.ajax({
  				type: 'POST',
  				url: 'input.php',
  				data: $(this).serialize(),
  				success: function (data) {
  					$(".error").html(data);

			}
		});
		event.preventDefault();
		//console.log($(this).serialize());
	});
  });		

</script>
<h4>Chutes audit</h4>
<script>
  $(function(){
      $('.chuteAudit :input').on("invalid blur", function(e) {
          var ok = this.validity.valid
          var index=$(this).index()-1
          $(this).closest(".chuteAudit").find(".error").eq(index).text( ok?"":"Enter a number")
      });
      $("form").submit(function(){
          $.post(this.action,$(this).serialize(),function(response){
              $(".error").empty()
              console.log(response)
              var hasErrors=false
              $.each(response,function(name,error){
                  var field= $(document.getElementsByName(name)),
                      errorField = field.closest(".chuteAudit").find(".error").eq(field.index()-1)
                  errorField.text(error)
  //                   console.log(name,field,error)
                  hasErrors=hasErrors||error
              })

      },"JSON")
      return false
  })
  })
</script>	
<form name="auditform" action="input.php" method="POST">
  <label class="chutesTitle">Count </label>
  <label class="chutesTitle">Error</label>
  <?php
   require_once "connection.php";

$names = $db->prepare("
				SELECT sort
				FROM sorts WHERE section = 'chutes' AND active ='yes'
			");

 if($names->execute() == false) {
    die("<pre>Query failed:\n".print_r($names->errorInfo(),1)."</pre>");
}  
 $names = $names->fetchAll(PDO::FETCH_ASSOC);

				 foreach($names as $name):
				?>
  <div class="chuteAudit">
    <div>
      <label for="x1"><?php echo $name['sort']; ?></label>
      <input  type="hidden" name="sort[]" value="<?php echo $name['sort']; ?>" >
      <input  type="number" name="count[]"  required min="0">
      <input	type="number" name="error[]" required min="0">
    </div>
    <div class="errors">
      <span></span>
      <span class="error"></span>
      <span class="error"></span>
    </div>
  </div>
  <?php endforeach;?>
  <input type="submit" value="Submit" name="submit">
</form>

<?php
require_once "connection.php";

	$sort = $_POST['sort'];
	$count = $_POST['count'];
	$error = $_POST['error'];
	$rows = [];

if($count && $error !== null && is_numeric($count && $error )) 
{

	if (empty($count && $error))  
			{ 
				echo "Enter a number";
			}
	else
			{		
				$sql = 'INSERT INTO `audits` (`sort`, `countAudit`, `error`, `timeentered`) VALUES';
				$values = " (?,?,?, NOW()),";

	foreach($sort as $i=>$value)
			{
				$rows[] = [$sort[$i],$count[$i],$error[$i]];
			}

	foreach($rows as $row)
			{
				$sql = $sql . $values;
			}

	$sql = substr_replace($sql, "", -1);
	$stmt = $db->prepare($sql);
	$data = call_user_func_array('array_merge', $rows);
	$stmt->execute($data);

	}
}
else	{
			echo "Enter a number";
		}

Ok ok ok last edit it done this time, really..