Error in MyBB installation

halojoy

In a script there is this line that causes my installation give an error:

require_once MYBB_ROOT."inc/db_{$config['database']['type']}.php";

To fix this I did this, which works well:

require_once MYBB_ROOT."inc/db_".$config['database']['type'].".php";

Now, my question is why they have written like number one?
And why it does not work at my PHP server?

dalecosp

My guess would be they were planning to eval() it, or something similar (templating system, perhaps?) ...

What error did it give? E_PARSE, I presume?

I suppose it could also be an actual error, as in, somebody broke the build by adding those brackets ... Hmm.

Derokorian

dalecosp;11054373 wrote:
My guess would be they were planning to eval() it, or something similar (templating system, perhaps?) ...

What error did it give? E_PARSE, I presume?

I suppose it could also be an actual error, as in, somebody broke the build by adding those brackets ... Hmm.

Both should be functionally identical. The braces are simply complex string notation

halojoy

dalecosp;11054373 wrote:
My guess would be they were planning to eval() it, or something similar (templating system, perhaps?) ...

What error did it give? E_PARSE, I presume?

I suppose it could also be an actual error, as in, somebody broke the build by adding those brackets ... Hmm.

The error was that it returned 'db_.php'
Where the second code returns 'db_mysql.php'
so the part within curly brackets returned nothing.

That is at my PHP 5.6.19

dalecosp

Derokorian;11054383 wrote:
Both should be functionally identical. The braces are simply complex string notation

Well, that should be the case, but:

halojoy;11054391 wrote:
The error was that it returned 'db_.php'
Where the second code returns 'db_mysql.php'
so the part within curly brackets returned nothing.

That is at my PHP 5.6.19

So I'm not at all sure about this; AAMOF I can easily construct a test which duplicates the issue:

define('MYBB_ROOT',"/home/");

$database = array("type"=>"mysql");

$config = array($database); //should be "$config = array("database"=>$database);"

echo MYBB_ROOT."inc/db_{$config[database]['type']}.php";

However, the $config var isn't really constructed correctly in my example, which makes me wonder if my_bb has the same problem?

halojoy, what does "print_r($config);" show?

halojoy

The
$config['database']['type'] = 'mysql'; (or maybe mysqli)
This is the choice when installing.
Is needed to select correct file to create the tables in db.

require_once MYBB_ROOT."inc/db_{$config['database']['type']}.php";

gives the adress to the file.
There is no error except for the file can not be found (db_.php) instead of (db_mysql.php)

I can not give you the contents of $config, except for the 'mysql'.
But after I changed line not to have curly brackets installation works fine.

Weedpacket

However, the $config var isn't really constructed correctly in my example, which makes me wonder if my_bb has the same problem?

The reference to it also has a problem:

//should be "$config = array("database"=>$database);"
echo MYBB_ROOT."inc/db_{$config[database]['type']}.php";

No quotes around [font=monospace]database[/font] here means it gets treated as a constant (most likely one without a value).

halojoy

Yes, Weedpacket is right.
We need those {$config['database']['type']}
But then it should work. Question is why it does not work at my php server.
Can it be some setting in my php.ini?
Because I have not found any other user of myBB with the same problem.