record is not saving to database

reapersdawn

This is my table columns
admin_id username email password
admin_id is not null and increments when a new user is created.
The problem I am having is that its not saving the update to the database
Im not sure what im doing wrong but its likely the where clause.

<!DOCTYPE html>
<html>
<body>
   <?php
// variables
$username = $_POST['username'];
$email = $_POST['email'];
$password = hash('sha512', $_POST['password']);
$admin_id = $_POST['admin_id'];


$page_title = null;
$page_title = 'Update admin';
require_once('header.php');
// connects

require_once('db.php');


 $sql = "UPDATE Admin SET username = :username, email = :email, password = :password, admin_id = :admin_id";

$cmd = $conn->prepare($sql);
$cmd->bindParam(':admin_id', $admin_id, PDO::PARAM_INT);
$cmd->bindParam(':username', $username, PDO::PARAM_STR, 50);
$cmd->bindParam(':email', $email, PDO::PARAM_STR, 50);
$cmd->bindParam(':password', $password, PDO::PARAM_STR, 50);

$cmd->execute();
$Admin = $cmd->fetchAll();

$cmd->execute();



$conn = null;
require_once('footer.php');
 ?>



</body>
</html>

dalecosp

Hmm. A SHA-512 hash of a string is gonna be way longer than 50 chars. Dunno if that's the issue, but you should probably account for that?

And what WHERE clause are you talking about? I don't see one.

Do you only have one "Admin account" to set passwords for?

Please consider using [noparse]

[/noparse] tags around your code as well. Make for better legibility and does some syntax checking for us ...

NogDog

I'd recommend that you test the return values from the prepare and execute methods, and if they return false, throw an exception or something for now in order to find out what's wrong.

$cmd = $conn->prepare($sql)
if($cmd == false) {
    throw new Exception(print_r($conn->errorInfo(),1));
}
// . . .
if($cmd->execute() == false) {
    throw new Exception(print_r($cmd->errorInfo(),1));
}

Weedpacket

As well as what the others have said, you're executing the update statement twice; and what are you hoping to fetch in between?

reapersdawn

Ive deleted the update twice statement.
I forgot that im trying to update where the admin_id. Ive changed it already in my code.