[RESOLVED] invalid argument supplied for foreach

schwim

Heya folks!

I'm utilizing Verot's upload class and it's asking me to run the following foreach on the upload array before handling it. This same nested foreach loop exists on their demo page and is operating as intended, but when I use it to populate my $files array, it posts 5 duplicate errors for the same line.

	$files = array();

foreach ($_FILES['ci_image'] as $k => $l) {
	foreach ($l as $i => $v) {
		if (!array_key_exists($i, $files))
			$files[$i] = array();
		$files[$i][$k] = $v;
	}
}

Which is resulting in the following error:

Invalid argument supplied for foreach()

A vardump of my files array the following:

array(5) {
["name"]=>
string(5) "0.png"
["type"]=>
string(9) "image/png"
["tmp_name"]=>
string(14) "/tmp/php6ywAIJ"
["error"]=>
int(0)
["size"]=>
int(1436)
}

Could anyone tell me why this is resulting in an error and how I might resolve the issue?

Thanks a bunch!

sneakyimp

You can't run a [man]foreach[/man] on something that doesn't behave as an array. It should be clear from your var_dump of $FILES that there's no such thing as $FILE["ci_image"]

schwim

Thanks a bunch for your help!

I'm very confused. My var_dump was of $FILES['ci_image']. What am I doing wrong that it's not creating the proper $FILES array? My form looks like the following:

<form name="image" enctype="multipart/form-data" method="POST" action="/?action=overlord&do=ci-imgup&id=2">
	<input type="file" size="50" name="ci_image" value="Browse"><br>
	<br>
	<input type="submit" name="Submit" value="Upload">
	</form>

And my foreach that is erroring is inside

if(ISSET($_FILES['ci_image'])){

so it seems to be seeing the array. What have I messed up that it's not behaving like one?

dalecosp

$FILES is an array, but the individual members of $FILES are not arrays, and should not be: http://php.net/manual/en/features.file-upload.post-method.php

So your var_dump looks fine. Their code looks funny, because for one image, there'd be no data structure like the one they're attempting to handle.

Is there any chance that there demo page is expecting more than one image to be uploaded, and you're only uploading one?

How does there upload form differ from your upload form?

sneakyimp

Your post is also ambiguous -- you say "a vardump of my files array..." but then insist you are instead var_dumping $_FILES["ci_image"] instead.

dalecosp is right that the nested foreach loops you have look a little weird. Maybe you should try naming your input ci_image[] instead of ci_image.

schwim

Hi there Dale, and thanks for your help!

Oh, what a difference some simple []brackets make 🙂

I'll mark this one as solved.