[RESOLVED] Looping throgh an array including the use of in_array

blackbox

Hi all,

I am woring on a script where I need to do the following.

I run a MysQL query which returns a row of data.

$row_RoomAudit = mysql_fetch_assoc($RoomAudit);

Then using that data array I am using "in_array" to find out if each of the array elements contains a 1 (one).

$SeqData = array($row_RoomAudit['SeqID1301'],$row_RoomAudit['SeqID1302'],$row_RoomAudit['SeqID1303'],$row_RoomAudit['SeqID1304'],$row_RoomAudit['SeqID1305'],$row_RoomAudit['SeqID1306'],$row_RoomAudit['SeqID1307'],$row_RoomAudit['SeqID1308'],$row_RoomAudit['SeqID1309'],$row_RoomAudit['SeqID1310']);

and so on.......

At this point I then need to strip out the first 5 character from each of the array elements; which reduces the element name to:

1301,1302,1303,1304 and so no........

I then need to perform a MySQL query to lookup records from a table where the new (reduced element names) match a field in the table.


foreach ($row_RoomAudit as $key => $val) {
	if (strpos($val, '1') !== FALSE && substr( $key, 0, 3)=='Seq' ){

            mysql_select_db($database_rose, $link);
	$query_QuestionLookup = sprintf("SELECT SeqHeader, SeqText FROM SequenceNo WHERE SeqID = '".$key."'");
	$QuestionLookup = mysql_query($query_QuestionLookup, $link) or die(mysql_error());
	$row_QuestionLookup = mysql_fetch_assoc($QuestionLookup);
	$totalRows_QuestionLookup = mysql_num_rows($QuestionLookup);

	$seq = $key;
   }
}

I then need to output the returned rows.

At the moment the script returns the correct data but also the content of the "$row_RoomAudit" array.

SeqID1302 Vanity Basin - Taps Taps - Not Secure / Leaking - Repair
SeqID1302 SeqID1303 Vanity Basin - Taps Vanity Basin - Taps Taps - Not Secure / Leaking - Repair Pop Up Stoppers or Plug - Requires Adjusting
SeqID1302 SeqID1303 SeqID1304 Vanity Basin - Taps Vanity Basin - Taps Vanity Basin - Taps Taps - Not Secure / Leaking - Repair Pop Up Stoppers or Plug - Requires Adjusting Stained / Discoloured / Limescale Visible/ Tarnished - Repair
SeqID1302 SeqID1303 SeqID1304 SeqID1305 Vanity Basin - Taps Vanity Basin - Taps Vanity Basin - Taps Vanity Basin Taps - Not Secure / Leaking - Repair Pop Up Stoppers or Plug - Requires Adjusting Stained / Discoloured / Limescale Visible/ Tarnished - Repair Sink Cracked
SeqID1302 SeqID1303 SeqID1304 SeqID1305 SeqID1601 Vanity Basin - Taps Vanity Basin - Taps Vanity Basin - Taps Vanity Basin Toilet Taps - Not Secure / Leaking - Repair Pop Up Stoppers or Plug - Requires Adjusting Stained / Discoloured / Limescale Visible/ Tarnished - Repair Sink Cracked Bowl - Damaged/Cracked
SeqID1302 SeqID1303 SeqID1304 SeqID1305 SeqID1601 SeqID1602 Vanity Basin - Taps Vanity Basin - Taps Vanity Basin - Taps Vanity Basin Toilet Toilet Taps - Not Secure / Leaking - Repair Pop Up Stoppers or Plug - Requires Adjusting Stained / Discoloured / Limescale Visible/ Tarnished - Repair Sink Cracked Bowl - Damaged/Cracked Seat Loose or New Seat Needed - Repair/Replace
SeqID1302 SeqID1303 SeqID1304 SeqID1305 SeqID1601 SeqID1602 SeqID1603 Vanity Basin - Taps Vanity Basin - Taps Vanity Basin - Taps Vanity Basin Toilet Toilet Toilet Taps - Not Secure / Leaking - Repair Pop Up Stoppers or Plug - Requires Adjusting Stained / Discoloured / Limescale Visible/ Tarnished - Repair Sink Cracked Bowl - Damaged/Cracked Seat Loose or New Seat Needed - Repair/Replace Toilet Flush - Overflow Running/Handle Not Secure - Repair
SeqID1302 SeqID1303 SeqID1304 SeqID1305 SeqID1601 SeqID1602 SeqID1603 SeqID1604 Vanity Basin - Taps Vanity Basin - Taps Vanity Basin - Taps Vanity Basin Toilet Toilet Toilet Toilet Taps - Not Secure / Leaking - Repair Pop Up Stoppers or Plug - Requires Adjusting Stained / Discoloured / Limescale Visible/ Tarnished - Repair Sink Cracked Bowl - Damaged/Cracked Seat Loose or New Seat Needed - Repair/Replace Toilet Flush - Overflow Running/Handle Not Secure - Repair Limescale Visible
SeqID1302 SeqID1303 SeqID1304 SeqID1305 SeqID1601 SeqID1602 SeqID1603 SeqID1604 SeqID1605 Vanity Basin - Taps Vanity Basin - Taps Vanity Basin - Taps Vanity Basin Toilet Toilet Toilet Toilet Toilet Taps - Not Secure / Leaking - Repair Pop Up Stoppers or Plug - Requires Adjusting Stained / Discoloured / Limescale Visible/ Tarnished - Repair Sink Cracked Bowl - Damaged/Cracked Seat Loose or New Seat Needed - Repair/Replace Toilet Flush - Overflow Running/Handle Not Secure - Repair Limescale Visible Poor Grouting/Sealant/Strip - Repair

What I am look for is the returned data to look like:

SeqID1302 Vanity Basin - Taps - Not Secure / Leaking - Repair
SeqID1303 Vanity Basin - Pop Up Stoppers or Plug - Requires Adjusting
SeqID1304 Vanity Basin - Stained / Discoloured / Limescale Visible/ Tarnished - Repair
SeqID1305 Vanity Basin - Sink Cracked
SeqID1601 Toilet - Bowl - Damaged/Cracked
SeqID1602 Toilet - Seat Loose or New Seat Needed - Repair/Replace
SeqID1603 Toilet - Toilet Flush - Overflow Running/Handle Not Secure - Repair
SeqID1604 Toilet - Limescale Visible
SeqID1605 Toilet - Poor Grouting/Sealant/Strip - Repair

I know I am doing something wrong but after many attempts to get this working I failed.

Any help you can provide would be great. Many thanks in advance for your time.

Cheers.

pbismad

The problem with the output is in the code that's using the data. It's most likely concatenating each new value to the existing data and echoing the combined result at each iteration. Where is the portion of your code that's using the data and producing and echoing the output?

Next, I looked at your previous database related threads, to try and figure out what you are doing, since this thread doesn't contain any of the code that's using the data and producing the (wrong) output, and your data is not normalized. By having the data organized like it is, all the queries (you should not run related select queries inside of loops) and php code to insert, find, retrieve, and display the data is overly complicated and hard to make work, as you have discovered. If you normalize the data (you should not have sequentially named columns), you could just run one JOINed query to get all the data that you want, then just loop over that data and produce the output that you want.

sneakyimp

$row_RoomAudit = mysql_fetch_assoc($RoomAudit);

First, you should not use the [man]mysql[/man] functions because they are as old as your grandma's wooden bra. Use [man]mysqli[/man] or [man]PDO[/man] instead to connect to your database.

Secondly, mysql_fetch_assoc doesn't return an array of records but rather one single record. Maybe try adding this line after that one so you can inspect the contents of $row_RoomAudit. I don't think it's going to look the way you think it does:

$row_RoomAudit = mysql_fetch_assoc($RoomAudit);
var_dump($row_RoomAudit);
die();

pbismad

Secondly, mysql_fetch_assoc doesn't return an array of records but rather one single record

The OP has a table with 160+ seqid+numerical named columns, one column for each possible choice. The code in this thread is looping over the columns that have been fetched from a row in that table and is then querying for the text from the second table that corresponds to the numerical part of the first table's column name, for the columns that have a one stored in them.

blackbox

Hi guys,

Yoiu are both right so I have completely rewritten the code and I am in the process of testing. Many thanks for your input.