Please help with my downtime project

cif

Hi,

I'm trying to do a project for calculating the downtime for an equipment.
for this i need to take the current time when page opens, another current time whent the Tech person arrives to that equipment, and another time when the tech intervention is completed. So, when the page opens, I take the time in $var1= date('Y-m-d H:i:s');, Whent the tech guy scans his badge, the new current time is taken in $var2. The problem is that at this point, the var1 also takes the new time value. What am i doing wrong? Please point me to the right direction.

maxxd

Tough to tell without code - there could be any number of things going on.

cif

maxxd;11057761 wrote:
Tough to tell without code - there could be any number of things going on.

Here is the page:

<?php
//error_reporting(0);
$starttime = date('Y-m-d H:i:s');
$con = mysql_connect ("localhost","my user","my pass");
mysql_select_db("downtime", $con);

session_start();

if(isset($REQUEST['station_id'])) {
$SESSION['station_id'] = $_REQUEST['station_id'];
}

if (empty($_SESSION['station_id'])) {
die('Invalid station id ...');
}

$station_id = $SESSION['station_id'];
$answer = $SESSION['station_id'];

function mysql_query_or_die($query) {
$result = mysql_query($query);
if ($result)
return $result;
else {
$err = mysql_error();
die("<br>{$query}<br> {$err} <br>");
}
}

$query = 'SELECT * FROM stations WHERE id='.$station_id.' ORDER BY ID';
$result = mysql_query_or_die($query);

echo("<table>");
$first_row = true;
while ($row = mysql_fetch_assoc($result)) {
if ($first_row) {
$first_row = false;
echo '<tr>';
foreach($row as $key => $field) {
}
echo '</tr>';
}
echo '<tr>';
foreach($row as $key => $field) {

$linie = $row['line_id'];
$desc = $row['descriere'];
$statie = $row['station_id'];
}
echo '</tr>';
}
echo("</table>");

function ShowError($text) {
echo '<div style="border: 1px solid #ff0000; padding: 5px; background #ffa3a3a">';
echo $text;
echo '</div>';
}

function MapRequest($name, $default) {
if (!isset($_REQUEST[$name])) {
return $default;
}

return $_REQUEST[$name];

}
$user_id = MapRequest('user_id',0);

$techtime = date('Y-m-d H:i:s');

if ($user_id > 0) {

$query = 'SELECT * FROM users WHERE user_id='. $user_id.'';
$result = mysql_query($query);
if(is_resource($user_id) && mysqli_num_rows($user_id) == 1){
	//HERE I NEED TO TAKE A SECOND TIME THE DATE()
	$techtime = date('Y-m-d H:i:s');
	//echo 'Tehnician prezent la: '.$techtime;

}
else {
	$userid1 = "Nealocat";
}
//echo mysql_error();

echo("<table>");
$first_row = true;
while ($row = mysql_fetch_assoc($result)) {
	echo '<tr>';
	echo '</tr>';
	$userid1 = $row['user_id'];
	$nume1 = $row['name'];
		}
echo("</table>");

}

<html>
<head>
<style type="text/css">
.container {
width: 500px;
clear: both;
}
.container input {
width: 100%;
clear: both;
}

</style>

</head>
<body>

<div class="container" style="border: 5px solid #555; position: absolute; top: 10px; left: 300px; width: 500px; height: 110px; background-color: red;">
<font size = "6">S-a deschis un incident de pe statia <?php echo $station_id;?> Linia: <?php echo $linie;?>; Post: <?php echo $statie;?>; <?php echo $desc;?>; </font>
</div>

<br />
<div style="border: 5px solid #555; position: absolute; top: 130px; left: 300px; width: 500px; height: 300px; background-color: lightblue;">
<form action="newindex.php" method="post">
<font size = "6">Numar personal Maintenance</font><br />
<input type="text" name="user_id" autofocus><br /><br />
<input type="submit" id="submit" name="submit" value="Introducere"/>
<br /><br />
<font size = "5">Incident deschis la: <?php echo $starttime;?> </font>
<br /><br />
<font size = "6">Tehnician: <?php echo $userid1;?> -- <?php echo $nume1;?>; </font>
<br /><br />
<font size = "5">Prezent la: <?php echo $techtime;?> </font>
<br />
</form>

Weedpacket

Please use the formatting tags described in the FAQs to format your code.

And try reducing the amount of code that you need to post. I scrolled through that and I didn't even see a [font=monospace]$var2[/font]. Remove parts that seem irrelevant, check that the problem persists, and repeat. Then post what's left.

Oh, and the MySQL extension is obsolete. Don't use it.

pbismad

Web servers are stateless. Each page request is completely separate from all other page requests and all regular program variables are destroyed when the code execution ends for each individual page request.

For you to be able to 'remember' the different times events occurred will require that you store those values somewhere.

Some choices to store data would be -

1) database table. This is the most general purpose method and would allow the different times to be entered from any browser. The data values would be tied together using the equipment id.

2) session variables. This will require that one browser be used to enter all related values and that the browser remains open so that the session isn't lost and that the session garbage collection on the server is set long enough so that the session data isn't deleted.

3) cookies. This will require that one browser be used to enter all related values and that the cookie lifetime is set long enough so that the data isn't lost.

Edit: One of the points of using functions is to clarify and de-clutter the main code. By leaving the function definitions in the main code, wherever you decided to define them, doesn't accomplish that goal. You should move all function definitions to either an external file that gets required by the main code or to a common location in your main file so that they are not interspersed with the main program logic.

maxxd

Let's focus on the code right around where you say you're having issues.

function MapRequest($name, $default) {
	if (!isset($_REQUEST[$name])) {
		return $default;
	}
	return $_REQUEST[$name];
}
$user_id = MapRequest('user_id',0);
$techtime = date('Y-m-d H:i:s');

if ($user_id > 0) {
	$query = 'SELECT * FROM users WHERE user_id='. $user_id.'';
	$result = mysql_query($query);
	if(is_resource($user_id) && mysqli_num_rows($user_id) == 1){
		//HERE I NEED TO TAKE A SECOND TIME THE DATE()
		$techtime = date('Y-m-d H:i:s');
		//echo 'Tehnician prezent la: '.$techtime;
	}
	else {
		$userid1 = "Nealocat";
	}
//echo mysql_error();
	echo("<table>");
	$first_row = true;
	while ($row = mysql_fetch_assoc($result)) {
		echo '<tr>';
		echo '</tr>';
		$userid1 = $row['user_id'];
		$nume1 = $row['name'];
	}
	echo("</table>");
}

First and foremost, if a variable named 'user_id' exists in $GET, $POST, or $COOKIES, MapRequest() simply returns the value of that variable - wherever it may be set. Which means that even if you're submitting your form via $POST, if someone appends "&user_id=42" to the URL - or creates a 'user_id' cookie in the browser development tools - but doesn't supply a user id in the actual form he or she is submitting, the system will use 42 and not the 0 default you've set up. I should think the security implications of this don't need explaining. If you know where to expect user_id, look there - and only there - for the value.

Secondly, you're using your MapRequest() function to assign a number to $user_id. You're then using that number as a unique ID in your 'users' table. So it's clearly supposed to be an integer. However, then you turn around and check to see if it's a resource and if that resource has only one row in it. It's an integer, remember? I think you want to use $result there, not $user_id. On top of that, you're using mysqlinum_rows() here. You've been using mysql throughout the rest of the code. I would recommend PDO, personally, but if you're into mysqli() then use it throughout. Either way, mysql_ functions have been deprecated for years and have been removed from 7.0.

Now, I'm assuming that you've cut code from your while() loops because they don't actually do anything. The one listed above will output a malformed table with only rows and no actual data therein. Again, I assume you know this and have cut the extraneous code, but just in case.

And finally, you're not sanitizing any data at all before using it to interact with the database. You're blindly assigning values from $SESSION (or, in most cases here, $REQUEST - see the first paragraph above) and sending them straight to the database. This is very dangerous. Never trust user input - this is where PDO will help you in the long run. Use prepared statements and you won't have this issue. MySQLi also has prepared statements, but in my opinion PDO is much easier to work with.

I don't know what your level of experience is with PHP, but the code could be a lot cleaner and safer if it was slightly better thought out. As pbismad alludes to in his edit, consolidate your functions at the top of the file and call them from within the file itself. Obviously separating the display and business logic entirely by using a template system would be the ideal here, even what I just described will make it much easier for you to read and maintain your own code.

edited Apparently $REQUEST doesn't include $SESSION. I could've sworn it did.

cif

Thank you for your reply, maxxd. My level of experience with PHP is about almost two weeks now :o I'm learning while i'm doing it.

In the mean time i have separated the functions from the main page, cleaned a bit the script and made some progress:
This is functions page:

<?php

function fetchRows($sql) {
	$res = mysql_query($sql);
	$rows = array();
	while ($row = mysql_fetch_assoc($res)) {
		$rows[] = $row;
	}

return $rows;
}

function fetchRow($sql) {
	$res = mysql_query($sql);
	return mysql_fetch_assoc($res);
}

function getOpenedDowntime() {
	$row = fetchRow('SELECT * FROM records WHERE state < 3');

if ($row['id'] != 0) {
	return $row;

}

return false;
}

function getUserData($user_id) {
	$row = fetchRow('SELECT * FROM users WHERE user_id= '. $user_id);

if ($row['user_id']) {
	return $row;
}

return false;

}

function mysql_query_or_die($query) {
    $result = mysql_query($query);
    if ($result)
        return $result;
    else {
        $err = mysql_error();
        die("<br>{$query}<br>*** {$err} ***<br>");
    }
}

function ShowError($text) {
	echo '<div style="border: 1px solid #ff0000; padding: 5px; background #ffa3a3a">';
	echo $text;
	echo '</div>';
}

function MapRequest($name, $default) {
	if (!isset($_REQUEST[$name])) {
		return $default;
	}

return $_REQUEST[$name];
}

function getDowntimeStateLabel($state) {
	switch ($state) {
		case 0:
			return 'Deschis';
			break;
		case 1:
			return 'Preluat';
		case 2:
			return 'Inchis';
		case 4:
			return 'Validat';
		default:
			return 'Necusnoscut';
	}
}

And this is the main page now:

<?php

require_once 'lib/functions.php';
date_default_timezone_set('Europe/Bucharest');

$starttime = date('Y-m-d H:i:s');
$con = mysql_connect ("localhost","root","");
mysql_select_db("downtime", $con);

session_start();

$GlobalState = -1;


if(isset($_REQUEST['station_id'])) {
	$_SESSION['station_id'] = $_REQUEST['station_id'];

}

if (empty($_SESSION['station_id'])) {
	die('Invalid station id ...');
}

$station_id = $_SESSION['station_id'];
$answer = $_SESSION['station_id'];


$query = 'SELECT * FROM stations WHERE id='.$station_id;
$result = mysql_query_or_die($query);

$first_row = true;

$row = mysql_fetch_assoc($result);

if ($row){

	$linie = $row['line_id'];
	$statie = $row['station_id'];
}
else{
	echo " Station id invalid or shortcut was altered. Please contact me";
	die();
}

$sql = "INSERT INTO records (station_id, line_id) VALUES ('$statie','$linie')";
mysql_query($sql);
$downtime = getOpenedDowntime();
if ($downtime != false ) { 
?>

<div class="container" style="border: 5px solid #555; position: absolute; top: 10px; left: 670px; width: 500px; height: 110px; background-color: red;">
<font size = "6">Avem un incident deschis pe aceasta statie cu starea: <?php echo getDowntimeStateLabel($downtime['state']); ?> la ora <?php echo $downtime['open_time']; ?> </font>
</div>

<?php }
$recId = getOpenedDowntime();
$GlobalState = $recId['state'];
$curId = $recId['id'];
echo "Current state is: ".$GlobalState." avem incident deschis";

//Verificam daca am primit un barcode scanat si facem update-ul la interventie in fucntie de state

$user_id = MapRequest('user_id',0);
$userData = false;
if ($user_id > 0) {

$userData = getUserData($user_id);

if ($userData === false) {
	ShowError('Userul scanat nu exista: ' . $user_id);
	exit();
}
}

if(is_array($userData)) {
	$badge = $userData['user_id'];
	$nume = $userData['name'];

$GlobalState = 1;
$techtime = date('Y-m-d H:i:s');
echo "Current state is: ".$GlobalState." avem incident preluat";
$sql = "UPDATE records SET take_user_id='$badge',take_user_name='$nume',take_time='$techtime',state='.$GlobalState.' WHERE `id` = ".$curId;
mysql_query($sql);	

}

//$downtime = getOpenedDowntime();
//close field
?>

<html>

<body>
<!--
-->
<!--
-->
<br />

<div style="border: 5px solid #555; position: absolute; top: 130px; left: 670px; width: 500px; height: 120px; background-color: lightblue;">
<form method="get">
<font size = "6">Scaneaza ID Tehnician</font><br />
<input type="text" name="user_id" autofocus>
<input type="submit" value="Introducere"/>
</form>
</div>
<br /><br />
<div style="border: 5px solid #555; position: absolute; top: 250px; left: 670px; width: 500px; height: 120px; background-color: lightblue;">
<form method="post">
<font size = "6">Scaneaza ID pentru a inchide incidentul</font><br />
<input type="text" name="user_id1">
<input type="submit1" value="Inchidere"/>
</form>
</div>
<div style="border: 5px solid #555; position: absolute; top: 370px; left: 3px; width: 1100px; height: 400px; background-color: lightgray;">
<font size = "6">Demo purposes only</font><br />
<?php

$query = "SELECT * FROM records";
$result = mysql_query_or_die($query);
echo("<table>");
$first_row = true;
while ($row = mysql_fetch_assoc($result)) {
    if ($first_row) {
        $first_row = false;
			echo '<tr>';
        foreach($row as $key => $field) {
            echo '<th>' . htmlspecialchars($key) . '</th>';
        }
        echo '</tr>';
    }
    echo '<tr>';
	    foreach($row as $key => $field) {
        echo '<td>' . htmlspecialchars($field) . '</td>';
    }
    echo '</tr>';
}
echo("</table>");
?>
</div>

One of the problems is that when i read the technician ID, it inserts a second record in database. I can't figure out why. 😕

dalecosp

You have INSERT code:

$sql = "INSERT INTO records (station_id, line_id) VALUES ('$statie','$linie')"; 
mysql_query($sql);

and it's not wrapped in any conditional statement, so each time this script is executed ("page is loaded") the system will INSERT a new row into your database table.

Is there supposed to be some condition met before an INSERT occurs? Or, perhaps, you should first check to see if the data is already in the table and then, if it is, perform an UPDATE instead?

pbismad

I still don't see anywhere in your code where you are 'persistently' storing the times. The startime is still being unconditionally set every time the page gets requested. Until you store the startime, techtime, and completion time somewhere (it looks like you are using a database table), you don't have any data upon which to produce a report.

There are two concerns that your code is dealing with. The first concern is recording the information. This should be handled using post method forms and php code to detect the form submission and use the submitted form data. The second concern is displaying information based on the recorded information.

It would be better if you first defined the data you have/need and the 'work-follow' you need to accomplish this task -

It appears that this page is reached by someone/something submitting a form (you should not use $REQUEST, but use the actual $GET, $POST, or $COOKIE variables where the data is coming from) that submits the statation_id of the equipment that just went 'down' (a second field in the submitted form data would indicate the 'down' state).

If there isn't an 'open' downtime record for this station_id, you would INSERT a new record into the records database table, with the station_id and the current time as the start time. You don't need to store the line id, because the line id for any station id is already stored in the stations table. You should not store the same data in multiple places.

If there is already an 'open' downtime record for this station_id, you need to decide what action your code should take. If there can only be one open record at a time for each station_id, you would ignore the duplicate request.

When the technician enters/scans his badge and that form is submitted, the code now knows the user_id and the techtime (from the current time), you would UPDATE the correct record with these two pieces of data. It's not clear how you are tying this to the station_id, since there can be any number of different stations/equipment that are 'down' at any one time. If you are assuming that one browser is going to be used exclusively at one/for a station for the duration of a down time event, you can store the station id in a session variable, like your code is doing now.

When the technician finishes and the machine is returned to the 'up' state, a form would need to be submitted that submits the correct station id (if you are assuming one browser = one station_id, you can omit this value) and a field for the 'up' state. The code now knows the completion time (from the current time) and the station_id. You would UPDATE the correct record with the completion time.

At any point, by looking at what values are present in the database table record(s), you can display the status -

1) If only the startime is present, the status is 'waiting for a technician'.

2) If the startime and the techtime are present, the status is 'being worked on'.

3) If the completion time is present, the status is 'complete'.

Displaying the line name, or technician name is part of the display process. You would JOIN the user_id and station_id from the records table with the users table and the stations table to get this secondary information.

By separating the concerns in your code, it will be easier to write and test your code, since one section of code is only dealing with processing form submissions and inserting/updating the record(s) in the database table and the other section of code is only dealing with retrieving data and deciding what to display on the page.

cif

Thank you for your replies. Here is how my DB(downtime) tables are:
Stations - contains ID(auto increment), station_id, line_id(on what project that specific pc is) and description of the PC's

Users - contains ID(auto increment), user_id(int) - users badge nr., and name name

records - ID - autoincrement
- line_id - int - from stations
- station_id - int - from URL
- open_time - timestamp - default CURRENT_TIMESTAMP - this is the initial time
- take_user_id - int - tech guy who takes the incident(from users)
- take_user_name - tech guy's name(from users)
- take_time - timestamp - from $techtime
close_user_id - int - from users
close-time - timestamp - from $closetime
state - int - default 0 - for figuring out a way how to check the state of the incident:
0 - open
1 - taken
2 - closed
(3 - perhaps validated)

pbismad, thank you for your suggestions. i see i have to study better 🙂

cif

dalecosp;11057819 wrote:
You have INSERT code:
$sql = "INSERT INTO records (station_id, line_id) VALUES ('$statie','$linie')"; 
mysql_query($sql); 
and it's not wrapped in any conditional statement, so each time this script is executed ("page is loaded") the system will INSERT a new row into your database table.

Is there supposed to be some condition met before an INSERT occurs? Or, perhaps, you should first check to see if the data is already in the table and then, if it is, perform an UPDATE instead?

I tried to think some conditions, but i am thinking in the wrong direction. and i'm stuck. please see my "progress":
Functions:

<?php

function fetchRows($sql) {
	$res = mysql_query($sql);
	$rows = array();
	while ($row = mysql_fetch_assoc($res)) {
		$rows[] = $row;
	}

return $rows;
}
//---------------------------------------------------------------------
function fetchRow($sql) {
	$res = mysql_query($sql);
	return mysql_fetch_assoc($res);
}
//---------------------------------------------------------------------
function getOpenedDowntime() {
	$row = fetchRow('SELECT * FROM records WHERE state < 3');

if ($row['id'] != 0) {
	return $row;
}

return false;
}
//---------------------------------------------------------------------

//---------------------------------------------------------------------
function getUserData($user_id) {
	$row = fetchRow('SELECT * FROM users WHERE user_id= '. $user_id);

if ($row['user_id']) {
	return $row;
}

return false;
}
//---------------------------------------------------------------------
function mysql_query_or_die($query) {
    $result = mysql_query($query);
    if ($result)
        return $result;
    else {
        $err = mysql_error();
        die("<br>{$query}<br>*** {$err} ***<br>");
    }
}
//---------------------------------------------------------------------
function ShowError($text) {
	echo '<div style="border: 1px solid #ff0000; padding: 5px; background #ffa3a3a">';
	echo $text;
	echo '</div>';
}
//---------------------------------------------------------------------
function MapRequest($name, $default) {
	if (!isset($_REQUEST[$name])) {
		return $default;
	}
	return $_REQUEST[$name];
}
//---------------------------------------------------------------------
function CloseRequest($name, $default) {
	if (!isset($_REQUEST[$name])) {
		return $default;
	}
	return $_REQUEST[$name];
}
//---------------------------------------------------------------------
function getDowntimeStateLabel($state) {
	switch ($state) {
		case 1:
			return 'Deschis';
			break;
		case 2:
			return 'Preluat';
			break;
		case 3:
			return 'Inchis';
			break;
		case 4:
			return 'Validat';
		default:
			return 'Necunoscut';
	}
}
//---------------------------------------------------------------------

?>

and the page:

<?php
require_once 'lib/functions.php';
date_default_timezone_set('Europe/Bucharest');
//conectare la baza de date
$con = mysql_connect("localhost", "root", "");
mysql_select_db("downtime");
//verificare daca avem incident deschis de pe statia curenta

session_start();
$GlobalState = -1;
// SESSION VALIDATION

if (isset($_REQUEST['station_id'])) {
    $_SESSION['station_id'] = $_REQUEST['station_id'];
    $GlobalState = 1;
}

if (empty($_SESSION['station_id'])) {
  die('Invalid station id ...');
}

$station_id = $_SESSION['station_id'];
$answer = $_SESSION['station_id'];


// STATION VALIDATION
$query = 'SELECT * FROM stations WHERE id=' . $station_id;
$result = mysql_query_or_die($query);
$first_row = true;
$row = mysql_fetch_assoc($result);
if ($row) {
    $linie = $row['line_id'];
    $statie = $row['station_id'];
} else {
    echo " Station id invalid or shortcut was altered. Please contact me";
    die();
}

echo $GlobalState;

//Chestia asta se face doar daca nu avem inrerventie deschisa si s=-a sacant un un badge/userid

// sau nu. interventia se deschide cand apesi hotkey.

//verifica ora!

if ($GlobalState == 1) {
$sql = "INSERT INTO records (station_id, line_id, state) VALUES ('$statie','$linie','.$GlobalState.')";
mysql_query($sql);
}

if ($GlobalState > 1){
	exit;
	}

$downtime = getOpenedDowntime();
if ($downtime != false) {
	if ($GlobalState == 1){
?>
    <div class="container"
         style="border: 5px solid #555; position: absolute; top: 10px; left: 670px; width: 500px; height: 110px; background-color: red;">
        <font size="6">Avem un incident deschis pe aceasta statie cu
            starea: <?php echo getDowntimeStateLabel($downtime['state']); ?> la
            ora <?php echo $downtime['open_time']; ?> </font>
    </div>
<?php }
}
//
$recId = getOpenedDowntime();
//$GlobalState = $recId['state'];
$curId = $recId['id'];
$user_id = MapRequest('user_id', 0);
$userData = false;
if ($user_id > 0) {
    $userData = getUserData($user_id);
    $GlobalState = 2;
    if ($userData === false) {
        ShowError('Userul scanat nu exista: ' . $user_id);
        exit();
    }


// AICI VINE TOATA LOGICA ....




}
if ($recId['state']== 1) {
    ?>
    <div
        style="border: 5px solid #555; position: absolute; top: 130px; left: 670px; width: 500px; height: 120px; background-color: lightblue;">
        <form action="newindexsz.php" method="post">
            <font size="6">Scaneaza ID Tehnician</font><br/>
            <input type="text" name="user_id" autofocus>
            <input type="submit" value="Introducere"/>
        </form>
    </div>
<?Php
}

if (is_array($userData)) {
    $badge = $userData['user_id'];
    $nume = $userData['name'];
    $taketime = date('Y-m-d H:i:s');
    $sql = "UPDATE records SET take_user_id='$badge',take_user_name='$nume',take_time='$taketime',state='.$GlobalState.' WHERE `id` = " . $curId;
    mysql_query($sql);
}
//$NewState = getOpenedDowntime($downtime['state']);


if ($recId['state'] == 2) {
    ?>
    <div
        style="border: 5px solid #555; position: absolute; top: 250px; left: 670px; width: 500px; height: 120px; background-color: lightblue;">
        <form action="newindexsz.php" method="post">
            <font size="6">Scaneaza ID pentru a inchide incidentul</font><br/>
            <input type="text" name="closeuser">
            <input type="submit" value="Inchidere"/>
        </form>
    </div>
<?php
}

$close_user = getOpenedDowntime();
$badge1 = $close_user['take_user_id'];
$nume1 = $close_user['take_user_name'];
$var1 = $_POST['closeuser'];
if ($var1 != $close_user['take_user_id']) {
    $closetime = date('Y-m-d H:i:s');
    $GlobalState = 3;
    $sql = "UPDATE records SET close_user_id='$badge1',close_user_name='$nume1',close_time='$closetime',state='.$GlobalState.' WHERE `id` = " . $curId;
    mysql_query($sql);
}

$userData1 = getUserData($user_id);
if(is_array($userData1)) {
	$badge1 = $userData['user_id'];
	$nume1 = $userData['name'];
	$closetime = date('Y-m-d H:i:s');
	$GlobalState = 3;
	$sql = "UPDATE records SET close_user_id='$badge1',close_user_name='$nume1',close_time='$closetime',state='.$GlobalState.' WHERE `id` = ".$curId;
	mysql_query($sql);
}

$state = 3;
switch ($state){
	case getDowntimeStateLabel($state): break;
}


?>

<html>
<body>
<div
    style="border: 5px solid #555; position: absolute; top: 450px; left: 3px; width: 1200px; height: 120px; background-color: lightblue;">
<?php
    $query = "SELECT * FROM records";
    $result = mysql_query_or_die($query);
    echo("<table>");
    $first_row = true;
    while ($row = mysql_fetch_assoc($result)) {
        if ($first_row) {
            $first_row = false;
            echo '<tr>';
            foreach ($row as $key => $field) {
                echo '<th>' . htmlspecialchars($key) . '</th>';
            }
            echo '</tr>';
        }
        echo '<tr>';
        foreach ($row as $key => $field) {
            echo '<td>' . htmlspecialchars($field) . '</td>';
        }
        echo '</tr>';
    }
    echo("</table>");

?>
</div>

cif

Small update: now kinda works 🙂

main page:

<?php
require_once 'lib/functions.php';
date_default_timezone_set('Europe/Bucharest');
$con = mysql_connect("localhost", "root", "");
mysql_select_db("downtime");
session_start();
$GlobalState = -1;
if (isset($_REQUEST['station_id'])) {
    $_SESSION['station_id'] = $_REQUEST['station_id'];
}
if (empty($_SESSION['station_id'])) {
  die('Invalid station id ...');
}
$station_id = $_SESSION['station_id'];
$answer = $_SESSION['station_id'];
$query = 'SELECT * FROM stations WHERE id=' . $station_id;
$result = mysql_query_or_die($query);
$first_row = true;
$row = mysql_fetch_assoc($result);
if ($row) {
    $linie = $row['line_id'];
    $statie = $row['station_id'];
	//
} else {
    echo " Station id invalid or shortcut was altered. Please contact me";
    die();
}
$initial = "SELECT * FROM records WHERE state < 3";
$result = mysql_query_or_die($initial);
$first_row = true;
$row = mysql_fetch_assoc($result);
	if ($row['state'] == 0) {
		$GlobalState = 1;
		$sql = "INSERT INTO records (station_id, line_id, state) VALUES ('$statie','$linie','.$GlobalState.')";
		mysql_query($sql);
		updatetaketime();
	}
	if ($row['state'] == 1){
		updatetaketime();
	}
	if ($row['state'] == 2){
		updateclosetime();
	}
$downtime = getOpenedDowntime();
if ($downtime != false) {
    ?>
    <div class="container"
         style="border: 5px solid #555; position: absolute; top: 10px; left: 670px; width: 500px; height: 110px; background-color: red;">
        <font size="6">Avem un incident deschis pe aceasta statie cu
            starea: <?php echo getDowntimeStateLabel($downtime['state']); ?> la
            ora <?php echo $downtime['open_time']; ?> </font>
    </div>
<?php
}
?>

functions.php

<?php

function fetchRows($sql) {
	$res = mysql_query($sql);
	$rows = array();
	while ($row = mysql_fetch_assoc($res)) {
		$rows[] = $row;
	}
	return $rows;
}
//---------------------------------------------------------------------
function fetchRow($sql) {
	$res = mysql_query($sql);
	return mysql_fetch_assoc($res);
}
//---------------------------------------------------------------------
function getOpenedDowntime() {
	$row = fetchRow('SELECT * FROM records WHERE state < 3');
	if ($row['id'] != 0) {
		return $row;
	}
	return false;
}
//---------------------------------------------------------------------
function getOpenedDowntime1() {
	$row = fetchRow('SELECT * FROM records WHERE state == 3');
	if ($row['id'] != 0) {
		return $row;
		$save_open_time = $row['open_time'];
	}
	return false;
}
//---------------------------------------------------------------------
function getUserData($user_id) {
	$row = fetchRow('SELECT * FROM users WHERE user_id= '. $user_id);
	if ($row['user_id']) {
		return $row;
	}
	return false;
}
//---------------------------------------------------------------------
function for_time() {
	$row = fetchRow('SELECT * FROM records WHERE state = 3');
	if ($row) {
		$current_id = $row['id'];
		$GlobalState = 4;
		$sql = "UPDATE records SET state='.$GlobalState.' WHERE `id` = " . $current_id;
		mysql_query($sql);
	}
	return false;
}
//---------------------------------------------------------------------
function mysql_query_or_die($query) {
    $result = mysql_query($query);
    if ($result)
        return $result;
    else {
        $err = mysql_error();
        die("<br>{$query}<br>*** {$err} ***<br>");
    }
}
//---------------------------------------------------------------------
function ShowError($text) {
	echo '<div style="border: 1px solid #ff0000; padding: 5px; background #ffa3a3a">';
	echo $text;
	echo '</div>';
}
//---------------------------------------------------------------------
function MapRequest($name, $default) {
	if (!isset($_REQUEST[$name])) {
		return $default;
	}
	return $_REQUEST[$name];
}
//---------------------------------------------------------------------
function CloseRequest($name, $default) {
	if (!isset($_REQUEST[$name])) {
		return $default;
	}
	return $_REQUEST[$name];
}
//---------------------------------------------------------------------
function getDowntimeStateLabel($state) {
	switch ($state) {
		case 1:
			return 'Deschis';
			break;
		case 2:
			return 'Preluat';
			break;
		case 3:
			return 'Inchis';
			break;
		case 4:
			return 'Validat';
		default:
			return 'Necunoscut';
	}
}
//---------------------------------------------------------------------
function updatetaketime(){
$recId = getOpenedDowntime();
$curId = $recId['id'];
$user_id = MapRequest('user_id', 0);
$userData = false;
if ($user_id > 0) {
    $userData = getUserData($user_id);

if ($userData === false) {
    ShowError('Userul scanat nu exista: ' . $user_id);
    exit();
}
}
    ?>
    <div
        style="border: 5px solid #555; position: absolute; top: 130px; left: 670px; width: 500px; height: 120px; background-color: lightblue;">
        <form action="newindex2.php" method="post">
            <font size="6">Scaneaza ID Tehnician</font><br/>
            <input type="text" name="user_id" autofocus>
            <input type="submit" value="Introducere"/>
        </form>
    </div>
<?Php
if (is_array($userData)) {
	$GlobalState = 2;
    $badge = $userData['user_id'];
    $nume = $userData['name'];
    $taketime = date('Y-m-d H:i:s');
	$save_taketime = $taketime;
	$taketime = $closetime = null;
	$sql = "UPDATE records SET take_user_id='$badge',take_user_name='$nume',take_time='$save_taketime',state='.$GlobalState.' WHERE `id` = " . $curId;
    mysql_query($sql);
							}
}
//---------------------------------------------------------------------
function updateclosetime(){
	$recId = getOpenedDowntime();
	$curId = $recId['id'];
	$user_id = MapRequest('user_id', 0);
	$userData = false;
if ($user_id > 0) {
    $userData = getUserData($user_id);

if ($userData === false) {
    ShowError('Userul scanat nu exista: ' . $user_id);
    exit();
}
}
if (is_array($userData)){
	$GlobalState = 3;
	$badge1 = $userData['user_id'];
    $nume1 = $userData['name'];
	$closetime = date('Y-m-d H:i:s');
	$save_closetime = $closetime;
	$closetime = null;
	$sql = "UPDATE records SET close_user_id='$badge1',close_user_name='$nume1',close_time='$save_closetime',state='.$GlobalState.' WHERE `id` = " . $curId;
    mysql_query($sql);
	for_time();
}
}
//---------------------------------------------------------------------
function send_mail(){
	ini_set("SMTP", "ch1-017-aru.prod.outlook.com");
    ini_set("sendmail_from", "claudiu.vanc@delphi.com");
    $message = "Sa deschis un incident de pe statia X";
    $headers = "From:incident.deschis@delphi.com";
    mail("Claudiu.Vanc@delphi.com", "Reminder", $message, $headers);
    //echo "Check your email now....<BR/>";
}
?>

maxxd

It's great that it kinda works now, but it's not going to for long. The mysql_* functions have been deprecated for years and removed completely from PHP 7.x. You'll need to rewrite your code using either PDO or Mysqli - I recommend PDO as it's got an easier interface, but that's really a question of preference.

pbismad

now kinda works

Does that mean you are still in need of any help?

cif

pbismad;11057935 wrote:
Does that mean you are still in need of any help?

Yes please! I was busy doing other stuff at work, but now i'm back to this wan't to put this project to work. And i run into a problem 😃 . If i open an incident from 2 or more computers in the same time... only one entry is created in "records". first computer that opens the incident inserts the first 3 values in the table (station_id, line_id, state). other computers just overwrite the rest of the fields(except first 3). So, it is kinda works but is not 🙁 for past 2 days i smashed my head looking at conditions, but i can't see the solution. So, please help. Thanks.

maxxd

Your getOpenedDowntime() function selects all records with a state less than 3 and returns the id of the first returned record in the dataset. You're going to have to build in more business logic to determine which of the records you actually want to select in order to get the correct id to update.

cif

maxxd;11058471 wrote:
Your getOpenedDowntime() function selects all records with a state less than 3 and returns the id of the first returned record in the dataset. You're going to have to build in more business logic to determine which of the records you actually want to select in order to get the correct id to update.

This is what I can't figure out how make it give me the right row.

maxxd

And that's something we probably can't help you with much. What makes each visit unique? Is it one technician per incident? If so, search for the most recently updated record with a status of 1 or 2 entered by the logged-in technician. However, what if there are concurrent incidents - for instance, a downtime that lasts days during which the technician gets another call? Perhaps you could get all the records for that technician, present them all, and ask the technician to select the proper incident.

cif

maxxd;11058475 wrote:
And that's something we probably can't help you with much. What makes each visit unique? Is it one technician per incident? If so, search for the most recently updated record with a status of 1 or 2 entered by the logged-in technician. However, what if there are concurrent incidents - for instance, a downtime that lasts days during which the technician gets another call? Perhaps you could get all the records for that technician, present them all, and ask the technician to select the proper incident.

Each incident opened from one computer is unique at that point because you cannot have 2 separate incidents opened from the same computer. 2 incidents from 2 computers have 2 different station id. So, the first insert in the records table when the page loads is unique. But only the first computer that opens an incident, makes that first insert in the records table. Every incident opened after that from other computer, if there is an opened icident, instead creating new entry in records table with his specific station id and details, just overwrites this opened incident.

pbismad

This is just a CRUD (Create, Read, Update, Delete) application.

All the code operating on the data must use the station_id. The initial request to the page supplies the station_id. You are storing that in a session variable. All the code on the page that operates on the database should use that session variable to specify which row to operate on, along with the status value being open/not-closed.

An alternative method that would actually simplify the code/queries would be to retrieve the row's auto-increment id after the INSERT query, store that in the session variable, and use that specific row id in the queries.