Dynamic <select> - How to?

[jrahma]

Hi,

I have employee evaluation for and it's populating the data from database and for every element of the evaluation there is a <select> to choose the employee rating.

I want to know how can I implement this? How to name it? will all have same name?

here is my code:

<table data-role="table" id="movie-table" data-mode="reflow" class="ui-body-d ui-shadow table-stripe ui-responsive">
<thead>
<tr>
    <th data-priority="1"></th>
    <th data-priority="2"></th>
</tr>
</thead>
<tbody>
<?php
	// get leave details;
	$mysql_query = $mysql_connection->prepare('CALL sp_web_get_employee_evaluation_elements_by_guid(:param_employee_evaluation_guid)');
	$mysql_query->bindParam(':param_employee_evaluation_guid', $evaluation_guid, PDO::PARAM_STR);

$mysql_query->execute();

if ($mysql_query->rowCount() <= 0)
{
	exit(header("Location: index.php"));
}		

while($mysql_row = $mysql_query->fetch()) {
?>
<tr>
    <td style="padding: 10px;"><b>ID:</b></td>
    <td style="padding: 10px;"><?php echo $mysql_row["employee_evaluation_details_id"]; ?></td>
</tr>
<tr>
    <td style="padding: 10px;"><b>Element</b></td>
    <td style="padding: 10px;"><?php echo $mysql_row["employee_evaluation_element_name"]; ?></td>
</tr>
<tr>
    <td style="padding: 10px;"><b>Rating :</b></td>
    <td style="padding: 10px;">
        &lt;select name="cboRating" id="cboRating" data-native-menu="false" required>
            &lt;option value="">[Select..]&lt;/option>
            <?php
              $mysql_rating_category_command = "CALL sp_web_populate_evaluation_rating_category()";
              $mysql_rating_category_query = $mysql_second_connection->prepare($mysql_rating_category_command);
              $mysql_rating_category_query->execute();

          while($mysql_rating_category_row = $mysql_rating_category_query->fetch())
          {
        ?>
        &lt;option value="<?php echo $mysql_rating_category_row["evaluation_rating_category_id"]; ?>"><?php echo $mysql_rating_category_row["evaluation_rating_category_name"]; ?>&lt;/option>
        <?php } ?>
    &lt;/select>
</td>
</tr>
<?php } ?>
</tbody>
</table>

Thanks,
Jassim

[pbismad]

Your evaluation elements are a set of data. You are going to display them all in the same way (just with the different element name/id) and process them all in the same way (just storing the response for each different element.) Arrays are for sets of data. The <select ...> name='...' attribute should be an array, with the evaluation element id as the array index. When the form is submitted, you can use php's array functions to process the data.

Use the following for the name attribute -

name="cboRating[<?php echo $mysql_row["employee_evaluation_details_id"]; ?>]"

To loop over the submitted data, use the following -

foreach($_POST['cboRating'] as $key=>$value)
{
    // $key will be the employee_evaluation_details_id and $value will be the chosen option value.
}

Next, the list of <option value=''>...</option> choices appears to be static/the same for each evaluation element. You should almost never run a SELECT query inside of a loop. You should run the query to get the choices for the option list just once, before the start of your main loop, build the option list just once, storing the html in a php variable, then just echo that php variable inside the <select>...</select> tags.

[pbismad]

Also, what is this - $mysqlsecondconnection? You should not need more than one database connection. That is just tying up more server resources. If you did this because of the 'out of sync' errors, you should finish with the result set from one query before you try to run another query. The simplest way of accomplishing that is to fetch the data from any query into a php variable, then just use that php variable in the code.

Not trying to run queries inside of loops will also help to prevent the out of sync errors.

Finally, since you are using a stored procedure, the procedure can return multiple results, one from each query it runs during each invocation, and you should call the PDO closeCursor() method after you are finished with the result set from a query, to free up the php driver/connection so that it can be used for other queries.

[dalecosp]

pbismad;11058675 wrote:

Also, what is this - $mysqlsecondconnection? You should not need more than one database connection.

Good catch, hard to tell what it is. I have a use case: different servers. Not sure if that's what he's up to though ...

[jrahma]

pbismad;11058665 wrote:

Your evaluation elements are a set of data. You are going to display them all in the same way (just with the different element name/id) and process them all in the same way (just storing the response for each different element.) Arrays are for sets of data. The <select ...> name='...' attribute should be an array, with the evaluation element id as the array index. When the form is submitted, you can use php's array functions to process the data.

Use the following for the name attribute -

name="cboRating[<?php echo $mysql_row["employee_evaluation_details_id"]; ?>]"

To loop over the submitted data, use the following -

foreach($_POST['cboRating'] as $key=>$value)
{
    // $key will be the employee_evaluation_details_id and $value will be the chosen option value.
}

Next, the list of <option value=''>...</option> choices appears to be static/the same for each evaluation element. You should almost never run a SELECT query inside of a loop. You should run the query to get the choices for the option list just once, before the start of your main loop, build the option list just once, storing the html in a php variable, then just echo that php variable inside the <select>...</select> tags.

I tried below code but getting:

SELECT is not an array

although my html output is showing correct result like this:

<tr>
    <td style="padding: 10px;">
        <h1>Work Performance</h1>
        <p>Efficient execution of duties.</p>
        <select name="cboRating[4613]" id="cboRating[4613]" data-native-menu="false" required>
            <option value="">[Select..]</option>
                        <option value="1">Outstanding</option>
                        <option value="2">Exceeds Expectations</option>
                        <option value="3">Meets Expectations</option>
                        <option value="4">Needs Improvement</option>
                        <option value="5">Unsatisfactory</option>
                    </select>
    </td>
</tr>
<tr>
    <td style="padding: 10px;">
        <h1>Technical Knowledge and Skill</h1>
        <p>Mastery of job knowledge and skills required to perform the duties of the position.</p>
        <select name="cboRating[4614]" id="cboRating[4614]" data-native-menu="false" required>
            <option value="">[Select..]</option>
                        <option value="1">Outstanding</option>
                        <option value="2">Exceeds Expectations</option>
                        <option value="3">Meets Expectations</option>
                        <option value="4">Needs Improvement</option>
                        <option value="5">Unsatisfactory</option>
                    </select>
    </td>
</tr>

here is my code:

if (is_array( $_POST['cboRating']))
{
    foreach($_POST['cboRating'] as $key=>$value)
    {
        echo "Key : " . $key . "

";
        echo "value : " . $value . "

";
    }
}
else
{
    echo "SELECT is not an array";
}

[pbismad]

Is this inside of a post method form?

I tried your html output (inside a post method form) and it produces the expected data -

POST:Array
(
    [cboRating] => Array
        (
            [4613] => 1
            [4614] => 5
        )

)

[jrahma]

pbismad;11058879 wrote:

Is this inside of a post method form?

I tried your html output (inside a post method form) and it produces the expected data -

POST:Array
(
    [cboRating] => Array
        (
            [4613] => 1
            [4614] => 5
        )

)

Yes it is, here is my full form:

<form name="frmSubmitEvaluation" id="frmSubmitEvaluation" method="post" action="submit_employee_evaluation.php">

<table data-role="table" id="movie-table" data-mode="reflow" class="ui-body-d ui-shadow table-stripe ui-responsive">
<thead>
<tr>
    <th data-priority="2"></th>
</tr>
</thead>
<tbody>
<?php
	// get leave details;
	$mysql_query = $mysql_connection->prepare('CALL sp_web_get_employee_evaluation_elements_by_guid(:param_employee_evaluation_guid)');
	$mysql_query->bindParam(':param_employee_evaluation_guid', $evaluation_guid, PDO::PARAM_STR);

$mysql_query->execute();

if ($mysql_query->rowCount() <= 0)
{
	exit(header("Location: index.php"));
}		

while($mysql_row = $mysql_query->fetch()) {
?>
<tr>
    <td style="padding: 10px;">
		<h1><?php echo $mysql_row["employee_evaluation_element_name"]; ?></h1>
        <p><?php echo $mysql_row["employee_evaluation_element_description"]; ?></p>
        <select name="cboRating[<?php echo $mysql_row["employee_evaluation_details_id"]; ?>]" id="cboRating[<?php echo $mysql_row["employee_evaluation_details_id"]; ?>]" data-native-menu="false" required>
            <option value="">[Select..]</option>
            <?php
              $mysql_rating_category_command = "CALL sp_web_populate_evaluation_rating_category()";
              $mysql_rating_category_query = $mysql_second_connection->prepare($mysql_rating_category_command);
              $mysql_rating_category_query->execute();

          while($mysql_rating_category_row = $mysql_rating_category_query->fetch())
          {
        ?>
        <option value="<?php echo $mysql_rating_category_row["evaluation_rating_category_id"]; ?>"><?php echo $mysql_rating_category_row["evaluation_rating_category_name"]; ?></option>
        <?php } ?>
    </select>
</td>
</tr>
<?php } ?>
<tr><td style="padding: 10px;"><button id="btnSave" class="ui-btn ui-icon-check ui-btn-icon-left">Submit</button></td></tr>
<tr><td style="padding: 10px;"><button id="btnCancel" class="ui-btn ui-icon-delete ui-btn-icon-left">Cancel</button></td></tr>
</tbody>
</table>

</form>

[pbismad]

Then you have something else going on in code that you haven't shown us. Some possibilities -

1) Another opening <form> tag above the one you are showing, that's using method = get.

2) The php code you are showing the result from is being executed before the form is being submitted.

3) The php code you are showing is being included into a file using a url and it's not in the same program scope as where the post data is at.

4) You have some php code that's clearing the $_POST variable(s).

5) Your code is doing a header() redirect at some point and is causing a get request for the page and there isn't any post data, combined with your form processing code not checking if there is post data before trying to access it.

Do you have php's error_reporting set to E_ALL and display_errors set to ON to get php to help you by reporting and displaying all the errors it detects? Also, even if you do have these two settings set as suggested, you may not see any errors if your code is doing a header() redirect and php's output_buffering is turned on in the php.ini file. Turn the php output_buffering setting OFF.

Immediately above the if (is_array( $POST['cboRating'])) line, add the following to see what is in the post array -

var_dump($_POST);

Lastly, if you cannot find the cause of the problem, you will need to post all the code that would be needed to reproduce the problem.

[jrahma]

Yes I have error log like this:

ini_set('display_errors', 1);
ini_set('display_startup_errors', 1);
error_reporting(E_ALL & ~E_NOTICE);

and vardump is giving:

array(0) { } SELECT is not an array

I only have one <form>, submit_employee_evaluation.php is on the same folder that's why it's able to show the error message I defined but not the correct result and only have belowlines above the vardump which I using in all other pages as well and only the evaluation is giving a problem.

include('includes/php_header.php');
include('includes/session_expiry.php');
include('includes/connect2db.php');
include('PHPMailer/class.phpmailer.php');

[jrahma]

Ok I think i Know the issue.. It's JQuery mobole ruining it... I just added data-ajax="false" and it works fine.