[RESOLVED] mysql query that displays image files that are located on local machine.

New_PHP_Guy

Forgive me if this is posted in wrong forum.

I am using xampp with mysql.

I have been reading that it is poor practice to insert image files directly into data base and the best practice is to access them form other source.

I have created a table in mysql with column called pics. the primary key is id and it is auto increment.

My goal is to assign a different image file to each row in the pic column and display using mysql query.

would I use some kind of fopen and _POST syntax
or <img src = and display in a html element?
Also do the image files have to be stored in htdocs folder or can they be accessed form anywhere on C:\\

After searching the topic on internet I haven't found an answer that I understand.
I really have no clue.

Here is the code I am working with so far.

require 'connect_inc.php.';



$query = "SELECT `manuf`, `model_name`, `pics` FROM `compound` ORDER BY `id`";

if ($query_run = mysql_query ($query)){
	echo 'Query success<br>';
	while ($query_row = mysql_fetch_assoc ($query_run)) {
	$manuf = $query_row ['manuf'];
	$model_name = $query_row ['model_name'];
	$pics = $query_row ['pics'];

echo '<strong>Make:</strong>'. '&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;'. '<strong>Model:</strong>'.'<br>' .  $manuf.'&nbsp;&nbsp;'. '&nbsp;&nbsp;&nbsp; '.$model_name.$pics.'<br>';
}
}	else{
		echo mysql_error().'<strong><font color = "red">Query failed!</font></strong>';
		}

cluelessPHP

Oh no no mysql_query is bad you should stop using it

look up PDO

http://php.net/manual/en/book.pdo.php

This is a really quick and dirty way of doing it

<?php


//require 'connect_inc.php.'; 

 try{
    	   $db = new PDO("mysql:host=localhost;dbname=pictures", 'root', '');
    	   $db ->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
    	}  catch(PDOException $e){
    		echo $e->getMessage();
    		die();
    }



$query = $db->prepare("SELECT `manuf`, `model_name`, `pics` FROM `compound` ORDER BY `id`"); 

if($query->execute() == false) {
        die("<pre>Query failed:\n".print_r($names->errorInfo(),1)."</pre>");
    }  

 foreach($query as $querys):

   ?>

   <?php echo $querys["manuf"]; ?>


  <?php echo $querys["model_name"]; ?>

   <img src="<?php echo $querys["pics"]; ?>">

   <?php
   endforeach;

   ?>

New_PHP_Guy

Thank you for the reply cluelessphp.

I fear that I did not properly articulate what I am trying to accomplish.

What I would like to do is run the mysql query and somehow associate an image to each unique "id" in the mysql table and then display the image when the query is run.

These images are stored in my local disc "C". For example C:\mypictures\any folder\any pic.jpg

I don't want to create a picture data base or store the images within a data base. I am just hoping to be able to some how pass the file path into the data base query.
I am not doing this public. I am just learning on my own PC. Using xampp as localhost.

I read the introduction to PDO, not completely understanding its purpose. Does it make things easier to access?

Why is mysql_query bad?

Weedpacket

Last question first: mysql_query is bad because the MySQL extension is obsolete.

You don't say where the images are coming from, if they're part of the POST request, then you'll need to move them from where they're uploaded to into somewhere more permanent (see [man]move_uploaded_file[/man]).

Then you need to record in the database where you moved them to: either store the full path in a VARCHAR column, or some sort of id/name that you can reconstruct the path from.

Where you store them: well, if you want to display them in an <img> tag then at this stage your best bet will be somewhere under htdocs, so that you can construct a URL to use as the img tag's src.

cluelessPHP

As weedpacket said, he knows far more than me by a long shot

New_PHP_Guy

Weedpacket & cluelessPHP.
Thank you both for your responses.

It is obvious to me that I have much to learn.
I need to study more and complete some more tutorials, so that I may be able to better understand the advice you have given me.

Right now I feel that I am trying to accomplish things beyond my limited capabilities.

I will revisit this at a later date.

Looking for one more piece of advice for now.
Should I mark as resolved or leave this thread static?

NogDog

New_PHP_Guy;11059969 wrote:
Weedpacket & cluelessPHP.
Thank you both for your responses.

It is obvious to me that I have much to learn.
I need to study more and complete some more tutorials, so that I may be able to better understand the advice you have given me.

Right now I feel that I am trying to accomplish things beyond my limited capabilities.

I will revisit this at a later date.

Looking for one more piece of advice for now.
Should I mark as resolved or leave this thread static?

I'd say resolved if you're pretty sure you're not going to want to re-open it soon (for an undefined value of "soon"), and instead start a new thread if when you have more questions about it. If you think you might try to tackle it again in the near future (for an undefined value of "near future"), then it's no big deal if you leave it open.