[RESOLVED] Validation (yes again)

[cluelessPHP]

So I have been reworking this

<?php  

class Validation 
{
	public 
	$password,
	$repeatPassword,
	$username,
	$email;


public static 
$minPassword = 5,
$confirmPassword = 5,
$minUsername = 3,
$validEmail;


public static function validateEmail($email)
{
	if(filter_var($email, FILTER_VALIDATE_EMAIL) != self::$validEmail)
	{	
		return true;
	}
	else
	{
		return false;
	}
}

public static function validatePassword($password)
{
	if(strlen($password) >= self::$minPassword)
	{
		return (strlen($password) >= self::$minPassword);
	}
	else
	{
		return false;
	}
}

public static function validateRepeatPassword($repeatPassword)
{
	if(strlen($repeatPassword) >= self::$confirmPassword)
	{
		return (strlen($repeatPassword) >= self::$confirmPassword);
	}
	else
	{
		return false;
	}
}
public static function validateUsername($username)
{
	if (strlen($username) >= self::$minUsername)
	{	
		return (strlen($username) >= self::$minUsername);
	}	

	else
	{
		return false;
	}
}

}

<?php 

require "loadclasses.php";

	$password = $username = $email = $confirmPassword = "";	

			$username = trim($_POST['username']);
			$password = trim($_POST['password']);
			$email = trim($_POST['email']);
			$confirmPassword = trim($_POST['repeatPassword']);
			$errors = array();


		if(Validation::validateUsername($username))
			{
				return true;
			}
		else
		{
			$errors[] = ["name" => "username", "error" => "invalid username"];
		}	

		if(Validation::validateEmail($email))
			{
				return true;
			}	
		else
		{
			$errors[] = ["name" => "email", "error" => "invalid Email"];
		}		
		if(Validation::validatePassword($password))
			{
				return true;
			}
		else
		{
			$errors[] = ["name" => "password", "error" => "invalid password"];	
		}		


		if(Validation::validateRepeatPassword($confirmPassword))
			{
				return true;
			}
		else
		{
			$errors[] = ["name" => "repeatPassword", "error" => "Passwords must match"];
		}	

header('Content-Type: application/json');

if (isset($success))
{
	echo json_encode($success);
}
else
{
	echo json_encode(["errors" => $errors]);
}		

First problem, if the username is valid the other failed validation won't show, second problem it seems it's not D.R.Y

[NogDog]

You can do all the validations first, then decide what to return afterwards by checking the contents of the $errors array. Also, you could try something like this to make it a bit DRYer:

$errors = array();
$fields = array(
  'username' => array(
    'validator' => 'validateUsername',
    'message'   => 'invalid username'
  ),
  'email' => array(
    'validator' => 'validateEmail',
    'message'   => 'invalid email',
  );
  'password' => array(
    'validator' => 'validatePassword',
    'message'   => 'invalid password'
  ),
  'repeatPassword' => array(
    'validator' => 'validateRepeatPassword',
    'message'   => 'passwords must match'
  )
);
foreach($_POST as $key => $value) {
  if(isset($fields[$key])) {
    if(!Validation::{$fields[$key]['validator']}($value)) {
      $errors[] = ['name' => $key, 'error' => $fields[$key]['message']];
    }
  }
}
if(empty($errors)) {
  return true;
}

[Weedpacket]

if(!Validation::validateUsername($username))
{
    $errors[] = ["name" => "username", "error" => "invalid username"];
}
...etc.

If at the end of all that [font=monospace]$errors[/font] isn't empty then you know there was (at least) one error.

EDIT: What he said.

[cluelessPHP]

if(!Validation::validateUsername($username)) 
{ 
    $errors[] = ["name" => "username", "error" => "invalid username"]; 
} 
...etc.  

I did try that didn't work it seemed.

Thanks Nogdog, still not sure when I should use arrays

[NogDog]

cluelessPHP;11060587 wrote:

...
Thanks Nogdog, still not sure when I should use arrays

There's always more than one way to do it. 🙂 However, when I see myself doing essentially the same thing over and over, I tend to think first of some way to put it into a loop. That often suggests to me that I want something I can iterate over multiple times. That usually leads me to an array with a foreach() loop, or in more complex situations, perhaps a class that implements Iterator interface. (Most of the time the array approach is sufficient for me.)

[cluelessPHP]

Ah, loops I guess seem better. I'm guessing if it's in a loop you won't need to repeat yourself as much.

Still working my way through these, they seem good tutorials

https://www.udemy.com/learn-object-oriented-php-by-building-a-complete-website/learn/v4/content