What could cause a function to be defining itself?

schwim2

Hi there everyone!

I've done something to my forum system that is causing functions to be redeclaring themselves at the end of the function. Here's what I mean.

I get this error on a page:

Fatal error: Cannot redeclare get_tapatlk_location() (previously declared in /home/air/public_html/forum/mobiquo/include/function_hook.php:4) in /home/air/public_html/forum/mobiquo/hook/function_hook.php on line 62

And here's the function(I have commented line 4 and 62):

function get_tapatlk_location()
{
	global $user,$phpbb_root_path; //Line 4
	$location = $user->extract_current_page($phpbb_root_path);
	$param_arr = array();
	switch ($location['page_name'])
    {
        case "viewforum.php":
        	if(!empty($_GET['f']))
        	{
        		$param_arr['fid'] = $_GET['f'];
        	} 
            $param_arr['location'] = 'forum';
            break;
        case "index.php":
        case '':
            $param_arr['location'] = 'index';
            break;
        case "ucp.php":
            if(!empty($_GET['i']) && ($_GET['i'] == "pm"))
            {
                $param_arr['location'] = 'message';
                if(!empty($_GET['p']))
                $param_arr['mid'] = $_GET['p'];
            }
            if(!empty($_GET['mode']) && ($_GET['mode'] == 'login'))
            {
            	$param_arr['location'] = 'login';
            }
            break;
        case "search.php":
            $param_arr['location'] = "search";
            break;
        case "viewtopic.php":
            if(!empty($_GET['t']))
            {               

                //$param_arr['fid'] = $parameters['fid'];
                $param_arr['location'] = 'topic';
                $param_arr['tid'] = $_GET['t'];
            }
            break;
        case "memberlist.php":
           	if(!empty($_GET['mode']) && $_GET['mode'] == "viewprofile" && !empty($_GET['u']))
            {
                $param_arr['location'] = 'profile';
                $param_arr['uid'] = $_GET['u'];
            }

        break;
    case "viewonline.php":
        $param_arr['location'] = 'online';
        break;
    default:
        $param_arr['location'] = 'index';
        break;
}
$queryString = http_build_query($param_arr);
$url = generate_board_url() . '/?' .$queryString;
$url = preg_replace('/^(http|https)/isU', 'tapatalk', $url);
return $url;
} //Line 62

Does anyone know what could cause the end of a function to be redefining the function itself? Is there anything I might be able to do to track down the issue?

Thanks for your time!

dalecosp

Well, fallthrough in a switch block has been known to have some strange effects at times. That doesn't feel like the issue, though.

What does the User classes' extract_current_page($path) method do?

And what does generate_board_url() do? (I think I can guess that one).

Most likely phpBB is calling the file twice ... saith Occam's Razor.

And of course, you are familiar with this nasty hack?

<?php

if (!function_exists('get_tapatalk_location')) {
   function get_tapatalk_location() {

   //etc.....
   }
}

Please excuse me, I need to go wash my hands 😉

Weedpacket

As dalecosp suggests, that error would happen if you tried to run the code in that file twice (say by including it more than once).

NogDog

If it's getting included more than once, then the most straight-forward (or at least simplest?) fix might be to change the include call to be a require_once();

dalecosp

NogDog;11062497 wrote:
If it's getting included more than once, then the most straight-forward (or at least simplest?) fix might be to change the include call to be a require_once();

Sure, if it can be determined where/from whence it's being called. He appears to be hacking something onto a PHPBB installation, so there's some level of external complexity involved ... albeit, less complex than, say, vBulletin... it might be that it's tough to figure out what's happening. Perhaps a job for trace, truss, xDebug, even Introspection .... or just reading a lot of code.

NogDog

Is the definition is the same in both of these files?

/home/air/public_html/forum/mobiquo/include/function_hook.php
/home/air/public_html/forum/mobiquo/hook/function_hook.php

If so, you could wrap them in a conditional statement:

if(!function_exists('get_tapatlk_location'))
{
    function get_tapatlk_location()
    {
        // rest of function body...
    }
}

By no means ideal, as I'd rather re-factor things so that it's only defined in one place; but could be a sufficient band-aid. If they are not, in fact, the same, then things get uglier.

dalecosp

NogDog;11062509 wrote:
Is the definition is the same in both of these files?

/home/air/public_html/forum/mobiquo/include/function_hook.php
/home/air/public_html/forum/mobiquo/hook/function_hook.php

If so, you could wrap them in a conditional statement:
if(!function_exists('get_tapatlk_location'))
{
    function get_tapatlk_location()
    {
        // rest of function body...
    }
}
By no means ideal, as I'd rather re-factor things so that it's only defined in one place; but could be a sufficient band-aid. If they are not, in fact, the same, then things get uglier.

Good catch on the file names in the error message ... but I've already shown him this nasty hack 😉

schwim2

Hi there guys, thanks to all for your collective assistance!

I had Googled the function_exists bandaid and was using it but it would just error out on the next function in line.

It doesn't seem to always happen. Currently, the page has worked without issue over the course of the day with many refreshes(new template) so I'm not sure if my issue was caused by a cached template or whether it's conditional on something occuring in that page's PHP. I'll post back if I make any progress on it.