In a github pull request today, I include the following in the description:

The actual fix is in the 3rd commit, and is basically a case of just trying to make the different report DB queries more consistent on how they deal with date ranges, moderation status, and review status. It seems to have worked.

This was followed immediately by:

[upl-image-preview url=https://board.phpbuilder.com/assets/files/2018-06-13/1528924949-499744-orly-tyring-stuff-until-it-works.jpeg]

LOL! Much better than anyone "over" me ... I guess, anyway. Of course, no one here understands much about what I do ... at least, there's no one else who seems to write any code, much, except some HTML and some spreadsheet formulae.

And the wise-cracker who pulls stuff like the above is the one typing this right now 😉

Only sort of thing I've done recently was to VP IT after hearing some of the objections the sales department was getting. I probably shouldn't post the meme, 'cause I named names. But here's the background image:

[EDIT]: Did I understand correctly? Your super/someone with the commit bit sent the photo, right?

dalecosp Did I understand correctly? Your super/someone with the commit bit sent the photo, right?

Nope, I posted all of that in the description section of the pull request (which I think technically becomes the first comment?), where I fleshed out the details of why I was making the changes. Because it was for something that hardly anyone uses, but one of those users was complaining; I was just tweaking things in the hopes it would work, and then wiping my hands of it, not knowing for sure which of those tweaks was/were responsible for actually fixing it. 🙂

    Write a Reply...