Help on simplifying my file upload script ...

[Anon]

HI,

This is going to get hard to explain, so here goes.

I have an html page that has 4 slots for files to be uploaded. The HTML fields are named uploadfile1, uploadfile2, uploadfile3, uploadfile4. Had to do this to be able to use the $uploadfile<n>name, type, or _tempfile array values in my separate "uploader" script.

Here is a snippet of the upload.html file:

<FORM ACTION="/uploadphp/uploader.php" ENCTYPE="multipart/form-data" METHOD=POST>
User Name or Company Name: <INPUT TYPE="TEXT" name="user" SIZE="10"><BR><BR><HR>
<INPUT TYPE="hidden" name="MAX_FILE_SIZE" value="33554432">
<INPUT TYPE="FILE" NAME="uploadfile1" SIZE="60" MAXLENGTH="80"><br>
<INPUT TYPE="hidden" name="MAX_FILE_SIZE" value="33554432">
<INPUT TYPE="FILE" NAME="uploadfile2" SIZE="60" MAXLENGTH="100"><br>
<INPUT TYPE="hidden" name="MAX_FILE_SIZE" value="33554432">
<INPUT TYPE="FILE" NAME="uploadfile3" SIZE="60" MAXLENGTH="150"><br>
<INPUT TYPE="hidden" name="MAX_FILE_SIZE" value="33554432">
<INPUT TYPE="FILE" NAME="uploadfile4" SIZE="60" MAXLENGTH="200"><br>
<BR><BR><HR>
<INPUT TYPE="SUBMIT" VALUE="Upload File!" NAME="sendit">&nbsp;
<INPUT TYPE="SUBMIT" VALUE="Cancel" NAME="cancelit">&nbsp;
<INPUT TYPE="RESET" VALUE="Reset" NAME="reset"><BR><HR><BR>
</FORM>

As you see I have 4 slots for 4 file uploads.

Here is a snippet I have for handling 1 of the 4 uploads in uploader.php:

$filename1 = "$upload_dir/$uploadfile1_name";
@copy($uploadfile1, $filename1);
@unlink($uploadfile1);

(done the same for the other three)

I want to use a for() statement like:

for($I = 1; $I <=4; $I++){
$filename$I = "$upload_dir/$uploadfile$I_name";
@copy($uploadfile$I, $filename$I);
@unlink($uploadfile$I);
}

so I only have to have this code once and not four times. But the $uploadfile$I doesn't work for $I to autoincrement so $uploadfile$I = 1,2,3 or 4.

How can I get this to work?
I'm stumped...

Thanks
-Wes Yates

[Anon]

instead of using:

NAME="uploadfile1"
NAME="uploadfile2"
NAME="uploadfile3"
NAME="uploadfile4"

use:

NAME="uploadfile[]"
NAME="uploadfile[]"
NAME="uploadfile[]"
NAME="uploadfile[]"

this will make uploadfile an array within PHP. that way you can do a for loop and use:

$uploadfile[$x]

all the other variables become $uploadfile_size[$x], etc.

hope this helps!

[Anon]

Use your upload as an array
<INPUT TYPE="FILE" NAME="uploadfile[1]" SIZE="60" MAXLENGTH="80"><br>
<INPUT TYPE="FILE" NAME="uploadfile[2]" SIZE="60" MAXLENGTH="100"><br>
<INPUT TYPE="FILE" NAME="uploadfile[3]" SIZE="60" MAXLENGTH="150"><br>
<INPUT TYPE="FILE" NAME="uploadfile[4]" SIZE="60" MAXLENGTH="200"><br>

Then itereate through it using $i if you want.

[Anon]

Thanks a bunch! Both of you are on track and understand what I need, but I seem to be hitting a snag. I tried exactly what you were saying earlier, in fact, I posted a similar solution on php.net - multiple file uploads, only to learn later this doesn't always work.

I retried the method both of you suggested, but the snag is with the array items. the output is below using uplaodfile[] 4 times in my upload.html:

"for($I = 0; $I <=16; $I++){"

array item types:
[0] = file name
[1] = file type
[2] = temp file name
...

same file type (.sit)
array number: 0, uploadfile: bootmesg.sit
array number: 1, uploadfile: application/x-stuffit
array number: 2, uploadfile: /tmp/php030Eyl
array number: 3, uploadfile: bootmesg2.sit
array number: 4, uploadfile: application/x-stuffit
array number: 5, uploadfile: /tmp/php8Uyco4
array number: 6, uploadfile: bootmesg3.sit
array number: 7, uploadfile: application/x-stuffit
array number: 8, uploadfile: /tmp/phpgIgshN
array number: 9, uploadfile: bootmesg4.sit
array number: 10, uploadfile: application/x-stuffit
array number: 11, uploadfile: /tmp/php8w9Y9v
array number: 12, uploadfile:
...

different file types:
array number: 0, uploadfile: bootmesg.bin
array number: 1, uploadfile: application/octet-stream
array number: 2, uploadfile: /tmp/phpt1ZMbu
array number: 3, uploadfile: bootmesg.cgi
array number: 4, uploadfile: /tmp/php8bFIlZ
array number: 5, uploadfile: bootmesg.sea
array number: 6, uploadfile: /tmp/phpfX1Suu
array number: 7, uploadfile: bootmesg.sit
array number: 8, uploadfile: application/x-stuffit
array number: 9, uploadfile: /tmp/phpQPQ9CZ
array number: 10, uploadfile:
...

Note the absence of some file types in the last example.

this is why I used uploadfile1, 2, 3, and 4. I found that since I only needed to have the filename and the unified [] items were going to be unpredictable, I had to use individual "uploadfile" tags. I could then predict [0] was the filename for all four.

Now what I want to see if its possible to, in my uploader.php file, to say for uploadfile1 is $uploadfile$I where $I is 0. same for the rest. The snag now is that php doesn't parse $uploadfile$I as $uploadfile1, etc. It parses $uploadfile then $I as separate variables.

Any clues as to how I can accomplish this???

Thanks again!!!!!

-Wes Yates

[Anon]

Hey all,

Solution found! And it works!!!

here are the HTML fields:
uploadfile1, uploadfile2, uploadfile3, uploafile4.

Here is the complete php solution to simplifying (sorta) the 4 different file uploads.:

<?php
// global variables used in other places.
global $uploadfile1, $uploadfile2, $uploadfile3, $uploadfile4;
global $uploadfile_name1, $uploadfile2_name, $uploadfile3_name, $uploadfile4_name;
global $upload_dir, $filename, $filename2, $filename3, $filename4, $filenames;
global $thetime, $MAX_FILE_SIZE, $user;

if ($user == ""){
?>

<BODY>
<H1> Please go back and enter a user name.</H1>
</BODY>

<?php
exit;
} else {

$server_dir = "/home/httpd/webupload";
$thetime = time();
umask(000);
mkdir("$server_dir/$user".""."$thetime",0777);
// Wherever you have write permission below...
$upload_dir = "$server_dir/$user".""."$thetime";

// Gets the temp_name in to a string variable
$uploadtemp1 = $uploadfile1;
$uploadtemp2 = $uploadfile2;
$uploadtemp3 = $uploadfile3;
$uploadtemp4 = $uploadfile4;

// Gets those names into an array to be called later
$original = array(
"$uploadtemp1"
,"$uploadtemp2"
,"$uploadtemp3"
,"$uploadtemp4"
);

// Same as above except gets the real file name
$uploadreal1 = $uploadfile1_name;
$uploadreal2 = $uploadfile2_name;
$uploadreal3 = $uploadfile3_name;
$uploadreal4 = $uploadfile4_name;

$file = array(
"$uploadreal1"
,"$uploadreal2"
,"$uploadreal3"
,"$uploadreal4"
);

// Copy handler for the above arrays. It Works!!!
for($I = 0; $I <=3; $I++){
echo "file number: $I, filename: $file[$I], original name: $original[$I]<BR>";
//$file[$I] = ereg_replace(" ", "", $uploadfile$I_name);
//$file[$I] = ereg_replace("%20", "", $uploadfile$I_name);
$copyfile = "$upload_dir/$file[$I]";
@copy($original[$I], $copyfile);
@unlink($original[$I]);
} // end of for
} // end of else

Kind of a stinkin' shame to have to use arrays, but if I need to change the meat (copy/upload) code for the script, I only have to do it once (right or wrong hehe).

Thanks all. I'll also post to php.net/multiple file uploads
-Wes