Headers already sent - passthru

Anon

Perhaps someone can help me? I've tried a few suggestions from other posts but cannot resolve this warning:

Cannot add header information - headers already sent by (output started at includes/mysql_admin.inc:79)

This is the code:

function mysql_dump($result, $dba_name, $username, $password) {

$result = mysql_query("show variables") or trigger_error("Can't dump database or table.", FATAL);
while(TRUE) {
    $row = mysql_fetch_row($result);
    if ($row == FALSE) {
        break;
    } elseif ($row[0] == "basedir") {
        $dir = $row[1]."bin".substr($row[1], -1);
    }
}
header("Content-disposition: filename=$dba_name.sql");
header('Content-type: application/octetstream');
header('Pragma: no-cache');
header('Expires: 0');
passthru($dir."mysqldump --user=$username --password=$password $dba_name");

}

passthru... is line 79.

I've checked that there are no extra lines after '?>' in the icludes.

Any help is appreciated. BTW, the dump works fine.

Regards,

Martin Webster

Anon

Update:

I've resolved the problem by adding "exit;" at the end of the function. It seems that even the curley bracket "}" is enough to generate the warning.

Martin Webster

Anon

The line where PHP reports that the headers have been sent already
(output started at includes/mysql_admin.inc:79)) is not
the line where the actual error (sending more headers) occurs.
There is another line somewhere where you are trying to send headers again.

Putting an "exit" in front of the closing bracket just means you quit the script
before you get to the error. (sounds like a bit of a microsoft solution :-) )

Anon

Thanks. You are, of course, correct. I have now removed "exit;" from the function and placed it where it belongs. That is, in the script that calls the function(s).

...
case "mysql_dump_table";
if ($table_name) {
mysql_dump($result, $dba_name, $table_name, $username, $password);
}
break;
}
exit;
}

I hope I'm right this time as I'm rather fond of penguins and want to do things properly! ;-)

Anon

giggle
well, you should exit the script where it's finished.

You should always think carefully about your program's flow.
Exiting inside a function is never a good idea, because a function is nothing more than a helper that helps your main program to work, and it's the main program that you want to stop. Instead, if you want your function to stop, use "return" to get out of the function and back into the main program (or wherever you called the function from). With return you can also give an error code back to the caller so you know what went wrong.