Counter need help..doesnt work!

Anon

Hi,
Sorry about posting another thread .. but the old thread about the link counter is disapprearing..

Anyhow, the previous post was:

Author: yihung (24.78.144.71)
Date: 2001-04-25 04:12:11

Hi,
Yet another question from me 🙂

Basically, I need a counter for each link that's clicked and insert the new count into a table.

EX:
Say I have 50 records in a table, each record (row) I have a column that contains a link to a detail page. The detail page isn't a real html page, but a pop up window that contains data called from the table...

So, I'll need counts for each clicks on the links and add them to the table, and that counts will be listed together with the records.

I tried this:

if ($action == "profile")
{

$result = mysql_query("SELECT * FROM $table where id = $id", $db);

$counternew = $counter + 1 ;
mysql_query("update $table set counter = '$counternew' where id = '$id'");

now the column named counter can count ONLY once, ie. from 0 to 1.. then it stopped working.. any idea why? as for the counter field, I tried INT, null, default=0.. is that the correct way to do it?

Anon

here is the code to do what you want.

counter.php?pgName=homepage will keep count for homepage

mysql_connect($host, $user, $pass);
mysql_select_db($dbase);

$query = mysql_query("SELECT $pgName FROM $tablename");
$rows = mysql_num_rows($query);

if ($rows < 1) {
//create new pgName
mysql_query("INSERT INTO $tablename (pgName,hits) VALUES ($pgName,"0")");
} else {
mysql_query("UPDATE $tablename SET hits=hits+1 WHERE pgName='$pgName'")
}

$getnum = mysql_query("SELECT hits FROM $tablename WHERE pgName='$pgName'");
$hits = mysql_result($getnum,0,"hits");

Anon

so basically the script will do the work for you. Just include the counter with a pgName variable, if it dont' exist it will create it, if it does it will update.

Anon

OK!

It works!

You probably misunderstood me, but all I needed to do was to scrap that $counternew=counter+1; line and just put that in the UPdate query instead.

Thanks!

kparker

This is great, but shall I add my usual Please-Worry-About-Multi-User-Access plea?

The code, as written, will allow any number of sites, looking at a "virgin" link, to all begin the update at exactly the same time. You can't really tell how many would all get the same SELECT statement returning no rows, and proceed to try to insert the same new row.

To guard agains this:

Make sure the url column is primary key or at least a unique index.
Trap the error caused by a redundant insertion.
If this happens, simply execute the UPDATE query instead, just as you would if your SELECT found the row already existing.

Anon

Shouldn't it be $counternew = counter++; ?

Anon

tey mean the same thing