An easier way?

Anon

OK call me thick but there must be a simpler way of doing this:

if($type == clear){
$finalprice = $sqm $clearprice;
}
if($type == frosted){
$finalprice = $sqm $frostedprice;
}
if($type == textured){
$finalprice = $sqm $texturedprice;
}
if($type == leaded){
$finalprice = $sqm $leadedprice;
}

basically it's sqm x typeprice but type is a varible.

Thanks

[deleted]

Have a look at the SWITCH statement..

switch($type)
{
case 'clear':
$finalprice = $sqm $clearprice;
break;
case 'frosted':
$finalprice = $sqm $clearprice;
break;
};

smarlowe

Sure, try a hash array:

$type = "clear"; #Setup var

$prices = array("clear" => 10, "frosted" => 12, "textured" => 14, "leaded" => 20);

$sale_price = $sqm * $prices["$type"];

Unless I've messed up my syntax that should work, but I'm not actually near a php box right at the moment.

Anon

switch ($type) {
case 'clear': $finalprice = $sqm $clearprice;
break;
case 'frosted': $finalprice = $sqm $frostedprice;
break;
case 'textured': $finalprice = $sqm $texturedprice;
break;
case 'leaded': $finalprice = $sqm $leadedprice;
break;
}

Anon

Thanks guys I think doing an array should be easier.

lawnmowerman

This may not be exactly what you're looking for, but give this a try:

$finalprice = $sqm + ${$type . 'price'};

If $type = 'clear', then the line will be evaluated as:
$finalprice = $sqm + ${'clear' . 'price'};
which evaluates as:
$finalprice = $sqm + ${'clearprice'};
which is the same as:
$finalprice = $sqm + $clearprice;

If $type is assigned something else, then that string will be used instead.

Hope this helps!

-Rich

pentinat

Sure there is, but this one works, go to another step of your project....

kparker

Sorry, that's bad advice--this kind of attitude is exactly why too much software is hard to test and hard to maintain. Her original is especially week in that the series of if-tests doesn't even capture the fact that this is a mutually exclusive case. At the very least, it should have been written with else if, but as Scott suggested and Ashley clearly understood, an array is the best way to do this.