Help! str_replace should be simple!

Anon

I'm trying to replace any occurances of previously converted characters, i.e. changing – to "-" within a results page.

I want to apply the str_replace function to each array just before it is printed. I have tried two different approaches (by the book I think) and still no joy.

Anyone with any ideas why this isn't working please help!!!

function replace_string($string) {
$string = str_replace("–", "-", "$string");
$string = str_replace("’", "'", "$string");
return($string);
}

if (mysql_num_rows($result) != 0) {
while ($row = mysql_fetch_array($result)){

array_walk ($row, 'replace_string');
reset ($row); TRIED THIS WAY

$row[title] = replace_string(&$row[title]); TRIED THIS ALSO
$row[body] = replace_string(&$row[body]);
?>

<php print $row[title]; ?></a> 
<?php print substr($row[body],0,70) ." . . ."; ?> 
<?php print "$row[article_date]"; ?>
<?php
}
}

chowdary

Hi,
It seems the error is in your function.
If you pass the argument as "$string" then it treats "$string" as a string not as a variable.

The function should be
function replace_string($string) {
$string = str_replace("–", "-", $string);
$string = str_replace("’", "'", $string);
return($string);
}

And while loop seems OK but make it clearer

while ($row = mysql_fetch_array($result)){
$title=replace_string($row["title"]);
$body=substr(0,70,replace_string($row["body"]))."...";
$dt=$row["article_date"];
echo "$title \n";
echo "$body \n";
echo "$dt \n";
}

Anon

This is still not working - my current code is pasted below.

Note that this web page (phpbuilder's) does exactly what I want my script to do as the first variable in the script should be 'AmpersanHash8211semi-colon" and I want to convert it to "-".

The code for the "-" character still displays in the results no mater what positions I try the code in... aargh!

function replace_string($string) {
$string = str_replace("–", "-", $string);
$string = str_replace("’", "'", $string);
return($string);
}

if (mysql_num_rows($result) != 0) {
while ($row = mysql_fetch_array($result)){

$title = replace_string(&$row["title"]);
?>

<a class="pr" href="<?php printf("./compnewsbody.php?id=%d&article_id=%d",$row[advertiser_id],$row[id]); ?>"><?php print ($title); ?></a> 
<?php print substr($row[body],0,70) ." . . ."; ?> 
<?php print "$row[article_date]"; ?>
<?php
}

Anon

Try calling ord() to get the ASCII value of these special characters and then use that with chr() in the str_replace call. You could also put error_repoting(E_ALL); at the top of your script to see if you are using uninitialized variables.