help me to improve this

[edmon]

i have needed table and this thing works but i want to see better realization..
can someone to improve it?
<pre>
<?php
function createoption($idopt,$optionsa,$tableopt,$HTTP_POST_VARS){
while(list($key, $val) = each($HTTP_POST_VARS)){
//echo $key."->".$val."<br>";
}
$conn=mysql_connect('localhost', 'user', 'pass') or die ("Could not connect");
mysql_select_db('test') or die ("Could not select database");
$query="SELECT $idopt,$optionsa FROM $tableopt;";
$result=mysql_query($query) or die ("Query failed");
echo "<select name=$optionsa>\n";
while ($row = mysql_fetch_array($result))
{
if($HTTP_POST_VARS[$optionsa] == $row[$idopt]){
echo "<option selected value=$row[$idopt]";
} else {
echo "<option value=$row[$idopt]"; }
echo ">$row[$optionsa]";
}
echo "</select>";
mysql_close($conn);
}
?>

<form name="<?php echo $PHP_SELF; ?>" method="post" action="">
<?php createoption("countryid","countryen","countrys",$HTTP_POST_VARS); ?>
<input name=save type=submit value="Sign in">
</form>
</pre>

[[deleted]]

function createoption($idopt,$optionsa,$tableopt,$HTTP_POST_VARS
{
$bNoErrorsFound = treu;
while(list($key, $val) = each($HTTP_POST_VARS))
{
//echo $key."->".$val."<br>";
}
if (!$conn=mysql_connect('localhost', 'user', 'pass') or die ("Could not connect"))
{
echo 'MySQL connection failed';
$bNoErrorsFound = false;
}
else
{
if (!mysql_select_db('test', $conn))
{
echo 'Could not select database';
}
else
{
$sQuery='SELECT '.$idopt.','.$optionsa.'
FROM '.$tableopt;
if (!$result=mysql_query($query, $conn))
{
echo 'Query failed: '.mysql_error($conn)."<BR>\n".$sQuery;
}
else
{
if (mysql_num_rows($result) == 0)
{
echo 'No rows found';
}
else
{
echo "<select name=$optionsa>\n";
while ($row = mysql_fetch_array($result, MYSQL_ASSOC))
{
if($HTTP_POST_VARS[$optionsa] == $row[$idopt])
{
echo "<option value=".$row[$idopt]." selected>".$row[$optionsa];
}
else
{
echo "<option value=".$row[$idopt].">".$row[$optionsa];
};
};
echo "</select>";
};
};
};
mysql_close($conn);
};
}
?>

<form name="<?php echo $PHP_SELF; ?>" method="post" action="">
<?php createoption("countryid","countryen","countrys",$HTTP_POST_VARS); ?>
<input name=save type=submit value="Sign in">
</form>
</pre>

[[deleted]]

How lovely that all my indent spaces are gone.. 🙁

[Anon]

Yeah, phorum doesn't save formatting, it's very annoying. Maybe I'll write a hack to fix this problem. Except to do it I'd either have to put the message inside <PRE></PRE> tags, or convert all spaces to &nbsp which could make for a very heavy page.

[edmon]

si there better way to check selected?...
without sending HTTP_POST_VAR?

[kparker]

<b>&amp;nbsp;</b> is your friend.

[[deleted]]

now you tell me? :-)

[Anon]

Also remove the action="", it works in ie but not ns.

[[deleted]]

How do you mean?

[Anon]

<form name="<?php echo $PHP_SELF; ?>" method="post" action="">

change it to..

<form name="<?php echo $PHP_SELF; ?>" method="post">

NS4 won't know where to post the form to.

[[deleted]]

Cool. I never left the action field blank before.

If the action is left blank, Netscape submits the data to eactly the same URL that the form came from, but leaves out the filename. How cool.