Loop problem

[Anon]

Hi,

After nearly 19 hours of continuous coding my brain has finally died on this loop problem.

A main loop counter ($i) steps through an array which holds item lines for s shopping cart. The items in the cart have three delivery options. Standard delivery, Express AM delivery or Express PM delivery. An additonal charge is made for either of the express services for any item which is delivered on a different day to any of the remaining items in the array. Here's my feeble attempt:

// -------------- Any additional charges? ----------------------------------

$duplicate_express = 0;
if ($shopping_basket_delivery_option_array[$i] == 'Guaranteed AM delivery' || $shopping_basket_delivery_option_array[$i] == 'Guaranteed PM delivery'){

for ($z = 0; $z < $i; $z++){

   if($shopping_basket_delivery_date_array[$z] == 						$shopping_basket_delivery_date_array[$i]){
 		$duplicate_express = 1;


   }

}
}
if ($duplicate_express == 1){
$additional_charges_total += $express_charge;
$extra_charge_amount_string = $abbreviation[$TheCurrency].trim(sprintf("%3.2f",($conversion * $express_charge)));
}else {
$extra_charge_amount_string = "";
}

// --------------------------------------------------------------------------

and it's just not giving the correct results.
I'd really appreciate a fresh set of eyes (and brain) to tell me what's wrong here please.

kind regards, Graham

[Anon]

I noticed you have one brace to many

}
}
}

I would approach this with switch not if and use integer values

I wouldn't use strings as evaluation

Mark
hdwt.com

[[deleted]]

"I noticed you have one brace to many"

you noticed wrong.

[[deleted]]

Rule #1 in debuggin:
if it does not do what you think it should do, the print, print print!

Print the content of $shopping_basket_delivery_option_array[$i] before you use it in the IF.

dop things like:

if (foo==bar)
{
echo 'foo = bar';
// rest of your code here
}
else
{
echo 'foo != bar';
// rest of your code here.
}

this way you can see exactly what your script is doing.

[Anon]

I think you find im right

if ($shopping_basket_delivery_option_array[$i] == 'Guaranteed AM delivery' || $shopping_basket_delivery_option_array[$i] == 'Guaranteed PM delivery') // first -> {

for ($z = 0; $z < $i; $z++) // second {

if($shopping_basket_delivery_date_array[$z] == $shopping_basket_delivery_date_array[$i]) // third -> {
$duplicate_express = 1;

// -> forth }
// ->fifth }
// -> six }

Make sure you check before posting wrong comments !

One too many braces between his code

Mark
hdwt.com

[[deleted]]

sigh

"Make sure you check before posting wrong comments !"

I always do, you may want to do the same.

"One too many braces between his code"

one, two, three opening braces, and one, two three closing braces, six braces in all.

Please tell me which one you think should be taken out?

[Anon]

i agree with vincent. braces are ok: 3 open , 3 close .

[Anon]

OK i admit it, i was wrong

Good job it wasn't mission critical

Mark

[[deleted]]

lol it's just one of those days huh? :-)