Is this an infinite loop?

asleroid

I'm a beginner PHP learner and trying to learn PHP on my own without the help of the teacher I have because he doesn't know the language. I was exposed to loops in the last chapter that I'm done with and decided to do a little guess game. However, PHP keeps executing the script as if it were an infinite one. I wrote this on win 2000 using PHP4 that was installed from php4win.de . Can you tell me what's wrong about it? I'd really appreciate it if you could.

Here is the script

<BODY>
<?php
$number = rand(1,10);
do
{
echo "Guess is too high";
echo "try again";
?>
<FORM METHOD="Get" ACTION="guessgame.php">
<INPUT NAME="guess" TYPE="TEXT">
<INPUT TYPE="SUBMIT">
</FORM>
<?
} while ($guess>$number);
do
{
echo "Guess is too low";
echo "try again";
?>
<FORM METHOD="Get" ACTION="guessgame.php">
<INPUT NAME="guess" TYPE="TEXT">
<INPUT TYPE="SUBMIT">
</FORM>
<?
} while ($guess<$number);
if ($guess==$number)
{
echo "Congragulations";
}
?>
</BODY>

thanks

sarahk

it sure is, because you never change the value of $guess so the while clause is never met.

Do you want to use "do"? If so use $guess-- or $guess++

However I suspect you could just have

if ($guess > $number) $text = "guess is too high, try again";
else if ($guess < $number) $text = "guess is too low, try again";
else $text = "congratulations";

echo $text;

and you will only get one bit of text returned.

asleroid

well doesn't the user change the value of $guess every time he/she enters another guess?

brandonschnell

you're confusing server side and client side. php is a server side language. what the user enters is client side.

the two meets when the user enters the data and submits it. php checks the data on the server and sends something back to the client.